I rewrite it without the option:
https://gitlab.com/sim6/molly-guard/compare/master...sim6_hostname_case_insensitive_always
I will try to create a new version of the package.
Thanks!
On 2017-07-05 at 20:26:03, Simó Albert i Beltran wrote:
> The tr command is introducing a dependency of coreutils package.
I think it's fine to add a dependency on coreutils.
> I can change the default value of the option, but if you prefer I will
> remove the option.
Yes, I think we don't need
Thanks for your comments.
The tr command is introducing a dependency of coreutils package. This
is not strictly true because we use cat. But if it is configurable we
can recommend coreutils but if this is not configurable we need to add
coreutils as dependency.
I can change the default
On 2017-07-04 at 00:23:14, Simó Albert i Beltran wrote:
> What do you think about this patch?
>
> https://gitlab.com/sim6/molly-guard/compare/master...sim6_hostname_case_insensitive
Thanks for the patch!
I'd be tempted to make it even simpler: always do a case-insentive match (no
option).
What do you think about this patch?
https://gitlab.com/sim6/molly-guard/compare/master...sim6_hostname_case_insensitive
On 2017-02-25 16:17, Nicolas Braud-Santoni wrote:
Would a patch changing this behaviour be considered for inclusion?
If so, I would happily provide one.
That sounds like a good idea. I'd be happy to review and merge that.
Francois
Package: molly-guard
Version: 0.4.5-1.1
Severity: wishlist
Dear Maintainer,
molly-guard's 30-query-hostname script performs a case-sensitive
comparison of the short-form hostname with user input, which is
rather inconvenient since hostnames (at least in DNS) are
case-insensitive anyhow:
>
7 matches
Mail list logo
