Bug#859150: installation-guide: leaves many /tmp/tmp* files behind

[Holger Wansing]

Control: tags -1 + pending


Cyril Brulebois  wrote:
> Source: installation-guide
> Severity: serious
> Tags: patch
> Justification: Fills up /tmp on dillon.debian.org
> 
> Hi,
> 
> Maybe to ease hands-on debugging, dblatex is called with the -d flag,
> which tells it to leave temporary files behind. This ends up filling
> up dillon's /tmp (in addition to being rather bad style in the first
> place…).
> 
> Two possibilities:
>  - remove the -d flag entirely (untested);
>  - or set TMPDIR to a subdirectory of $tempdir, which gets automatically
>removed after a build.
> 
> The attached patch implements the second solution, but comments are
> welcome.

Patch tested and applied. Thanks


-- 

Created with Sylpheed 3.5.0 under
D E B I A N   L I N U X   8 . 0   " J E S S I E " .

Registered Linux User #311290 - https://linuxcounter.net/

Bug#859150: installation-guide: leaves many /tmp/tmp* files behind

[Holger Wansing]

Hi,

Am Fr. Mär. 31 00:24:41 2017 GMT+0200 schrieb Samuel Thibault:
> Hello Holger,
> 
> Cyril Brulebois, on ven. 31 mars 2017 00:09:34 +0200, wrote:
> > Maybe to ease hands-on debugging, dblatex is called with the -d flag,
> > which tells it to leave temporary files behind. This ends up filling
> > up dillon's /tmp (in addition to being rather bad style in the first
> > place…).
> 
> Is -d really useful now that we have seen the whole thing working?
> 
> Alternatively,
> 
> >  - or set TMPDIR to a subdirectory of $tempdir, which gets automatically
> >removed after a build.
> 
> would be fine to me, I'm just thinking that we perhaps just not need
> these files at all now.

There is probably a chance, that a new version of dblatex or
another tool breaks something some day.
So I would vote for the second variant.

Holger

-- 
Sent from my Jolla phone
http://www.jolla.com/

Bug#859150: installation-guide: leaves many /tmp/tmp* files behind

[Cyril Brulebois]

Samuel Thibault  (2017-03-31):
> Hello Holger,
> 
> Cyril Brulebois, on ven. 31 mars 2017 00:09:34 +0200, wrote:
> > Maybe to ease hands-on debugging, dblatex is called with the -d flag,
> > which tells it to leave temporary files behind. This ends up filling
> > up dillon's /tmp (in addition to being rather bad style in the first
> > place…).
> 
> Is -d really useful now that we have seen the whole thing working?
> 
> Alternatively,
> 
> >  - or set TMPDIR to a subdirectory of $tempdir, which gets automatically
> >removed after a build.
> 
> would be fine to me, I'm just thinking that we perhaps just not need
> these files at all now.

I didn't check history (because svn, mainly; and because I'd already
lost track of what I was initially doing), but if that was merely a
debug aid, removing it looks good to me. :)

FWIW dillon currently has an svn checkout with the TMPDIR patch, so no
hurry right now; just needs to be fixed for the release. ;-)


KiBi.


signature.asc
Description: Digital signature

Bug#859150: installation-guide: leaves many /tmp/tmp* files behind

[Samuel Thibault]

Hello Holger,

Cyril Brulebois, on ven. 31 mars 2017 00:09:34 +0200, wrote:
> Maybe to ease hands-on debugging, dblatex is called with the -d flag,
> which tells it to leave temporary files behind. This ends up filling
> up dillon's /tmp (in addition to being rather bad style in the first
> place…).

Is -d really useful now that we have seen the whole thing working?

Alternatively,

>  - or set TMPDIR to a subdirectory of $tempdir, which gets automatically
>removed after a build.

would be fine to me, I'm just thinking that we perhaps just not need
these files at all now.

Samuel

Bug#859150: installation-guide: leaves many /tmp/tmp* files behind

[Cyril Brulebois]

Source: installation-guide
Severity: serious
Tags: patch
Justification: Fills up /tmp on dillon.debian.org

Hi,

Maybe to ease hands-on debugging, dblatex is called with the -d flag,
which tells it to leave temporary files behind. This ends up filling
up dillon's /tmp (in addition to being rather bad style in the first
place…).

Two possibilities:
 - remove the -d flag entirely (untested);
 - or set TMPDIR to a subdirectory of $tempdir, which gets automatically
   removed after a build.

The attached patch implements the second solution, but comments are
welcome.


KiBi.
Index: build/buildone.sh
===
--- build/buildone.sh	(revision 70645)
+++ build/buildone.sh	(working copy)
@@ -232,7 +232,8 @@
 
 echo "Info: creating .pdf file..."
 
-( dblatex -d -V -T db2latex -b xetex -p ./stylesheets/dblatex.xsl \
+mkdir -p $tempdir/dblatex
+(TMPDIR=$tempdir/dblatex dblatex -d -V -T db2latex -b xetex -p ./stylesheets/dblatex.xsl \
 -o $tempdir/install.${language}.pdf \
 $tempdir/install.${language}.profiled.xml --param=lingua=${language} )
 RET=$?; [ $RET -ne 0 ] && return $RET