Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-14 Thread gregor herrmann
On Fri, 14 Apr 2017 06:38:44 +1000, Ben Finney wrote: > On 13-Apr-2017, gregor herrmann wrote: > > So basically new({'Vcs_Git'.. and new({'vCs-GiT'.. both create a > > working object, both actions have a working Vcs-Git() method which > > returns the correct value, and both don't have a vCs_GiT()

Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-13 Thread Ben Finney
On 13-Apr-2017, gregor herrmann wrote: > So basically new({'Vcs_Git'.. and new({'vCs-GiT'.. both create a > working object, both actions have a working Vcs-Git() method which > returns the correct value, and both don't have a vCs_GiT() method. Thank you for writing test cases! Yes, that

Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-13 Thread Ben Finney
On 13-Apr-2017, Alex Muntada wrote: > The patch provided below accepts any valid field ignoring case > by using the canonical name instead, so VCS-Git, vCS-gIT, etc. > will end up being Vcs-Git. Would that be compliant with Policy? My Perl-fu is not up to the task of understanding the changes

Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-13 Thread gregor herrmann
Control: tag -1 + patch pending On Thu, 13 Apr 2017 15:54:19 +0200, Alex Muntada wrote: > > So, with the above example, if each those field names were accepted, > > and they all map to the Perl object accessor ‘Vcs_Git’, and other Perl > > code still needed to spell the *accessor* name that way,

Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-13 Thread Alex Muntada
Ben Finney: > So, with the above example, if each those field names were accepted, > and they all map to the Perl object accessor ‘Vcs_Git’, and other Perl > code still needed to spell the *accessor* name that way, that would > IMO be compliant with Policy and would resolve this bug report. The

Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-12 Thread Ben Finney
On 12-Apr-2017, gregor herrmann wrote: > Maybe someone has an idea how we can simulate something like > case-insensitive method names? For resolving this bug, I think the method names don't need to change and don't need to be case-insensitive. The only behaviour needing resolution for this bug

Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-12 Thread Jonas Smedegaard
Quoting gregor herrmann (2017-04-12 23:30:08) > Control: tag -1 + confirmed > > On Mon, 10 Apr 2017 22:37:28 +1000, Ben Finney wrote: > > > Given a Perl module:: > > > > use Debian::Control::Stanza::Source; > > > > my $s = Debian::Control::Stanza::Source->new( { > >

Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-12 Thread Alex Muntada
gregor herrmann: Maybe someone has an idea how we can simulate something like case-insensitive method names? AUTOLOAD comes to mind, but that's something we'd probably like to avoid. Normalizing the method names is the alternative: replace dashes with underscores, make the whole method name

Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-12 Thread gregor herrmann
Control: tag -1 + confirmed On Mon, 10 Apr 2017 22:37:28 +1000, Ben Finney wrote: > Given a Perl module:: > > use Debian::Control::Stanza::Source; > > my $s = Debian::Control::Stanza::Source->new( { > 'Build-Depends' => "debhelper", > 'VCS-Git' =>

Bug#860023: libdebian-source-perl: Rejects valid field names based on letter case

2017-04-10 Thread Ben Finney
Package: libdebian-source-perl Version: 0.94 Severity: normal The ‘Debian::Control::Stanza’ constructor assumes that field names must have the exact case of the names as defined in that library. This assumption is incorrect. Given a Perl module:: use Debian::Control::Stanza::Source; my