Bug#862371: closed by Gianfranco Costamagna <locutusofb...@debian.org> (Re: Bug#862371: RFS: budgie-desktop/10.3.1-1)

[Gianfranco Costamagna]

hi, note that we can't sync in Ubuntu until you move the files in the correct 
location :)


(otherwise you will need breaks+replaces)

G.

Bug#862371: closed by Gianfranco Costamagna <locutusofb...@debian.org> (Re: Bug#862371: RFS: budgie-desktop/10.3.1-1)

[foss.freedom]

Thanks Gianfranco,

  I am currently working on a revised package that fixes some issues -
I will also include the fixes for the debian/rules review comments
from your good-self - much appreciated.

David

On 9 June 2017 at 19:33, Debian Bug Tracking System
<ow...@bugs.debian.org> wrote:
> This is an automatic notification regarding your Bug report
> which was filed against the sponsorship-requests package:
>
> #862371: RFS: budgie-desktop/10.3.1-1
>
> It has been closed by Gianfranco Costamagna <locutusofb...@debian.org>.
>
> Their explanation is attached below along with your original report.
> If this explanation is unsatisfactory and you have not received a
> better one in a separate message then please contact Gianfranco Costamagna 
> <locutusofb...@debian.org> by
> replying to this email.
>
>
> --
> 862371: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862371
> Debian Bug Tracking System
> Contact ow...@bugs.debian.org with problems
>
>
> -- Forwarded message --
> From: Gianfranco Costamagna <locutusofb...@debian.org>
> To: "862371-d...@bugs.debian.org" <862371-d...@bugs.debian.org>, 
> "foss.free...@gmail.com" <foss.free...@gmail.com>
> Cc:
> Bcc:
> Date: Fri, 9 Jun 2017 18:30:29 + (UTC)
> Subject: Re: Bug#862371: RFS: budgie-desktop/10.3.1-1
> Hi
>
>
> I sponsored it (and will sync in Ubuntu if you are ok).
>
> some nitpicks for a future upload:
>
> "cd debian/build && $(MAKE)"
>
>
> this seems wrong in configure, or is it something else?
> (I mean, build should be done in build target)
>
>
> override_dh_prep
> why?
>
> override_dh_installman:
> dh_installman debian/budgie-desktop.1
> dh_installman debian/budgie-panel.1
> dh_installman debian/budgie-polkit-dialog.1
> dh_installman debian/budgie-run-dialog.1
> dh_installman debian/budgie-wm.1
> dh_installman debian/budgie-daemon.1
>
>
> this can be done by a
>
> debian/package.manpages, to make the rules file less complicate
>
> now they are installed in budgie-core
> drwxr-xr-x root/root 0 2017-04-17 11:43 ./usr/share/man/
> drwxr-xr-x root/root 0 2017-04-17 11:43 ./usr/share/man/man1/
> -rw-r--r-- root/root   301 2017-04-17 11:43 
> ./usr/share/man/man1/budgie-daemon.1.gz
> -rw-r--r-- root/root   669 2017-04-17 11:43 
> ./usr/share/man/man1/budgie-desktop.1.gz
> -rw-r--r-- root/root   501 2017-04-17 11:43 
> ./usr/share/man/man1/budgie-panel.1.gz
> -rw-r--r-- root/root   382 2017-04-17 11:43 
> ./usr/share/man/man1/budgie-polkit-dialog.1.gz
> -rw-r--r-- root/root   484 2017-04-17 11:43 
> ./usr/share/man/man1/budgie-run-dialog.1.gz
> -rw-r--r-- root/root   605 2017-04-17 11:43 
> ./usr/share/man/man1/budgie-wm.1.gz
>
> maybe you want to move them in budgie-desktop or I don't know where
>
> (in this case I won't sync the package, and reupload a quick fix that will be 
> confined only in experimental)
>
> G.
>
>
> -- Forwarded message --
> From: "foss.freedom" <foss.free...@gmail.com>
> To: Debian Bug Tracking System <sub...@bugs.debian.org>, Gianfranco 
> Costamagna <locutusofb...@debian.org>
> Cc:
> Bcc:
> Date: Thu, 11 May 2017 21:35:58 +0100
> Subject: RFS: budgie-desktop/10.3.1-1
> Package: sponsorship-requests
> Severity: normal [important for RC bugs, wishlist for new packages]
>
>   Dear mentors,
>
>   I am looking for a sponsor for my package "budgie-desktop"
>
>  * Package name: budgie-desktop
>Version : 10.3.1-1
>Upstream Author : i...@solus-project.com
>  * URL : https://github.com/budgie-desktop/budgie-desktop
>  * License : LGPL-2.1/GPL2.0
>Section : x11
>
>   It builds those binary packages:
>
> budgie-core - Core package for Budgie-Desktop
>  budgie-core-dev - Development package for budgie-desktop
>  budgie-desktop - Desktop package for budgie-desktop
>  budgie-desktop-doc - documentation files for the budgie-desktop
>  gir1.2-budgie-desktop-1.0 - GNOME introspection library for budgie-desktop
>  libbudgie-plugin0 - Plugin library for budgie-desktop
>  libbudgietheme0 - Theme library for budgie-desktop
>  libraven0  - Raven library for budgie-desktop
>
>   To access further information about this package, please visit the
> following URL:
>
>   https://mentors.debian.net/package/budgie-desktop
>
>
>   Alternatively, one can download the package with dget using this command:
>
> dget -x 
> https://mentors.debian.net/debian/pool/main/b/budgie-desktop/budgie-desktop_10.3.1-1.dsc
>
> Notes:
>
> I hav

Bug#862371: RFS: budgie-desktop/10.3.1-1

[foss.freedom]

Tim,

  absolutely superb - that worked very nicely :D

Not quite sure I understand why since I dont recognise that locale -
some-sort of special "C language" unicode locale? - but it works so
thats the main thing.


Gianfranco,

  A new version of the package has been uploaded with Tim's
suggestion.  Tested by building in a Stretch chroot.

In addition - as requested - the .installs have been simplified.

I also doubled checked this and threw this up on a launchpad PPA.

cheers

David

On 4 June 2017 at 22:15, Tim Dengel  wrote:
> Hi David,
>
> I haven't specifically looked into your issue and the build log doesn't
> seem to be available anymore, but it sounds like you're having trouble
> with meson being unable to deal with Unicode symbols inside a pbuilder
> chroot.
> I also have a package that builds with meson and had a FTBFS due to
> Unicode support (gnome-twitch), although admittedly it is a much simpler
> package than budgie. I fixed my issue by adding LC_ALL=C.UTF-8 in the
> d/rules file[0]. Maybe it helps.
>
> [0] https://github.com/dengelt/gnome-twitch/blob/debian/sid/debian/rules
>
>
> Regards,
>
> Tim
>
>
> Am 04.06.2017 um 19:46 schrieb foss.freedom:
>> Hi Gianfranco,
>>
>>   I'm struggling with this - any thoughts on my investigations below.
>>
>> On Debian Stretch I've created a chroot for unstable and installed the
>> build dependencies for budgie-desktop + locales + meson
>>
>> In debian/rules I've changed the two export LANG and LANGUAGE vars to
>> en_US.UTF-8
>>
>> Then manually (in the chroot) I have run the following:
>>
>> debconf-set-selections <<< 'locales locales/default_environment_locale
>> select en_US.UTF-8'
>>
>> dpkg-reconfigure locales
>>
>> update-locale LANGUAGE='en_US.UTF-8'
>>
>> N.B. the debconf-set-selections is to ensure dpkg-reconfigure locales
>> runs without the user having to manually select en_US.UTF-8 to the two
>> questions asked.
>>
>> That's enough to convince the dpkg-buildpackage -us -uc to work
>> correctly within the chroot
>>
>> The question I have is how to tuck the three commands above into the
>> Debian package to run before the main meson callout in debian/rules ?
>> i.e. I'm hoping this is the answer how to get the Debian build system
>> to default to a UTF-8 locale.
>>
>> I added the three commands within override_dh_auto_configure: but I
>> get a "sh:1  Syntax error: redirection unexpected" - so I'm kind of
>> stuck on how to move forward.
>>
>> I was hoping to find an existing Debian package that uses meson
>> building Vala within the archives to see how the maintainer did
>> something similar but my Google-fu has failed to find such a package
>> :(
>>
>> David
>>
>>
>> On 12 May 2017 at 19:09, foss.freedom  wrote:
>>> Thanks Gianfranco for the review.  Much appreciated.
>>>
>>> I have completely redone the licenses and files in debian/copyight and
>>> double checked via "check-all-the-things"
>>>
>>> For the .install files - all debian/tmp has been removed.
>>>
>>> the FTBFS is concerning.  I don't understand why there is a difference
>>> between the build systems of launchpad (it works) and Debian (it
>>> doesnt).
>>>
>>> I asked this question here -
>>> https://github.com/budgie-desktop/budgie-desktop/issues/921
>>>
>>> The advice is to ensure the environment variables LANG and LANGUAGE is
>>> set to en_US - I've added two export lines for these environment vars
>>> at the top of the debian/rules
>>>
>>> I've tested the rules changes on launchpad.  However I dont have
>>> access to the debian build system so I cannot verify.
>>>
>>> I have rebuilt on my debian stretch VM and this is OK.
>>>
>>> David
>>>
>>> On 11 May 2017 at 22:27, Gianfranco Costamagna  
>>> wrote:
 control: owner -1 !
 control: tags -1 moreinfo

 Hello, I will sponsor it,
 but please have a deep look at missing copyrights for a next upload, e.g.
 + * Copyright (C) 2017 taaem 


 other things:
 I don't understand why you prepended debian/tmp to install files, but as 
 you wish

 2) FTBFS
 http://debomatic-amd64.debian.net/distribution#experimental/budgie-desktop/10.3.1-1/buildlog

 G.
>>

Bug#862371: RFS: budgie-desktop/10.3.1-1

[Tim Dengel]

Hi David,

I haven't specifically looked into your issue and the build log doesn't
seem to be available anymore, but it sounds like you're having trouble
with meson being unable to deal with Unicode symbols inside a pbuilder
chroot.
I also have a package that builds with meson and had a FTBFS due to
Unicode support (gnome-twitch), although admittedly it is a much simpler
package than budgie. I fixed my issue by adding LC_ALL=C.UTF-8 in the
d/rules file[0]. Maybe it helps.

[0] https://github.com/dengelt/gnome-twitch/blob/debian/sid/debian/rules


Regards,

Tim


Am 04.06.2017 um 19:46 schrieb foss.freedom:
> Hi Gianfranco,
> 
>   I'm struggling with this - any thoughts on my investigations below.
> 
> On Debian Stretch I've created a chroot for unstable and installed the
> build dependencies for budgie-desktop + locales + meson
> 
> In debian/rules I've changed the two export LANG and LANGUAGE vars to
> en_US.UTF-8
> 
> Then manually (in the chroot) I have run the following:
> 
> debconf-set-selections <<< 'locales locales/default_environment_locale
> select en_US.UTF-8'
> 
> dpkg-reconfigure locales
> 
> update-locale LANGUAGE='en_US.UTF-8'
> 
> N.B. the debconf-set-selections is to ensure dpkg-reconfigure locales
> runs without the user having to manually select en_US.UTF-8 to the two
> questions asked.
> 
> That's enough to convince the dpkg-buildpackage -us -uc to work
> correctly within the chroot
> 
> The question I have is how to tuck the three commands above into the
> Debian package to run before the main meson callout in debian/rules ?
> i.e. I'm hoping this is the answer how to get the Debian build system
> to default to a UTF-8 locale.
> 
> I added the three commands within override_dh_auto_configure: but I
> get a "sh:1  Syntax error: redirection unexpected" - so I'm kind of
> stuck on how to move forward.
> 
> I was hoping to find an existing Debian package that uses meson
> building Vala within the archives to see how the maintainer did
> something similar but my Google-fu has failed to find such a package
> :(
> 
> David
> 
> 
> On 12 May 2017 at 19:09, foss.freedom  wrote:
>> Thanks Gianfranco for the review.  Much appreciated.
>>
>> I have completely redone the licenses and files in debian/copyight and
>> double checked via "check-all-the-things"
>>
>> For the .install files - all debian/tmp has been removed.
>>
>> the FTBFS is concerning.  I don't understand why there is a difference
>> between the build systems of launchpad (it works) and Debian (it
>> doesnt).
>>
>> I asked this question here -
>> https://github.com/budgie-desktop/budgie-desktop/issues/921
>>
>> The advice is to ensure the environment variables LANG and LANGUAGE is
>> set to en_US - I've added two export lines for these environment vars
>> at the top of the debian/rules
>>
>> I've tested the rules changes on launchpad.  However I dont have
>> access to the debian build system so I cannot verify.
>>
>> I have rebuilt on my debian stretch VM and this is OK.
>>
>> David
>>
>> On 11 May 2017 at 22:27, Gianfranco Costamagna  
>> wrote:
>>> control: owner -1 !
>>> control: tags -1 moreinfo
>>>
>>> Hello, I will sponsor it,
>>> but please have a deep look at missing copyrights for a next upload, e.g.
>>> + * Copyright (C) 2017 taaem 
>>>
>>>
>>> other things:
>>> I don't understand why you prepended debian/tmp to install files, but as 
>>> you wish
>>>
>>> 2) FTBFS
>>> http://debomatic-amd64.debian.net/distribution#experimental/budgie-desktop/10.3.1-1/buildlog
>>>
>>> G.
> 

Bug#862371: RFS: budgie-desktop/10.3.1-1

[foss.freedom]

Hi Gianfranco,

  I'm struggling with this - any thoughts on my investigations below.

On Debian Stretch I've created a chroot for unstable and installed the
build dependencies for budgie-desktop + locales + meson

In debian/rules I've changed the two export LANG and LANGUAGE vars to
en_US.UTF-8

Then manually (in the chroot) I have run the following:

debconf-set-selections <<< 'locales locales/default_environment_locale
select en_US.UTF-8'

dpkg-reconfigure locales

update-locale LANGUAGE='en_US.UTF-8'

N.B. the debconf-set-selections is to ensure dpkg-reconfigure locales
runs without the user having to manually select en_US.UTF-8 to the two
questions asked.

That's enough to convince the dpkg-buildpackage -us -uc to work
correctly within the chroot

The question I have is how to tuck the three commands above into the
Debian package to run before the main meson callout in debian/rules ?
i.e. I'm hoping this is the answer how to get the Debian build system
to default to a UTF-8 locale.

I added the three commands within override_dh_auto_configure: but I
get a "sh:1  Syntax error: redirection unexpected" - so I'm kind of
stuck on how to move forward.

I was hoping to find an existing Debian package that uses meson
building Vala within the archives to see how the maintainer did
something similar but my Google-fu has failed to find such a package
:(

David


On 12 May 2017 at 19:09, foss.freedom  wrote:
> Thanks Gianfranco for the review.  Much appreciated.
>
> I have completely redone the licenses and files in debian/copyight and
> double checked via "check-all-the-things"
>
> For the .install files - all debian/tmp has been removed.
>
> the FTBFS is concerning.  I don't understand why there is a difference
> between the build systems of launchpad (it works) and Debian (it
> doesnt).
>
> I asked this question here -
> https://github.com/budgie-desktop/budgie-desktop/issues/921
>
> The advice is to ensure the environment variables LANG and LANGUAGE is
> set to en_US - I've added two export lines for these environment vars
> at the top of the debian/rules
>
> I've tested the rules changes on launchpad.  However I dont have
> access to the debian build system so I cannot verify.
>
> I have rebuilt on my debian stretch VM and this is OK.
>
> David
>
> On 11 May 2017 at 22:27, Gianfranco Costamagna  
> wrote:
>> control: owner -1 !
>> control: tags -1 moreinfo
>>
>> Hello, I will sponsor it,
>> but please have a deep look at missing copyrights for a next upload, e.g.
>> + * Copyright (C) 2017 taaem 
>>
>>
>> other things:
>> I don't understand why you prepended debian/tmp to install files, but as you 
>> wish
>>
>> 2) FTBFS
>> http://debomatic-amd64.debian.net/distribution#experimental/budgie-desktop/10.3.1-1/buildlog
>>
>> G.

Bug#862371: RFS: budgie-desktop/10.3.1-1

[Gianfranco Costamagna]

Also unstable is sad:

http://debomatic-amd64.debian.net/distribution#unstable/budgie-desktop/10.3.1-1/buildlog


G.



Il Venerdì 12 Maggio 2017 20:27, Gianfranco Costamagna 
 ha scritto:



Hello, still bad
http://debomatic-amd64.debian.net/distribution#experimental/budgie-desktop/10.3.1-1/buildlog


probably experimental is using a different apt solver so it picks up some 
new/different toolchain.

BTW still useless this change
-usr/include
-usr/lib/lib*.so
-usr/lib/pkgconfig
-usr/share/gir-1.0
-usr/share/vala
+usr/include /usr

+usr/lib/lib*.so /usr/lib
+usr/lib/pkgconfig /usr/lib
+usr/share/gir-1.0 /usr/share
+usr/share/vala /usr/share



and so on, the second part can be omitted when it is the same as the first one


G.

Bug#862371: RFS: budgie-desktop/10.3.1-1

[Gianfranco Costamagna]

Hello, still bad
http://debomatic-amd64.debian.net/distribution#experimental/budgie-desktop/10.3.1-1/buildlog


probably experimental is using a different apt solver so it picks up some 
new/different toolchain.

BTW still useless this change
-usr/include
-usr/lib/lib*.so
-usr/lib/pkgconfig
-usr/share/gir-1.0
-usr/share/vala
+usr/include /usr

+usr/lib/lib*.so /usr/lib
+usr/lib/pkgconfig /usr/lib
+usr/share/gir-1.0 /usr/share
+usr/share/vala /usr/share



and so on, the second part can be omitted when it is the same as the first one

G.

Bug#862371: RFS: budgie-desktop/10.3.1-1

[foss.freedom]

Thanks Gianfranco for the review.  Much appreciated.

I have completely redone the licenses and files in debian/copyight and
double checked via "check-all-the-things"

For the .install files - all debian/tmp has been removed.

the FTBFS is concerning.  I don't understand why there is a difference
between the build systems of launchpad (it works) and Debian (it
doesnt).

I asked this question here -
https://github.com/budgie-desktop/budgie-desktop/issues/921

The advice is to ensure the environment variables LANG and LANGUAGE is
set to en_US - I've added two export lines for these environment vars
at the top of the debian/rules

I've tested the rules changes on launchpad.  However I dont have
access to the debian build system so I cannot verify.

I have rebuilt on my debian stretch VM and this is OK.

David

On 11 May 2017 at 22:27, Gianfranco Costamagna  wrote:
> control: owner -1 !
> control: tags -1 moreinfo
>
> Hello, I will sponsor it,
> but please have a deep look at missing copyrights for a next upload, e.g.
> + * Copyright (C) 2017 taaem 
>
>
> other things:
> I don't understand why you prepended debian/tmp to install files, but as you 
> wish
>
> 2) FTBFS
> http://debomatic-amd64.debian.net/distribution#experimental/budgie-desktop/10.3.1-1/buildlog
>
> G.

Bug#862371: RFS: budgie-desktop/10.3.1-1

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo

Hello, I will sponsor it,
but please have a deep look at missing copyrights for a next upload, e.g.
+ * Copyright (C) 2017 taaem 


other things:
I don't understand why you prepended debian/tmp to install files, but as you 
wish

2) FTBFS
http://debomatic-amd64.debian.net/distribution#experimental/budgie-desktop/10.3.1-1/buildlog

G.

Bug#862371: RFS: budgie-desktop/10.3.1-1

[foss.freedom]

Package: sponsorship-requests
Severity: normal [important for RC bugs, wishlist for new packages]

  Dear mentors,

  I am looking for a sponsor for my package "budgie-desktop"

 * Package name: budgie-desktop
   Version : 10.3.1-1
   Upstream Author : i...@solus-project.com
 * URL : https://github.com/budgie-desktop/budgie-desktop
 * License : LGPL-2.1/GPL2.0
   Section : x11

  It builds those binary packages:

budgie-core - Core package for Budgie-Desktop
 budgie-core-dev - Development package for budgie-desktop
 budgie-desktop - Desktop package for budgie-desktop
 budgie-desktop-doc - documentation files for the budgie-desktop
 gir1.2-budgie-desktop-1.0 - GNOME introspection library for budgie-desktop
 libbudgie-plugin0 - Plugin library for budgie-desktop
 libbudgietheme0 - Theme library for budgie-desktop
 libraven0  - Raven library for budgie-desktop

  To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/budgie-desktop


  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/b/budgie-desktop/budgie-desktop_10.3.1-1.dsc

Notes:

I have tested the package on the latest Stretch

debian-testing-amd64-xfce-CD-1.iso   2017-05-08 08:38  642M

built through forcing a download via uscan, unpack and build using the
revamped debian package. N.B. this validated that the upstream
maintainer key new PGP signed key works.  built via "debuild -us -uc
-d"

Also built the same package on Ubuntu 17.10 Artful via Launchpad and
tested on 32bit and 64bit.

As requested I have reworked the package to reduce the lintian issues.

The key main one remaining is the extant  RPATH lintian issue that is
in the existing v10.2.9 budgie-desktop package.

upstream here basically says there is not alot that can be done.
https://github.com/budgie-desktop/budgie-desktop/issues/920

Since Debian is in the final release mode for Stretch so I guess
unstable is not the correct request for this?  Thus I've set the
changelog to build for experimental.

  Changes since the last upload:

  budgie-desktop (10.3.1-1) experimental; urgency=medium

  * New upstream release
  * Patches
- fortify: to support detecting run-time issues
- show_nm-applet_in_tray.patch: Ubuntu specific patch to display the
  network-manager applet
- 0001-imports-natray-Enforce-minimum-size-of-22px.patch
  Resolve system tray sizing issues
- 0002-Fix-typo-in-meson.build.patch
  Correct development package build
- 0003-Work-around-serious-regressions-in-GTK3.22.13.patch
  Add support for GTK+3.22.13 and later
- disable-popover-animations.patch
  Panel popover animations cause flashes on some setups.  Disabling
  the panel popover animation resolves this.
  * Packaging Changes:
- meson build dependency
- Add ubuntu specific build rule to enable network-manager to
  correctly display in the system tray
- Add man-pages for each executable
- Update Copyright for new source structure
- Update control file to support only GTK+3.18 and later together
  meson build dependency
- Update install files due to meson build
- Fix Conf-files lintian warnings
- Add library symbols
- Update watch file:
repo name change
detection of version format x.y as well as x.y.z
upstream maintainer GPG signed key pgpmangle
- Add maintainer GPG signed key
- add libmutter build dependency to GTK+3.24 libmutter-0-dev as
  an alternate for libmutter-dev based build environments
- changed standards version to 3.9.8
- Update copyright year for all Ikey Doherty statements


  Regards,
   David Mohammed