Bug#862753: Fwd: mpg123 crashes in Remote mode if FORMAT command issued when file loaded but not started playback

[Thomas Orgis]

Am Wed, 17 May 2017 08:13:32 +0200
schrieb Thomas Orgis : 

> Confirmed with current upstream mpg123 1.24.0:
> 
> $ mpg123 -R -o dummy
> @R MPG123 (ThOr) v8
> LP some_file.mp3
> @I ID3v2.title:some title
> @I ID3v2.artist:some band
> @I ID3v2.year:2017
> @I ID3v2.comment:whatever
> @I ID3v2.genre:some_style
> @P 1
> FORMAT
> @FORMAT 44100 2
> pause
> @P 2
> main: [src/mpg123.c:809] error: Deep trouble! Cannot flush to my output 
> anymore!
> 08:09|sturbolzen:~$ 

This should be fixed in the upcoming 1.25.0. Please test the
https://mpg123.org/snapshot .

$ src/mpg123 -R -o test
@R MPG123 (ThOr) v8
lp /home/thomas/daten/projekte/mosin_nagant/forced_to_kill_thor.mp3
@I forced_to_kill_thor
@P 1
format
@FORMAT 44100 2
p
@P 2
@S 1.0 3 44100 Stereo 0 417 2 0 0 0 128 0 0
@F 0 7335 0.00 191.61
@F 0 7335 0.00 191.61
@F 1 7335 0.03 191.61
@F 2 7334 0.05 191.58
@F 3 7333 0.08 191.56

I finally resorted to introducing new API to libmpg123 to avoid the
interference of FORMAT with the main playback loop.


Alrighty then,

Thomas


pgpRzfBh4L8fu.pgp
Description: Digitale Signatur von OpenPGP

Bug#862753: Fwd: mpg123 crashes in Remote mode if FORMAT command issued when file loaded but not started playback

[Thomas Orgis]

Am Tue, 16 May 2017 09:42:57 -0700
schrieb Al Schmidt : 

> pause/un-pause
> @P 2   // response: OK, playing
> file, but then...
> 
> [alsa.c:230] error: Fatal problem with alsa output, error -5.
> 
> [audio.c:614] error: Error in writing audio (Success?)!
> 
> [mpg123.c:681] error: Deep trouble! Cannot flush to my output anymore!

Confirmed with current upstream mpg123 1.24.0:

$ mpg123 -R -o dummy
@R MPG123 (ThOr) v8
LP some_file.mp3
@I ID3v2.title:some title
@I ID3v2.artist:some band
@I ID3v2.year:2017
@I ID3v2.comment:whatever
@I ID3v2.genre:some_style
@P 1
FORMAT
@FORMAT 44100 2
pause
@P 2
main: [src/mpg123.c:809] error: Deep trouble! Cannot flush to my output anymore!
08:09|sturbolzen:~$ 

This is something generic in the output part, having survived into libout123.

I need to look into this and will make a fix part of the 1.24.1
release. The change should be not too difficult to back-port.


Alrighty then,

Thomas


pgp3tIT4dVATP.pgp
Description: Digitale Signatur von OpenPGP

Bug#862753: Fwd: mpg123 crashes in Remote mode if FORMAT command issued when file loaded but not started playback

[Al Schmidt]

Package: mpg123
Version: 1.20.1-2+deb8u1

$ uname -a
Linux BBB 4.4.30-ti-r64 #1 SMP Fri Nov 4 21:23:33 UTC 2016 armv7l GNU/Linux

$ dpkg -s libc6 | grep ^Version
Version: 2.19-18+deb8u6

Description: the file sample rate is retrieved using the "FORMAT" command.
This is needed to calculate total and current time (in conjunction with the
sample count/total retrieved with "SAMPLE" command). If "FORMAT" command is
issued when a (valid) file has been loaded but playback not started (using
the "LOADPAUSED/LP" command) the sample rate (and channel count) are
properly reported. However, when playback of the file is started, mpg123
crashes (see log below). I have duplicated this on a USB sound "card" as
well as default hardware. It does not appear to be an alsa/audio issue
because the FORMAT command does return the correct value, and the file can
be played back correctly on the same system. I have also tried FORMAT then
"SEEK 0", "FORMAT" then "STOP" then "LOADPAUSED" and "PAUSE" but the crash
still happens. I've found no sequence of subsequent actions following a
"FORMAT" of an unplayed file that does not result in a crash upon playback.
Log: (inline descriptive comments added to actual log output is designated
by //)
Note: skipping the "FORMAT" command in the log below will prevent the crash.

$ mpg123 -R -a default:Device// start mpg123 in "Remote command mode"
with standard McASP audio device
@R MPG123 (ThOr) v8   // response: normal startup message
LOADPAUSED ./my_file.mp3  // command: "LOADPAUSED/LP" - load file
("my_file.mp3") but do not begin playback
@I ID3v2.title:my_track   // response: ID3 information...
@I ID3v2.artist:my_artist
@I ID3v2.album:my_album
@I ID3v2.year:2017
@I ID3v2.comment:12++
@I ID3v2.genre:Country & Folk
@P 1   // response: file loaded &
paused, ready to begin file playback
FORMAT // command: "FORMAT" - get audio
sample rate and channel count
@FORMAT 44100 2   // response: 44100 Hz, 2-channel
PAUSE// command: "PAUSE" -
pause/un-pause
@P 2   // response: OK, playing
file, but then...

[alsa.c:230] error: Fatal problem with alsa output, error -5.

[audio.c:614] error: Error in writing audio (Success?)!

[mpg123.c:681] error: Deep trouble! Cannot flush to my output anymore!