Bug#864385: live-boot: fix file duplication in initramfs-tools hook

[Raphael Hertzog]

Control: tag -1 + pending

Hello Daniel,

On Wed, 07 Jun 2017, Daniel Reichelt wrote:
> The duplication was introduced by [3] and is fixed by this patch to read
> 
> 8<-
> cp -a /bin/live-boot "${DESTDIR}/bin"
> >8-

Applied in the git repository, thanks for the patch.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#864385: live-boot: fix file duplication in initramfs-tools hook

[Daniel Reichelt]

Package: live-boot
Version: 1:20170112
Severity: minor
Tags: patch

Hi,

live-boot's initramfs-hook contains these lines ([1], [2]), which put
live-boot's /lib/live/boot/ twice into the initramfs image: the latter one at
/lib/live/boot/ and the former one - wrongly - also at /bin/boot/).


The duplication was introduced by [3] and is fixed by this patch to read

8<-
cp -a /bin/live-boot "${DESTDIR}/bin"
>8-


There were no problems in multiple testing scenarios (including booting from
the ISO and via PXE).


Thanks,

Daniel




[1]
https://anonscm.debian.org/cgit/debian-live/live-boot.git/tree/backend/initramfs-tools/live.hook#n31

[2]
https://anonscm.debian.org/cgit/debian-live/live-boot.git/tree/backend/initramfs-tools/live.hook#n34

[3]
https://anonscm.debian.org/cgit/debian-live/live-boot.git/commit/backend/initramfs-tools/live.hook?id=0aa07bd386f516176364e710e8b9132036c72986
diff --git a/backend/initramfs-tools/live.hook b/backend/initramfs-tools/live.hook
index 54a566f..889809a 100755
--- a/backend/initramfs-tools/live.hook
+++ b/backend/initramfs-tools/live.hook
@@ -28,7 +28,7 @@ fi
 [ "${QUIET}" ] || echo -n " core"
 
 mkdir -p "${DESTDIR}/bin"
-cp -a /bin/live-boot /lib/live/boot "${DESTDIR}/bin"
+cp -a /bin/live-boot "${DESTDIR}/bin"
 
 mkdir -p "${DESTDIR}/lib/live"
 cp -a /lib/live/boot "${DESTDIR}/lib/live"