Bug#868790: [Pkg-pascal-devel] Bug#868790: castle-game-engine: please make the build reproducible

2017-07-23 Thread Chris Lamb
Dear Michalis,

> I have applied a modified version of your patch upstream, see
> https://github.com/castle-engine/castle-engine/commit/35a19832b84c396c6c5d3521e8afd50f8055d492

Hurrah, thanks!

> I only moved the logic to a separate function CopyrightYears

Good idea! In my defense (!), I try and keep my diffs as minimal as
possible so:

 - They apply more-easily to newer versions (in case the patch never
   makes it upstream, obviously not applicable here)
 
 - They more easily demonstrate the problem to the maintainer, even
   if its done in a dumb way.

 - My Pascal is very very rusty! I last used it in 2004!

Anyway, thanks again for merging :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb, Debian Project Leader
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#868790: [Pkg-pascal-devel] Bug#868790: castle-game-engine: please make the build reproducible

2017-07-22 Thread Michalis Kamburelis
2017-07-18 19:00 GMT+02:00 Chris Lamb :
> Whilst working on the Reproducible Builds effort [0], we noticed
> that castle-game-engine could not be built reproducibly.
>
> This is because it uses the current year when generating a "Copyright"
> string.
>
> Patch attached.

Hi,

I have applied a modified version of your patch upstream, see
https://github.com/castle-engine/castle-engine/commit/35a19832b84c396c6c5d3521e8afd50f8055d492
(I only moved the logic to a separate function CopyrightYears, used 2
times). Thank you!

Regards,
Michalis