Bug#868875: Status update
It seems like there are a lot of bug fixes in the latest version:
https://github.com/canonical/cloud-utils/blob/master/bin/growpart
If there is a desire to only fix this >2TB disk bug and not the others, I've
extracted the patch for the 2TB limit and am attaching it here.
Cheers,
Adam
On April 26, 2021 1:57:40 AM CDT, Thomas Goirand wrote:
>Hi,
>
>Thanks for the information.
>
>On 4/26/21 2:29 AM, a...@hax0rbana.org wrote:
>> [...]
>> So I believe this is fixed upstream and I'd love to help get the
>patched
>> version accepted into buster. If anyone can let me know how I can
>help
>> make this happen, please let me know.
>
>Well, easy, just send a patch, and someone (probably me) will add it to
>the current package, then ping the Stable release team to ask if they
>find it acceptable for Buster.
>
>Cheers,
>
>Thomas Goirand
--
Sent from my iPod. Please excuse my brevity.--- growpart 2021-04-28 04:07:32.10595 +
+++ growpart 2021-04-28 04:17:09.269811349 +
@@ -282,18 +282,22 @@
[ -n "${max_end}" ] ||
fail "failed to get max_end for partition ${PART}"
- mbr_max_sectors=$((mbr_max_512*$((sector_size/512
- if [ "$max_end" -gt "$mbr_max_sectors" ]; then
- max_end=$mbr_max_sectors
- fi
-
if [ "$format" = "gpt" ]; then
# sfdisk respects 'last-lba' in input, and complains about
# partitions that go past that. without it, it does the right thing.
sed -i '/^last-lba:/d' "$dump_out" ||
fail "failed to remove last-lba from output"
fi
-
+ if [ "$format" = "dos" ]; then
+ mbr_max_sectors=$((mbr_max_512*$((sector_size/512
+ if [ "$max_end" -gt "$mbr_max_sectors" ]; then
+ max_end=$mbr_max_sectors
+ fi
+ [ $(($disk_size/512)) -gt $mbr_max_512 ] &&
+ debug 0 "WARNING: MBR/dos partitioned disk is larger than 2TB." \
+"Additional space will go unused."
+ fi
+
local gpt_second_size="33"
if [ "${max_end}" -gt "$((${sector_num}-${gpt_second_size}))" ]; then
# if mbr allow subsequent conversion to gpt without shrinking the
Bug#868875: Status update
Hi, Thanks for the information. On 4/26/21 2:29 AM, a...@hax0rbana.org wrote: > [...] > So I believe this is fixed upstream and I'd love to help get the patched > version accepted into buster. If anyone can let me know how I can help > make this happen, please let me know. Well, easy, just send a patch, and someone (probably me) will add it to the current package, then ping the Stable release team to ask if they find it acceptable for Buster. Cheers, Thomas Goirand
Bug#868875: Status update
Since this is one of the top hits for this bug and it is still not resolved, I wanted to contribute an update of the state of things. This bug still exists in Debian 10 (buster), but the limit seems to have changed from 250GB to 2TB. It appears to be fixed upstream. I'll show how I came to these conclusions so others can reproduce my findings. This issue is the same in buster as was reported in CentOS 8 here: https://bugs.centos.org/view.php?id=17372 The error message I am receiving with a 10TB disk is "NOCHANGE: partition 2 is size 4293963776. it cannot be grown" After a bit of searching, I found the repo from which the responsible code appears to originate: https://github.com/canonical/cloud-utils/blob/master/bin/growpart#L390 max_end is set on line 356, which comes from dump_mod (all line numbers are from the repo linked above). dump_mod comes from dump_out on line 343 dump_out comes from line 328, which comes from sfdisk, which comes from the linux-util package. I have a test system which had a 10TB drive with three partitions (EFI, boot, root) on partitions 1, 2, and 3, respectively. Partition 3 was 4293963776 sectors, starting at 1003520 and last-lba was 21474836446. I took a look at the /usr/bin/growpart on a fully patched buster system and found that it was truncating max_size as if it was msdos formatted (mine isn't, it is gpt). This does not match what I am seeing on GitHub. I commented out the section in the script on my system that limited the size and it worked! The partition became 10TB. So I believe this is fixed upstream and I'd love to help get the patched version accepted into buster. If anyone can let me know how I can help make this happen, please let me know. -- Sent from my iPod. Please excuse my brevity.
