Bug#871502: Updating zotero-standalone

2018-02-21 Thread Antoine Beaupre
On Tue, Jan 30, 2018 at 02:59:11PM -0800, Diane Trout wrote:
> 
> > So I understand from your message that the main blocker is now to
> > have npm
> > updated.
> 
> The other issue is their default build process appears to download
> Firefox and extract and modify parts of it.
> 
> That needs to be modified to use Debian's version of Firefox, but I
> haven't figured out how yet.

But doesn't that assume that Firefox < 57 keeps on existing in Debian?
I'm not sure that's a given: older firefox releases will eventually go
away here too..

Zotero might call itself "standalone", but it's anything but: it's
really shipping a whole Firefox instance under there. So much that, in
fact, when I start the Zotero standalone binary downloaded from
Zotero.org, it does absolutely nothing unless I first *stop* Firefox
(>57) completely...

Really confusing too... And right now, given that the "firefox" on my
machine is FF 57, starting "zotero" (from the debian package) also
doesn't work *even when firefox is not running*. The process just hangs
failing to talk with the newer firefox binary...

A workaround:

firefox-esr -app /usr/share/zotero-standalone/application

.. but now of course I can't do that since I ran Zotero 5 once, which
upgraded my database with no chance of going back...

Sigh.

A.


signature.asc
Description: PGP signature


Bug#871502: Updating zotero-standalone

2018-01-30 Thread Diane Trout

> So I understand from your message that the main blocker is now to
> have npm
> updated.

The other issue is their default build process appears to download
Firefox and extract and modify parts of it.

That needs to be modified to use Debian's version of Firefox, but I
haven't figured out how yet.

signature.asc
Description: This is a digitally signed message part


Bug#871502: Updating zotero-standalone

2018-01-29 Thread Sébastien Villemot
On Tue, Jan 23, 2018 at 11:37:26AM -0800, Diane Trout wrote:
> 
> > 
> > Thanks for your contribution. However note that we cannot use your
> > packaging
> > for the official Debian package, because AFAIK npm downloads the
> > javascript
> > libraries at build time, which is clearly not acceptable in Debian.
> > The full
> > source needs to be included in the tarball (and the package needs to
> > be
> > buildable without network access).
> > 
> 
> I'm a Debian Developer too so know about the need to build in a chroot
> with no network. I'd was confused how to update get-orig-source, and
> saw others had been too, so I wanted to leave some documentation about
> what I'd tried.

BTW, if you think your work can be a sound basis for an update of the zotero
package, please feel free to push it to the Debian repo (it's currently in
collab-maint on alioth, it could also probably be migrated to the Debian group
on Salsa).

I don't want to stand in the way, especially since I don't have much
time/motivation for this package. I could even formally handover maintenance if
you're interested in it.

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄  http://www.debian.org


signature.asc
Description: PGP signature


Bug#871502: Updating zotero-standalone

2018-01-29 Thread Sébastien Villemot
On Tue, Jan 23, 2018 at 11:37:26AM -0800, Diane Trout wrote:
> 
> > 
> > Thanks for your contribution. However note that we cannot use your
> > packaging
> > for the official Debian package, because AFAIK npm downloads the
> > javascript
> > libraries at build time, which is clearly not acceptable in Debian.
> > The full
> > source needs to be included in the tarball (and the package needs to
> > be
> > buildable without network access).
> > 
> 
> I'm a Debian Developer too so know about the need to build in a chroot
> with no network. I'd was confused how to update get-orig-source, and
> saw others had been too, so I wanted to leave some documentation about
> what I'd tried.
> 
> zotero wont build with the version of npm in Debian, so I spent some
> time experimenting with npm 5.6 to see if I could get that to build.
> 
> I learned npm 5.6 has a "prefer-offline" option that appears to prefer
> locally installed Debian packages.

Thanks, I was not aware of that option, it indeed seems like a good way to go
forward.

> I was able to build a .deb file for npm 5.6, but the resulting install
> doesn't work. I think the install file is missing something.
> 
> There are still some embedded copies of code that don't have a Debian
> equivalent. Although I did see that the Debian JS team shipped 1.4.21
> with some embedded copies of code, so that might not be a deal breaker.
> I need to get in touch with them 

As already discussed in this bug, I also think it's ok to have a few embedded
code copies as a temporary solution.

So I understand from your message that the main blocker is now to have npm
updated.

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄  http://www.debian.org


signature.asc
Description: PGP signature


Bug#871502: Updating zotero-standalone

2018-01-23 Thread Diane Trout

> 
> Thanks for your contribution. However note that we cannot use your
> packaging
> for the official Debian package, because AFAIK npm downloads the
> javascript
> libraries at build time, which is clearly not acceptable in Debian.
> The full
> source needs to be included in the tarball (and the package needs to
> be
> buildable without network access).
> 

I'm a Debian Developer too so know about the need to build in a chroot
with no network. I'd was confused how to update get-orig-source, and
saw others had been too, so I wanted to leave some documentation about
what I'd tried.

zotero wont build with the version of npm in Debian, so I spent some
time experimenting with npm 5.6 to see if I could get that to build.

I learned npm 5.6 has a "prefer-offline" option that appears to prefer
locally installed Debian packages.

I was able to build a .deb file for npm 5.6, but the resulting install
doesn't work. I think the install file is missing something.

There are still some embedded copies of code that don't have a Debian
equivalent. Although I did see that the Debian JS team shipped 1.4.21
with some embedded copies of code, so that might not be a deal breaker.
I need to get in touch with them 

I haven't reviewed the changes to npm's copyright file either, so I
don't know how much of a problem that'll be.

Diane

signature.asc
Description: This is a digitally signed message part


Bug#871502: Updating zotero-standalone

2018-01-23 Thread Sébastien Villemot
On Thu, Jan 18, 2018 at 10:26:53PM +, Trout, Diane E. wrote:

> I managed to figure out how to update get-orig-source.
> 
> I looked for the release tag in the zotero repository, and then picked
> the last commit before, or on that date.
> 
> (from debian/rules)
> 
> # 5.0.33 tag was on 2017 Dec 19
> COMMIT_VERSION=5.0.33+dfsg
> Z_COMMIT=22d3fbb
> ZB_COMMIT=b330e8e
> ZSB_COMMIT=9b0d0b3
> 
> I also managed to update the patches
> 
> I added the dependency on npm to try and build the client, as
> documented here:
> 
> https://www.zotero.org/support/dev/client_coding/building_the_standalon
> e_client
> 
> And then discovered that Debian's copy of npm is very old and wont
> run, so I've added a block to this bug 871502 with the out of date npm
> (870460)
> 
> I've pushed all the changes to a scratch repository on github.
> https://github.com/detrout/debian-zotero-standalone

Thanks for your contribution. However note that we cannot use your packaging
for the official Debian package, because AFAIK npm downloads the javascript
libraries at build time, which is clearly not acceptable in Debian. The full
source needs to be included in the tarball (and the package needs to be
buildable without network access).

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄  http://www.debian.org


signature.asc
Description: PGP signature


Bug#871502: Updating zotero-standalone

2018-01-18 Thread Trout, Diane E.
Hi,

I managed to figure out how to update get-orig-source.

I looked for the release tag in the zotero repository, and then picked
the last commit before, or on that date.

(from debian/rules)

# 5.0.33 tag was on 2017 Dec 19
COMMIT_VERSION=5.0.33+dfsg
Z_COMMIT=22d3fbb
ZB_COMMIT=b330e8e
ZSB_COMMIT=9b0d0b3

I also managed to update the patches

I added the dependency on npm to try and build the client, as
documented here:

https://www.zotero.org/support/dev/client_coding/building_the_standalon
e_client

And then discovered that Debian's copy of npm is very old and wont
run, so I've added a block to this bug 871502 with the out of date npm
(870460)

I've pushed all the changes to a scratch repository on github.
https://github.com/detrout/debian-zotero-standalone

Diane