Bug#875572: unifont FTCBFS: many reasons

2017-12-11 Thread Manuel A. Fernandez Montecelo 
Hi Paul,

2017-12-11 4:11 GMT+01:00 Paul Hardy :
> On Tue, Oct 31, 2017 at 1:52 PM, Manuel A. Fernandez Montecelo
>  wrote:
>> Control: tags -1 + pending
>
> I just want to note that this has not fallen off my radar.  I have
> already applied the patch in the upcoming version.
>
> I am hoping to provide a resolution to over 40 bug reports that
> someone has made against Unifont over the past few months on Savannah:
>
> https://savannah.gnu.org/bugs/?group=unifont
>
> I hope to get through most of those over the next month, and then
> provide an updated version for Debian.  I had worked through many more
> for the current Unifont release.
>
> This Debian bug was mentioned as being low priority, so I would like
> to submit the next release with as many updates as possible versus a
> "micro-release".
>
> I also recently helped the HarfBuzz maintainer identify a HarfBuzz
> bug.  HarfBuzz renders glyphs for Pango, which in turn renders text
> for GNOME.  I was not sure if there was something deep down in
> Unifont's structure that I would have to update, but that turns out
> not to be the case:
>
> https://bugzilla.gnome.org/show_bug.cgi?id=787284
>
> If anyone does need this patch applied urgently, let me know and I
> will be able to fix it the following weekend.  Otherwise, I am
> planning for a Unifont update with a lot of glyph fixes.

If it was me I'd prefer micro-releases rather than macro-releases,
specially if they touch different aspects (upstream vs packaging), but
in any case, it's fine for me that you choose what you're more
comfortable with :)

On our side, the bug should low-ish priority, unless it's annoying and
prevenging ot difficulting the job of Helmut to build other rev-deps.

Lastly, thanks for the feedback!

-- 
Manuel A. Fernandez Montecelo

Bug#875572: unifont FTCBFS: many reasons

2017-12-10 Thread Paul Hardy 
On Tue, Oct 31, 2017 at 1:52 PM, Manuel A. Fernandez Montecelo
 wrote:
> Control: tags -1 + pending

I just want to note that this has not fallen off my radar.  I have
already applied the patch in the upcoming version.

I am hoping to provide a resolution to over 40 bug reports that
someone has made against Unifont over the past few months on Savannah:

https://savannah.gnu.org/bugs/?group=unifont

I hope to get through most of those over the next month, and then
provide an updated version for Debian.  I had worked through many more
for the current Unifont release.

This Debian bug was mentioned as being low priority, so I would like
to submit the next release with as many updates as possible versus a
"micro-release".

I also recently helped the HarfBuzz maintainer identify a HarfBuzz
bug.  HarfBuzz renders glyphs for Pango, which in turn renders text
for GNOME.  I was not sure if there was something deep down in
Unifont's structure that I would have to update, but that turns out
not to be the case:

https://bugzilla.gnome.org/show_bug.cgi?id=787284

If anyone does need this patch applied urgently, let me know and I
will be able to fix it the following weekend.  Otherwise, I am
planning for a Unifont update with a lot of glyph fixes.

Thank you,


Paul Hardy

Bug#875572: unifont FTCBFS: many reasons

2017-11-01 Thread Manuel A. Fernandez Montecelo 
Hi Paul,

2017-11-01 4:52 GMT+01:00 Paul Hardy :
> Greetings Manuel,
>
> On Tue, Oct 31, 2017 at 1:52 PM, Manuel A. Fernandez Montecelo
>  wrote:
>>
>> Control: tags -1 + pending
>>
>> Hi Paul,
>>
>> 2017-09-13 05:35 Paul Hardy:
>>>
>>> Helmut,
>>>
>>> ...
>>> I am preparing another upload, Unifont 10.0.07.  I have added your
>>> changes.  I also changed "install" to "$(INSTALL)" in src/Makefile so
>>> someone can redefine it on the command line to "install -s" if they
>>> want, for non-Debian builds.
>>
>>
>> Marking as +pending accordingly.
>>
>>> Is it okay with you if I wait until Sunday, October 1st.
>>
>>
>> 1st of November is here... so perhaps it can proceed now -- no rush
>> though, there's nothing critical depending on it AFAIK.
>
>
> It sounded like Helmut thought there was no rush with this, so I have
> updated the Makefile in question and made other changes to it ( with testing
> from the top-level Makefile, etc.).  But I am also going over a number of
> other proposed changes and hoped to release many changes in one release.  I
> am also trying to finish something on another free software project right
> now that is urgent.
>
> If anyone considers this urgent, I can perform an update during the next
> weekend.  Otherwise, I plan to have a release with many changes in December.
>
> In the meantime, thank you for marking this as "pending"; it does reflect
> the current state.

Yeah, it's correct that there's no need to rush with this fix, I also
mentioned it in my comment, sorry if I gave the wrong impression.

I supposed that there was a good reason for it, but at the time it
just felt odd for me to mark as pending without saying anything about
the other paragraph -- perhaps silence would have been better.


(I'm going through the many bugs that Helmut submitted, doing triaging
sometimes as in this case, uploading the fix in the case of abandoned
packages and where the fix is more urgent, so +pending helps future-me
or other people going through the list to ignore cases where this is
not needed).


Cheers.
-- 
Manuel A. Fernandez Montecelo

Bug#875572: unifont FTCBFS: many reasons

2017-10-31 Thread Paul Hardy 
Greetings Manuel,

On Tue, Oct 31, 2017 at 1:52 PM, Manuel A. Fernandez Montecelo <
manuel.montez...@gmail.com> wrote:

> Control: tags -1 + pending
>
> Hi Paul,
>
> 2017-09-13 05:35 Paul Hardy:
>
>> Helmut,
>>
>> ...
>> I am preparing another upload, Unifont 10.0.07.  I have added your
>> changes.  I also changed "install" to "$(INSTALL)" in src/Makefile so
>> someone can redefine it on the command line to "install -s" if they
>> want, for non-Debian builds.
>>
>
> Marking as +pending accordingly.
>
> Is it okay with you if I wait until Sunday, October 1st.
>
>
> 1st of November is here... so perhaps it can proceed now -- no rush
> though, there's nothing critical depending on it AFAIK.


It sounded like Helmut thought there was no rush with this, so I have
updated the Makefile in question and made other changes to it ( with
testing from the top-level Makefile, etc.).  But I am also going over a
number of other proposed changes and hoped to release many changes in one
release.  I am also trying to finish something on another free software
project right now that is urgent.

If anyone considers this urgent, I can perform an update during the next
weekend.  Otherwise, I plan to have a release with many changes in December.

In the meantime, thank you for marking this as "pending"; it does reflect
the current state.

Sincerely,


Paul Hardy

Bug#875572: unifont FTCBFS: many reasons

2017-10-31 Thread Manuel A. Fernandez Montecelo 

Control: tags -1 + pending


Hi Paul,

2017-09-13 05:35 Paul Hardy:

Helmut,

On Tue, Sep 12, 2017 at 3:33 AM, Helmut Grohne  wrote:


unifont fails to cross build from source, for a pile of reasons, all of
which are fixed in the attached patch. After applying it, unifont cross
builds successfully.


Thank you for explaining this issue in such detail, and for taking the
time to put together a patch.

I am preparing another upload, Unifont 10.0.07.  I have added your
changes.  I also changed "install" to "$(INSTALL)" in src/Makefile so
someone can redefine it on the command line to "install -s" if they
want, for non-Debian builds.


Marking as +pending accordingly.



Is it okay with you if I wait until Sunday, October 1st to perform
this upload?  I will be away from home the weekend after next without
a computer; I would rather not perform an upload right before being
away from home.


That's a sensible move (or rather, non-move) :D

1st of November is here... so perhaps it can proceed now -- no rush
though, there's nothing critical depending on it AFAIK.

--
Manuel A. Fernandez Montecelo

Bug#875572: unifont FTCBFS: many reasons

2017-09-12 Thread Paul Hardy 
Helmut,

On Tue, Sep 12, 2017 at 3:33 AM, Helmut Grohne  wrote:
>
> unifont fails to cross build from source, for a pile of reasons, all of
> which are fixed in the attached patch. After applying it, unifont cross
> builds successfully.

Thank you for explaining this issue in such detail, and for taking the
time to put together a patch.

I am preparing another upload, Unifont 10.0.07.  I have added your
changes.  I also changed "install" to "$(INSTALL)" in src/Makefile so
someone can redefine it on the command line to "install -s" if they
want, for non-Debian builds.

Is it okay with you if I wait until Sunday, October 1st to perform
this upload?  I will be away from home the weekend after next without
a computer; I would rather not perform an upload right before being
away from home.

Thanks again,


Paul Hardy

Bug#875572: unifont FTCBFS: many reasons

2017-09-12 Thread Helmut Grohne 
Source: unifont
Version: 1:10.0.06-1
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

unifont fails to cross build from source, for a pile of reasons, all of
which are fixed in the attached patch. After applying it, unifont cross
builds successfully. Let me explain the issues and ask you to apply it:

 * override_dh_auto_build-arch explicitly runs $(MAKE) and does not pass
   any cross compilers. Thus it uses the build architecture compiler.
   Indirecting it through dh_auto_build fixes that (and allows using
   --parallel if you so wish).
 * Even then the upstream src/Makefile uses the build architecture strip
   by passing -s to install. It is best to just remove those -s flags as
   their presence also breaks -dbgsym generation and stripping (and
   honouring DEB_BUILD_OPTIONS=nostrip) is generally handled by
   dh_strip.
 * Further down the road it tries to run just built utilities and that
   fails as running host arch code does not work during cross
   compilation. Fortunately these steps are not necessary for building
   unifont-bin, so adding "bindir" to override_dh_auto_build-arch fixes
   this.
 * Then make install runs these targets again, so my slightly ugly
   solution here is to inline the relevant parts of make install into
   override_dh_auto_install-arch.

I hope this works for you. At least it makes the arch-only build
blazingly fast.

Helmut
diff --minimal -Nru unifont-10.0.06/debian/changelog 
unifont-10.0.06/debian/changelog
--- unifont-10.0.06/debian/changelog2017-08-27 00:19:15.0 +0200
+++ unifont-10.0.06/debian/changelog2016-12-04 05:50:42.0 +0100
@@ -1,3 +1,14 @@
+unifont (1:10.0.06-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
++ Let dh_auto_build pass cross compilers to make
++ debian/patches/nostrip.patch: Do not strip during build
++ Only build "bindir" during arch-only build.
++ Add override_dh_auto_install-arch to only install arch:any components.
+
+ -- Helmut Grohne   Sun, 04 Dec 2016 05:50:42 +0100
+
 unifont (1:10.0.06-1) unstable; urgency=medium
 
   * Update to Unifont 10.0.06 release.
diff --minimal -Nru unifont-10.0.06/debian/patches/nostrip.patch 
unifont-10.0.06/debian/patches/nostrip.patch
--- unifont-10.0.06/debian/patches/nostrip.patch1970-01-01 
01:00:00.0 +0100
+++ unifont-10.0.06/debian/patches/nostrip.patch2016-12-04 
05:50:42.0 +0100
@@ -0,0 +1,30 @@
+From: Helmut Grohne 
+Subject: to not strip binaries during build
+
+ * install -s uses the build architecture strip and thus breaks cross
+   compilation.
+ * stripping during build means that dh_strip will be unable to generate useful
+   -dbgsym packages.
+
+Index: unifont-9.0.04/src/Makefile
+===
+--- unifont-9.0.04.orig/src/Makefile
 unifont-9.0.04/src/Makefile
+@@ -41,7 +41,7 @@
+ bin-stamp: $(CPROGS) $(PPROGS) $(PNGPROGS)
+   install-m0755 -d $(LOCALBINDIR)
+ # install-m0755 $? $(LOCALBINDIR)
+-  install -s -m0755 $(CPROGS) $(LOCALBINDIR)
++  install-m0755 $(CPROGS) $(LOCALBINDIR)
+   install-m0755 $(PPROGS) $(LOCALBINDIR)
+   \rm -f $(CPROGS)
+   touch $@
+@@ -56,7 +56,7 @@
+   install -m0755 -d $(INSTALLDIR)
+   set -e && \
+  cd $(LOCALBINDIR) && \
+- install -s -m0755 $(CPROGS) $(INSTALLDIR)
++ install-m0755 $(CPROGS) $(INSTALLDIR)
+   set -e && \
+  cd ../bin && \
+  install-m0755 $(PPROGS) $(INSTALLDIR)
diff --minimal -Nru unifont-10.0.06/debian/patches/series 
unifont-10.0.06/debian/patches/series
--- unifont-10.0.06/debian/patches/series   1970-01-01 01:00:00.0 
+0100
+++ unifont-10.0.06/debian/patches/series   2016-12-04 05:50:42.0 
+0100
@@ -0,0 +1 @@
+nostrip.patch
diff --minimal -Nru unifont-10.0.06/debian/rules unifont-10.0.06/debian/rules
--- unifont-10.0.06/debian/rules2017-07-05 01:52:34.0 +0200
+++ unifont-10.0.06/debian/rules2016-12-04 05:50:42.0 +0100
@@ -30,5 +30,9 @@
$(MAKE) BUILDFONT=1 PUA=""
 
 override_dh_auto_build-arch:
-   $(MAKE) CFLAGS='$(CFLAGS)' CPPFLAGS='$(CPPFLAGS)' \
-  LDFLAGS='$(LDFLAGS)'
+   dh_auto_build -- CFLAGS='$(CFLAGS)' CPPFLAGS='$(CPPFLAGS)' \
+  LDFLAGS='$(LDFLAGS)' bindir
+
+override_dh_auto_install-arch:
+   dh_auto_install --builddirectory=src -- PREFIX='$$(DESTDIR)/usr'
+   dh_auto_install --builddirectory=man -- PREFIX='$$(DESTDIR)/usr'