Bug#877388: s-nail adoption (build flags)

[Paride Legovini]

On 2018-02-13 14:27, Hilko Bengen wrote:
> * Paride Legovini:
> 
>> I: s-nail: hardening-no-fortify-functions usr/bin/s-nail
>> I: s-nail: hardening-no-fortify-functions usr/lib/s-nail/s-nail-privsep
> 
> I believe that your CFLAGS/LDFLAGS analysis for this warning (as well as
> the proposed change) is correct.

It seems that I've been able to fix all the issues by modifying a few
things in d/rules. Here is the updated file, with some comments:

https://salsa.debian.org/debian/s-nail/blob/master/debian/rules

Lintian is happier now, still I would appreciate a manual review of the
changes I made.

Cheers,

Paride

Bug#877388: s-nail adoption (build flags)

[Hilko Bengen]

* Paride Legovini:

> I: s-nail: hardening-no-fortify-functions usr/bin/s-nail
> I: s-nail: hardening-no-fortify-functions usr/lib/s-nail/s-nail-privsep

I believe that your CFLAGS/LDFLAGS analysis for this warning (as well as
the proposed change) is correct.

> W: s-nail-dbgsym: debug-file-with-no-debug-symbols
> usr/lib/debug/.build-id/a7/0016ff0ddb7b0e70321b28e68f529204140f60.debug
> W: s-nail-dbgsym: debug-file-with-no-debug-symbols
> usr/lib/debug/.build-id/b0/3145705a4f0f2c7171bac4dc4b2c2ba23bb372.debug

There is more than one possible reason for this: The C compiler may not
have not added debug symbols in the first place (look for -g...). Or the
debug symbols may have been removed afterwards (look for strip or
install -s).

Cheers,
-Hilko

Bug#877388: s-nail adoption (build flags)

[Paride Legovini]

Hi Hilko,

I've been working a little bit on the package, and it seems to me that
at the moment the Debian build flags (CFLAGS and LDFLAGS as set by the
debhelper scripts) are not actually used when building the package.

Note for example this error (happens during dh_auto_install):

ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.
/bin/chown: changing ownership of
'/tmp/s-nail/debian/s-nail/usr/lib/s-nail/s-nail-privsep': Operation not
permitted
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be
preloaded (cannot open shared object file): ignored.

and these lintian messages:

I: s-nail: hardening-no-fortify-functions usr/bin/s-nail
I: s-nail: hardening-no-fortify-functions usr/lib/s-nail/s-nail-privsep

W: s-nail-dbgsym: debug-file-with-no-debug-symbols
usr/lib/debug/.build-id/a7/0016ff0ddb7b0e70321b28e68f529204140f60.debug
W: s-nail-dbgsym: debug-file-with-no-debug-symbols
usr/lib/debug/.build-id/b0/3145705a4f0f2c7171bac4dc4b2c2ba23bb372.debug

Adding a couple of lines like:

export EXTRA_CFLAGS="$(CFLAGS)"
export EXTRA_LDFLAGS="$(LDFLAGS)"

in d/rules makes the debug-file-with-no-debug-symbols warning go away,
so I truly think the Debian CFLAGS and LDFLAGS were not used.
Unfortunately this seems not to be sufficient to fix the other issues,
something I would like to do even if s-nail works fine as is.

Now I don't want you to dig into this issue for me, but if you already
thought about it in the past and somehow concluded, for example, that
those errors/warning are both unavoidable and not harmful, I'd like to
hear from you.

Thanks again,

Paride

Bug#877388: s-nail adoption

[Hilko Bengen]

Hi Paride,

I have transferred the s-nail repository to
. Now I need the name of your
Gitlab user so I can add you to the project.

Cheers,
-Hilko

Bug#877388: s-nail adoption

[Paride Legovini]

Dear Hilko,

If you didn't change your mind, I would like to adopt s-nail. I used it
quite a few times when developing email sending scripts and it always
served me well. I would be happy to take care of its Debian package.

I took a look at the packaging and I see it's up-to-date with the latest
upstream release and you're using the classic branch structure I'm
already familiar with. I would like to move the repository to salsa
(under the "debian" group, the equivalent of collab-maint). I already
maintain a couple of packages there.

I am not a DD, so I will need support in creating the repository and
sponsorship for the upload.

Best regards,

Paride



signature.asc
Description: OpenPGP digital signature