Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Lubomir Rintel]

On Fri, 5 Jan 2018 16:13:19 +0100 Tobias Frost  wrote:
> You want Debian revision -1, not -4..
> Sorry, have ask you again for another iteration...

https://mentors.debian.net/debian/pool/main/i/ioport/ioport_1.2-1.dsc

Thanks for your patience
Lubo

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Tobias Frost]

On Fri, Jan 05, 2018 at 03:30:35PM +0100, Lubomir Rintel wrote:
> On Fri, 5 Jan 2018 12:16:10 +0100 Tobias Frost  wrote:
> > On Fri, Jan 05, 2018 at 11:44:55AM +0100, Lubomir Rintel wrote:
> > > On Fri, 05 Jan 2018 11:20:02 +0100 Lubomir Rintel 
> > > wrote:

> > > Should I be bumping the package version number for each udpate? Should
> > > I be adding a new changelog entry for each? Even if not
> > > uploaded/released?
> > 
> > You keep the Debian revision the same until it is sponsored.
> 
> That's what I initially meant to do, but mentors.debian.org won't let
> me upload a changed package with the same version number.
> 
> I suppose I perhaps should've used 1~x version numbers until the
> package passes a review, but it doesn't seem to be something I could do
> anything about anymore.
> 

IIRC you can just overwrite it with a new upload. Beside that,
you can manually delete old upload and then reupload as a last resort.

> > For the 1st upload, you do not add entries to the changelog as well, it
> > is just "Initial Packaging (Closes: #ITP-Bug-Number).
> > Subsequent uploads will go more into details then, listing every change
> > made to the packaging.
> 
> > I recommend to browse through the documents linked in "3. Make the package"
> > in https://mentors.debian.net/intro-maintainers. They will probably help you
> > a lot to get into the (difficult) topic of packaging.
> > I know its a lot to read, but it helps to know "where to look"; it is not
> > necessary that you memorize everything to the letter, but a rough idea where
> > something is explained will help. (and the knowledge will also come with
> > using it anyway)
> 
> Yeah, I'm familiar with it (the link, not necessarily the content).
> 
> Still, while probably a great reference, the documentation doesn't seem
> to be too good at providing best practices guidance (should the package
> be versioned in a VCS? Should I pick any hosting or is it typical to
> keep it on alioth/salsa? Should I always be relying on latest
> debhelper? Etc.). I suppose that builds up with experience.

Yes, experience is important. Otherwise you can also take a look at other
packages in the archive. 

> The updated package:
> 
> https://mentors.debian.net/debian/pool/main/i/ioport/ioport_1.2-4.dsc

You want Debian revision -1, not -4..
Sorry, have ask you again for another iteration...

> Thanks
> Lubo
> 

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Christian Seiler]

On 01/05/2018 03:30 PM, Lubomir Rintel wrote:

On Fri, 5 Jan 2018 12:16:10 +0100 Tobias Frost  wrote:

You keep the Debian revision the same until it is sponsored.


That's what I initially meant to do, but mentors.debian.org won't let
me upload a changed package with the same version number.


You can remove the old package on Mentors via the web interface and
then upload the package in that version again with different contents.

Note that in my experience reuploading an existing version to Mentors
worked when done via FTP, but not via HTTP. (But that may be outdated
information, I haven't tried that in forever.)

Regards,
Christian

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Lubomir Rintel]

On Fri, 5 Jan 2018 12:16:10 +0100 Tobias Frost  wrote:
> On Fri, Jan 05, 2018 at 11:44:55AM +0100, Lubomir Rintel wrote:
> > On Fri, 05 Jan 2018 11:20:02 +0100 Lubomir Rintel 
> > wrote:
> > It's not clear to me what distribution to include in the changelog
> > ("sid", "unstable", "testing" or something else?)
> 
> Use unstable.

Done.

> > Should I be bumping the package version number for each udpate? Should
> > I be adding a new changelog entry for each? Even if not
> > uploaded/released?
> 
> You keep the Debian revision the same until it is sponsored.

That's what I initially meant to do, but mentors.debian.org won't let
me upload a changed package with the same version number.

I suppose I perhaps should've used 1~x version numbers until the
package passes a review, but it doesn't seem to be something I could do
anything about anymore.

> For the 1st upload, you do not add entries to the changelog as well, it
> is just "Initial Packaging (Closes: #ITP-Bug-Number).
> Subsequent uploads will go more into details then, listing every change
> made to the packaging.

> I recommend to browse through the documents linked in "3. Make the package"
> in https://mentors.debian.net/intro-maintainers. They will probably help you
> a lot to get into the (difficult) topic of packaging.
> I know its a lot to read, but it helps to know "where to look"; it is not
> necessary that you memorize everything to the letter, but a rough idea where
> something is explained will help. (and the knowledge will also come with
> using it anyway)

Yeah, I'm familiar with it (the link, not necessarily the content).

Still, while probably a great reference, the documentation doesn't seem
to be too good at providing best practices guidance (should the package
be versioned in a VCS? Should I pick any hosting or is it typical to
keep it on alioth/salsa? Should I always be relying on latest
debhelper? Etc.). I suppose that builds up with experience.

The updated package:

https://mentors.debian.net/debian/pool/main/i/ioport/ioport_1.2-4.dsc

Thanks
Lubo

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[gregor herrmann]

On Fri, 05 Jan 2018 12:07:28 +0100, Tobias Frost wrote:

> Note that dch(1) when invoked with "-r" will do that for you,
> along with updating the timestamp. (note that dch will throw away
> it when you do not edit anything in the log, workaround is 'dch -r ""')

Unless you set "DEBCHANGE_FORCE_SAVE_ON_RELEASE=no" in ~/.devscripts.

From /usr/share/doc/devscripts/devscripts.conf.ex :

# When --release was used and an editor presented, force the changelog
# to be explicitly saved in the editor?  If this is set to "no" then
# the changes made by --release will be automatically saved.
# DEBCHANGE_FORCE_SAVE_ON_RELEASE=yes


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Beatles


signature.asc
Description: Digital Signature

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Tobias Frost]

On Fri, Jan 05, 2018 at 11:44:55AM +0100, Lubomir Rintel wrote:
> On Fri, 05 Jan 2018 11:20:02 +0100 Lubomir Rintel 
> wrote:
> > Thank you for your review. The updated package is available here:
> > https://mentors.debian.net/debian/pool/main/i/ioport/ioport_1.2-3.dsc
> 
> This might actually need one more spin and your help (which is greatly
> appreciated).
> 
> It's not clear to me what distribution to include in the changelog
> ("sid", "unstable", "testing" or something else?)

Use unstable.
 
> Should I be bumping the package version number for each udpate? Should
> I be adding a new changelog entry for each? Even if not
> uploaded/released?

You keep the Debian revision the same until it is sponsored.
For the 1st upload, you do not add entries to the changelog as well, it
is just "Initial Packaging (Closes: #ITP-Bug-Number).
Subsequent uploads will go more into details then, listing every change
made to the packaging. 

> Also, I've added the Vcs-* tags to the debian/control file in Git, I've
> only learned about those after I've built the package linked to above.

Yeah, See my other mail!

> Thanks,
> Lubo

I recommend to browse through the documents linked in "3. Make the package"
in https://mentors.debian.net/intro-maintainers. They will probably help you
a lot to get into the (difficult) topic of packaging.
I know its a lot to read, but it helps to know "where to look"; it is not
necessary that you memorize everything to the letter, but a rough idea where
something is explained will help. (and the knowledge will also come with
using it anyway)

> 

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Tobias Frost]

Control: tags -1 moreinfo

Hi Lubomir,

On Fri, Jan 05, 2018 at 11:20:02AM +0100, Lubomir Rintel wrote:
> Control: tags -1 - moreinfo
> 
> On Thu, 04 Jan 2018 19:13:00 +0100 Tobias Frost 
> wrote:
> > Hi,
> > 
> > here's a review:
> > - d/changelog is for UNRELEASED.
> > (- you should also update the timestamp)
>
> Changed to sid. Hope that's all right.

Usually we write "unstable".
Note that dch(1) when invoked with "-r" will do that for you,
along with updating the timestamp. (note that dch will throw away
it when you do not edit anything in the log, workaround is 'dch -r ""')

> > - Optional: Please add a VCS for the packageing. For example you can
> > use salsa.debian.org to host it.
> 
> https://salsa.debian.org/lkundrak-guest/ioport
> 
> Done.

Cool!
However, please add the appropiate VCS-* fields to d/control:
VCS-Git: https://salsa.debian.org/lkundrak-guest/ioport.git
VCS-Browser: https://salsa.debian.org/lkundrak-guest/ioport

> > - Did you try to forward the patches to upstream?
> 
> Did so now. Just emailed them privately, because there's no list or bug
> tracker.

+1
You might want to add a "Forwarded: yes, by email" to the dep-3 header of
the patches to document that.
 
> > 
> > It's a pitty that it was "UNRELEASED..." This is the only showstopper
> > in the package and the other thinfs would have been fixable in a
> later
> > releases...
> > 
> > Please iterate and then remove the moreinfo tag...
> 
> Thank you for your review. The updated package is available here:
> https://mentors.debian.net/debian/pool/main/i/ioport/ioport_1.2-3.dsc
>

One small thing: Please enable hardening. You can add this line to
the top of d/rules to do the job:

export DEB_BUILD_MAINT_OPTIONS = hardening=+all

See for details: https://wiki.debian.org/Hardening


Sorry for the addtional stuff, but I guess we're close for an upload!
Ping me when ready!

--
tobi

> Lubo
>

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Lubomir Rintel]

On Fri, 05 Jan 2018 11:20:02 +0100 Lubomir Rintel 
wrote:
> Thank you for your review. The updated package is available here:
> https://mentors.debian.net/debian/pool/main/i/ioport/ioport_1.2-3.dsc

This might actually need one more spin and your help (which is greatly
appreciated).

It's not clear to me what distribution to include in the changelog
("sid", "unstable", "testing" or something else?)

Should I be bumping the package version number for each udpate? Should
I be adding a new changelog entry for each? Even if not
uploaded/released?

Also, I've added the Vcs-* tags to the debian/control file in Git, I've
only learned about those after I've built the package linked to above.

Thanks,
Lubo

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Lubomir Rintel]

Control: tags -1 - moreinfo

On Thu, 04 Jan 2018 19:13:00 +0100 Tobias Frost 
wrote:
> Hi,
> 
> here's a review:
> - d/changelog is for UNRELEASED.
> (- you should also update the timestamp)

Changed to sid. Hope that's all right.

> - d/compat can be bumped to 11 (you B-D on debhelper >11 already)

Done.

> - Optional: Please add a VCS for the packageing. For example you can
> use salsa.debian.org to host it.

https://salsa.debian.org/lkundrak-guest/ioport

Done.

> - Did you try to forward the patches to upstream?

Did so now. Just emailed them privately, because there's no list or bug
tracker.

> 
> It's a pitty that it was "UNRELEASED..." This is the only showstopper
> in the package and the other thinfs would have been fixable in a
later
> releases...
> 
> Please iterate and then remove the moreinfo tag...

Thank you for your review. The updated package is available here:
https://mentors.debian.net/debian/pool/main/i/ioport/ioport_1.2-3.dsc

Lubo

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Tobias Frost]

Control: tags -1 moreinfo

Hi,

here's a review:
- d/changelog is for UNRELEASED.
(- you should also update the timestamp)
- d/compat can be bumped to 11 (you B-D on debhelper >11 already)
- Optional: Please add a VCS for the packageing. For example you can
use salsa.debian.org to host it.
- Did you try to forward the patches to upstream?

It's a pitty that it was "UNRELEASED..." This is the only showstopper
in the package and the other thinfs would have been fixable in a later
releases...

Please iterate and then remove the moreinfo tag...

--
tobi

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Lubomir Rintel]

Control: noowner -1

There's a review request open on mentors.debian.net now:

https://mentors.debian.net/package/ioport

The up-to date version of the package is available here:

  https://mentors.debian.net/debian/pool/main/i/ioport

Download the package with dget using this command:

  dget -x https://mentors.debian.net/debian/pool/main/i/ioport/ioport_1.2-2.dsc

Bug#883628: ITP: ioport -- direct access to I/O ports from the command line

[Lubomir Rintel]

Package: wnpp
Severity: wishlist
Owner: Lubomir Rintel 

* Package name: ioport
  Version : 1.2
  Upstream Author : Richard Jones 
* URL : http://people.redhat.com/rjones/ioport/
* License : GPLv2+
  Programming Lang: C
  Description : direct access to I/O ports from the command line

These commands enable command line and script access directly to I/O
ports on PC hardware.

The packaging: https://people.freedesktop.org/~lkundrak/ioport/