Bug#883819: openssh source includes an onerous dependency on gtk-3

2017-12-12 Thread Colin Watson
Control: tag -1 pending

On Thu, Dec 07, 2017 at 04:25:44PM -0500, Jason Duerstock wrote:
> The openssh package requires gtk-3-dev, which introduces an excessively heavy 
> build footprint on systems
> that don't use a GUI.  The attached patch makes this requirement optional 
> with a build profile named
> "pkg.openssh.nognome".

Committed to master.  Thanks for the patch!

-- 
Colin Watson   [cjwat...@debian.org]



Bug#883819: openssh source includes an onerous dependency on gtk-3

2017-12-07 Thread Jason Duerstock
Source: openssh
Severity: normal
Tags: patch

Dear Maintainer,

The openssh package requires gtk-3-dev, which introduces an excessively heavy 
build footprint on systems
that don't use a GUI.  The attached patch makes this requirement optional with 
a build profile named
"pkg.openssh.nognome".

Please include this in your next source package update.

Thank you!



-- System Information:
Debian Release: buster/sid
Architecture: ia64

Kernel: Linux 3.14-0.bpo.2-mckinley (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
--- debian/rules2017-10-07 08:43:16.0 -0400
+++ debian/rules2017-12-07 15:56:25.277464323 -0500
@@ -144,7 +144,9 @@
$(MAKE) -C debian/build-deb $(PARALLEL) 
ASKPASS_PROGRAM='/usr/bin/ssh-askpass'
$(MAKE) -C debian/build-udeb $(PARALLEL) 
ASKPASS_PROGRAM='/usr/bin/ssh-askpass' ssh scp sftp sshd ssh-keygen
 
+ifeq ($(filter pkg.openssh.nognome,$(DEB_BUILD_PROFILES)),)
$(MAKE) -C contrib gnome-ssh-askpass3 CC='$(CC) $(CPPFLAGS) $(CFLAGS) 
-Wall -Wl,--as-needed $(LDFLAGS)' PKG_CONFIG=$(PKG_CONFIG)
+endif
 
 override_dh_auto_build-indep:
 
--- debian/control  2017-10-07 08:43:16.0 -0400
+++ debian/control  2017-12-07 15:39:41.595079474 -0500
@@ -9,7 +9,7 @@
dpkg-dev (>= 1.16.1~),
libaudit-dev [linux-any],
libedit-dev,
-   libgtk-3-dev,
+   libgtk-3-dev ,
libkrb5-dev | heimdal-dev,
libpam0g-dev | libpam-dev,
libselinux1-dev [linux-any],
@@ -178,6 +178,7 @@
  remove it once the upgrade is complete and nothing depends on it.
 
 Package: ssh-askpass-gnome
+Build-Profiles: 
 Section: gnome
 Priority: optional
 Architecture: any