Bug#884258: machinectl shell should use bash as a default

[Michael Biebl]

On Wed, 13 Dec 2017 01:26:00 +0100 Michael Biebl  wrote:
> Am 13.12.2017 um 00:30 schrieb Marco d'Itri:
> > Package: systemd-container
> > Version: 235-3
> > Severity: normal
> > 
> > Until https://github.com/systemd/systemd/issues/1395 will be fixed, 
> > machinectl should be patched to use /bin/bash as the default shell 
> > instead of /bin/sh.
> > While some people may favour a different interactive shell it is quite 
> > obvious that nobody wants to use dash as their interactive shell, so 
> > this saves the need to type "exec bash" every time.
> > 
> > This is a single line change in bus_machine_method_open_shell() in 
> > src/machine/machine-dbus.c.
> 
> Makes sense. Feel free to commit this change.

After the points raised upstream, I guess using /bin/bash is probably
not the best idea, as we can't know what's inside the container.

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#884258: machinectl shell should use bash as a default

[Michael Biebl]

On Wed, 13 Dec 2017 01:26:00 +0100 Michael Biebl  wrote:
> Am 13.12.2017 um 00:30 schrieb Marco d'Itri:
> > Package: systemd-container
> > Version: 235-3
> > Severity: normal
> > 
> > Until https://github.com/systemd/systemd/issues/1395 will be fixed, 
> > machinectl should be patched to use /bin/bash as the default shell 
> > instead of /bin/sh.
> > While some people may favour a different interactive shell it is quite 
> > obvious that nobody wants to use dash as their interactive shell, so 
> > this saves the need to type "exec bash" every time.
> > 
> > This is a single line change in bus_machine_method_open_shell() in 
> > src/machine/machine-dbus.c.
> 
> Makes sense. Feel free to commit this change.

I posted a PR for a more general approach at

https://github.com/systemd/systemd/pull/7682
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#884258: machinectl shell should use bash as a default

[Michael Biebl]

Am 13.12.2017 um 00:30 schrieb Marco d'Itri:
> Package: systemd-container
> Version: 235-3
> Severity: normal
> 
> Until https://github.com/systemd/systemd/issues/1395 will be fixed, 
> machinectl should be patched to use /bin/bash as the default shell 
> instead of /bin/sh.
> While some people may favour a different interactive shell it is quite 
> obvious that nobody wants to use dash as their interactive shell, so 
> this saves the need to type "exec bash" every time.
> 
> This is a single line change in bus_machine_method_open_shell() in 
> src/machine/machine-dbus.c.

Makes sense. Feel free to commit this change.

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#884258: machinectl shell should use bash as a default

[Marco d'Itri]

Package: systemd-container
Version: 235-3
Severity: normal

Until https://github.com/systemd/systemd/issues/1395 will be fixed, 
machinectl should be patched to use /bin/bash as the default shell 
instead of /bin/sh.
While some people may favour a different interactive shell it is quite 
obvious that nobody wants to use dash as their interactive shell, so 
this saves the need to type "exec bash" every time.

This is a single line change in bus_machine_method_open_shell() in 
src/machine/machine-dbus.c.

-- 
ciao,
Marco


signature.asc
Description: PGP signature