Bug#885029: xrdp: thinclient_drives not umounted after session terminated

[Thorsten Glaser]

Apparently, other users are also running into this problem:

   The systemd timesync problem appears to be because there are
   lingering dead xrdp-chansrv FUSE mounts in /proc/mounts, which
   causes […]

From https://mobile.twitter.com/thatcks/status/1027175746735927306 via
https://utcc.utoronto.ca/~cks/space/blog/linux/SystemdTimesyncdFailure

bye,
//mirabilos
-- 
Stéphane, I actually don’t block Googlemail, they’re just too utterly
stupid to successfully deliver to me (or anyone else using Greylisting
and not whitelisting their ranges). Same for a few other providers such
as Hotmail. Some spammers (Yahoo) I do block.

Bug#885029: xrdp: thinclient_drives not umounted after session terminated

[Thorsten Glaser]

>Dominik George dixit:
>
>>please test whether this is still reprodusible with a recent version
>>from sid.
>
>Yes, it still happens.

I just had it happen again.

d?  ? ?  ?  ?? thinclient_drives/

The session is closing properly, not crashing:

Apr  5 00:45:15 leee xrdp-sesman[16887]: (16887)(-1214032384)[CORE ] window 
manager (pid 16888) did exit, cleaning up session
Apr  5 00:45:16 leee xrdp-sesman[16887]: (16887)(-1214032384)[INFO ] calling 
auth_stop_session and auth_end from pid 16887
Apr  5 00:45:16 leee xrdp-sesman[16887]: pam_unix(xrdp-sesman:session): session 
closed for user tg
Apr  5 00:45:16 leee xrdp-sesman[16887]: (16887)(-1214032384)[DEBUG] 
cleanup_sockets:
Apr  5 00:45:16 leee xrdp-sesman[16887]: (16887)(-1214032384)[DEBUG] 
cleanup_sockets: deleting /var/run/xrdp/sockdir/xrdpapi_10
Apr  5 00:45:17 leee xrdp[16885]: (16885)(-1215062400)[DEBUG] Closed socket 18 
(AF_UNIX)
Apr  5 00:45:17 leee xrdp-sesman[6614]: (6614)(-1214032384)[INFO ] ++ 
terminated session:  username tg, display :10.0, session_pid 16887, ip 
2001:xxx::xxx:xxx::::46547 - socket: 12
Apr  5 00:45:17 leee xrdp[16885]: (16885)(-1215062400)[DEBUG] Closed socket 12 
(AF_INET6 2001:xxx::xxx:::: port 3389)
Apr  5 00:45:18 leee xrdp[16885]: (16885)(-1215062400)[DEBUG] 
xrdp_mm_module_cleanup
Apr  5 00:45:18 leee xrdp[16885]: (16885)(-1215062400)[DEBUG] Closed socket 17 
(AF_UNIX)

Yet, it is still mounted:

xrdp-chansrv on /home/tg/thinclient_drives type fuse.xrdp-chansrv 
(rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)

Versions of packages involved:

ii  xorgxrdp   0.9.5-2  i386 Remote Desktop 
Protocol (RDP) modules for X.org
ii  xrdp   0.9.6-1  i386 Remote Desktop 
Protocol (RDP) server
un  xrdp-pulseaudio-instal   (no description 
available)

bye,
//mirabilos
-- 
21:12⎜ sogar bei opensolaris haben die von der community so
ziemlich jeden mist eingebaut │ man sollte unices nich so machen das
desktopuser zuviel intresse kriegen │ das macht die code base kaputt
21:13⎜ linux war früher auch mal besser :D

Bug#885029: xrdp: thinclient_drives not umounted after session terminated

[Thorsten Glaser]

tags 885029 - moreinfo
thanks

Dominik George dixit:

>please test whether this is still reprodusible with a recent version
>from sid.

Yes, it still happens.

bye,
//mirabilos
-- 
[...] if maybe ext3fs wasn't a better pick, or jfs, or maybe reiserfs, oh but
what about xfs, and if only i had waited until reiser4 was ready... in the be-
ginning, there was ffs, and in the middle, there was ffs, and at the end, there
was still ffs, and the sys admins knew it was good. :)  -- Ted Unangst über *fs

Bug#885029: xrdp: thinclient_drives not umounted after session terminated

[Thorsten Glaser]

Package: xrdp
Version: 0.9.4-5
Followup-For: Bug #885029

Dominik George dixit:

> So, is the session really correctly terminated?

Yes, it is, I can confirm this on another system, i386 this time.

pstree output before and after is identical. pstree output during
the session has an extra dbus-daemon, and the following new subtrees:

+ ├─dbus-launch

- ├─xrdp
- └─xrdp-sesman
+ ├─xrdp───xrdp
+ └─xrdp-sesman───xrdp-sesman─┬─Xorg───3*[{Xorg}]
+ ├─ck-launch-sessi───x-session-manag─┬─icewm
+ │   ├─icewmbg
+ │   
└─icewmtray
+ └─xrdp-chansrv───{xrdp-chansrv}

I *know* this has worked before, with 0.9.1-* or so.

> I cannot reproduce anything of this after logging out.

Kindly try on a system without systemd, please.


Extra info on this system:

xrdp-chansrv on /home/tg/thinclient_drives type fuse.xrdp-chansrv 
(rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)
fusectl on /sys/fs/fuse/connections type fusectl (rw,relatime)
tg@leee:~ $ ll
ls: cannot access 'thinclient_drives': Transport endpoint is not connected
[…]
d?  ? ?  ?  ?? thinclient_drives/


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 4.13.0-1-686-pae (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/lksh
Init: sysvinit (via /sbin/init)

Versions of packages xrdp depends on:
ii  adduser  3.116
ii  libc62.25-5
ii  libfuse2 2.9.7-1
ii  libjpeg62-turbo  1:1.5.2-2+b1
ii  libopus0 1.2.1-1
ii  libpam0g 1.1.8-3.6
ii  libssl1.11.1.0g-2
ii  libx11-6 2:1.6.4-3
ii  libxfixes3   1:5.0.3-1
ii  libxrandr2   2:1.5.1-1
ii  lsb-base 9.20170808
ii  ssl-cert 1.0.39

Versions of packages xrdp recommends:
ii  fuse  2.9.7-1
ii  xorgxrdp  0.9.4-5

Versions of packages xrdp suggests:
pn  guacamole  
pn  xrdp-pulseaudio-installer  

Versions of packages xorgxrdp depends on:
ii  libc6  2.25-5
pn  xorg-input-abi-24  
ii  xserver-xorg-core [xorg-video-abi-23]  2:1.19.5-1

Versions of packages xorgxrdp recommends:
ii  xorg  1:7.7+19

Versions of packages xrdp is related to:
ii  tigervnc-standalone-server [vnc-server]  1.7.0+dfsg-8
ii  xserver-xorg-legacy  2:1.19.5-1

-- no debconf information

Bug#885029: xrdp: thinclient_drives not umounted after session terminated

[Dominik George]

Control: tags -1 + moreinfo

>This is still not correct: after the session has ended, the
>mountpoint must be umounted. Older xrdp versions even did this.

So, is the session really correctly terminated?

I cannot reproduce anything of this after logging out.

-nik

Bug#885029: xrdp: thinclient_drives not umounted after session terminated

[Thorsten Glaser]

Control: tags -1 - moreinfo

Dominik George dixit:

>> Now I have these extra mountpoints in the system:
>> 
>> fusectl on /sys/fs/fuse/connections type fusectl (rw,relatime)
>> xrdp-chansrv on /home/tglase/thinclient_drives type fuse.xrdp-chansrv 
>> (rw,nosuid,nodev,relatime,user_id=2339,group_id=141)
>
>Looks correct.

No, at least the second one is not correct.

>But again: Only the owner of a fuse mount point can stat the directory
>managed by this fuse process, which is the user running chansrv. It
>looks strange, but is a design decision.

This is still not correct: after the session has ended, the
mountpoint must be umounted. Older xrdp versions even did this.

bye,
//mirabilos
-- 
“ah that reminds me, thanks for the stellar entertainment that you and certain
other people provide on the Debian mailing lists │ sole reason I subscribed to
them (I'm not using Debian anywhere) is the entertainment factor │ Debian does
not strike me as a place for good humour, much less German admin-style humour”

Bug#885029: xrdp: thinclient_drives not umounted after session terminated

[Dominik George]

Control: tags -1 + moreinfo

> Now I have these extra mountpoints in the system:
> 
> fusectl on /sys/fs/fuse/connections type fusectl (rw,relatime)
> xrdp-chansrv on /home/tglase/thinclient_drives type fuse.xrdp-chansrv 
> (rw,nosuid,nodev,relatime,user_id=2339,group_id=141)

Looks correct.

> 
> Also, my home directory ls -lF’d doesn’t look too healthy:
> 
> d?   ? ?  ?  ?? thinclient_drives/
> 

Also looks correct (as already explained to you in person, and to others
in this bug tracker, several times).

But again: Only the owner of a fuse mount point can stat the directory
managed by this fuse process, which is the user running chansrv. It
looks strange, but is a design decision.

-nik


signature.asc
Description: PGP signature

Bug#885029: xrdp: thinclient_drives not umounted after session terminated

[Thorsten Glaser]

Package: xrdp
Version: 0.9.4-2
Severity: normal

I’ve logged onto a computer using xrdp, which created an IceWM session.
I terminated the session using IceWM’s logout functionality.

Now I have these extra mountpoints in the system:

fusectl on /sys/fs/fuse/connections type fusectl (rw,relatime)
xrdp-chansrv on /home/tglase/thinclient_drives type fuse.xrdp-chansrv 
(rw,nosuid,nodev,relatime,user_id=2339,group_id=141)

Also, my home directory ls -lF’d doesn’t look too healthy:

d?   ? ?  ?  ?? thinclient_drives/

I am in group 107(fuse).

-- System Information:
Debian Release: buster/sid
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'buildd-unstable'), (500, 'unstable')
Architecture: x32 (x86_64)
Foreign Architectures: i386, amd64

Kernel: Linux 4.13.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8)
Shell: /bin/sh linked to /bin/lksh
Init: sysvinit (via /sbin/init)

Versions of packages xrdp depends on:
ii  adduser  3.116
ii  libc62.25-5
ii  libfuse2 2.9.7-1
ii  libjpeg62-turbo  1:1.5.2-2+b1
ii  libopus0 1.2.1-1
ii  libpam0g 1.1.8-3.6
ii  libssl1.11.1.0g-2
ii  libx11-6 2:1.6.4-3
ii  libxfixes3   1:5.0.3-1
ii  libxrandr2   2:1.5.1-1
ii  lsb-base 9.20170808
ii  ssl-cert 1.0.39

Versions of packages xrdp recommends:
ii  fuse  2.9.7-1
ii  xorgxrdp  0.9.4-2

Versions of packages xrdp suggests:
pn  guacamole  

Versions of packages xorgxrdp depends on:
ii  libc6  2.25-5
pn  xorg-input-abi-24  
ii  xserver-xorg-core [xorg-video-abi-23]  2:1.19.5-1

Versions of packages xorgxrdp recommends:
pn  xorg  

Versions of packages xrdp is related to:
pn  vnc-server   
ii  xserver-xorg-legacy  2:1.19.5-1

-- no debconf information