Bug#886963: Diffoscope: different readelf implementations cause version parsing errors on FreeBSD

Hi Guangyuan, > When 'unknown' and '2.29' passed in, LooseVersion will fail What's really odd is that I could have sworn I already pushed this! Indeed, my working tree already had the fixed code, just not committed :) Anyway, done that now:

Bug#886963: Diffoscope: different readelf implementations cause version parsing errors on FreeBSD

2018-01-16 13:05 GMT+08:00 Guangyuan Yang : > Hi Chris, > > It still exists. Here is some investigation inside decorator > `skip_if_tool_version_is` For now, change the line + if m is None: + return 'unknown' to + if m is None: + return '0.00' in

Bug#886963: Diffoscope: different readelf implementations cause version parsing errors on FreeBSD

2018-01-12 2:36 GMT-05:00 Chris Lamb : > [Re-adding the bug to CC - please retain in future] > > Hi Guangyuan, > >> The error still exists > > This should fix it: > > >

Bug#886963: Diffoscope: different readelf implementations cause version parsing errors on FreeBSD

[Re-adding the bug to CC - please retain in future] Hi Guangyuan, > The error still exists This should fix it: https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=304660a54a433ff65ce0cef986b22b3d76793ab0 Regards, -- ,''`. : :' : Chris Lamb `. `'`

Bug#886963: Diffoscope: different readelf implementations cause version parsing errors on FreeBSD

tags 886963 + pending thanks Thanks Guangyuan! Fixed in Git: https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=304660a54a433ff65ce0cef986b22b3d76793ab0 Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-

Bug#886963: Diffoscope: different readelf implementations cause version parsing errors on FreeBSD

Source: diffoscope Version: 90 Severity: normal Test suite is failing on FreeBSD during the collecting phase: ___ ERROR collecting tests/comparators/test_elf.py ___ tests/comparators/test_elf.py:64: in