Bug#887126: RFS: ddupdate/0.2.0-1 #886546

[Alec Leamas]

Hi Juhani!


On 07/02/18 15:38, Juhani Numminen wrote:
> Hi Alec,
> 
> Alec Leamas kirjoitti 04.02.2018 klo 18:32
> 
>>> Please use up-to-date lintian. It'll give you an error tag and several
>>> informational and pedantic tags, some of which are easily dealt with.
>>
>> I'm using sid, updated as of current?!
> 
> "lintian -EIi --pedantic *.changes" will show the pedantic and info tags
> that I mentioned. 

OK, it's now basically looks OK. The
debian-watch-does-not-check-gpg-signature,
quilt-patch-missing-description and testsuite-autopkgtest-missing
diagnostics looks like false negatives to me (given that the patch is
truly trivial and will never be upstreamed)

>>> debian/rules:
>>> Debhelper has picked Makefile instead of setup.py, so you should add
>>> "--buildsystem=pybuild" after the --with arguments. Then you can
>> remove override_dh_build,
>>> override_dh_auto_install and override_dh_python3 rules, and delete the
>> file debian/install.
>>
>> However, this is on purpose. I control upstream, and the Makefile
>> actually does the right things. Is there anything wrong with this approach?
>>
>> That said, rules is in a much better shape since the review, cleaned up
>> and with a dh_override_missing added.
> 
> Your approach is fine, although you're using "--quiet" while verbose
> builds are preferred[1].  Back in 0.2.0 the Makefile didn't contain the
> build target and so I thought it was only for pylint etc.

hmalthough that link is in the autotools context. I'm using the
--quiet flag because I missed an error message in the flood of
non-silent output. IMHO, if the package contained native, compiled code
being verbose makes sense. But I don't really see  it here... Perhaps I
should implement V=1 support in the upstream Makefile...

> Alright. I think debian/py3dist-overrides is left over and can be deleted.

Indeed, fixed. Thanks for explanations, much appreciated!

New version uploaded to mentors.



Cheers!

--alec

Bug#887126: RFS: ddupdate/0.2.0-1 #886546

[Juhani Numminen]

Hi Alec,

Alec Leamas kirjoitti 04.02.2018 klo 18:32:
> Hi Juhani!
> 
> Thanks for your reply, and sorry that I missed it! It was probably lost
> in the noise, was not really prepared for a reply from the bug  so to
> speak. Listening to high-volume lists is not always easy :(
Not a problem, and you did reply to my ping quite swiftly!

>> Please use up-to-date lintian. It'll give you an error tag and several
>> informational and pedantic tags, some of which are easily dealt with.
> 
> I'm using sid, updated as of current?!

"lintian -EIi --pedantic *.changes" will show the pedantic and info tags
that I mentioned. 
The error tag is no longer present in the package :) For the record, it was
E: ddupdate source: build-depends-on-obsolete-package build-depends: dh-systemd 
=> use debhelper (>= 9.20160709)

>> This review is based on the package you have uploaded to mentors, but
> I also
>> had a look at your git repo, where you wrote in a commit message:
>>> debian: Fix Standards-Version: to current sid 4.0.0
>> Your sources for that information are outdated, you should check [1]
> instead.
> 
> This one beats me... should I read it that current standard is 4.1.3?

Correct.

> Fixing using the ideas Standards-Version == 4.1.3 and compat level ==
> 11. Still unsure, though.

Standards-Version refers to a version number of Debian Policy
(as specified in policy §4.1 and §5.6.11).  The latest version number
of the package debian-policy in sid will indicate the latest Policy
version, as will the online copy at debian.org/doc/debian-policy.

The manpage debhelper(7) is where debhelper's compat levels are documented.

>> debian/rules:
>> Debhelper has picked Makefile instead of setup.py, so you should add
>> "--buildsystem=pybuild" after the --with arguments. Then you can
> remove override_dh_build,
>> override_dh_auto_install and override_dh_python3 rules, and delete the
> file debian/install.
> 
> However, this is on purpose. I control upstream, and the Makefile
> actually does the right things. Is there anything wrong with this approach?
> 
> That said, rules is in a much better shape since the review, cleaned up
> and with a dh_override_missing added.

Your approach is fine, although you're using "--quiet" while verbose
builds are preferred[1].  Back in 0.2.0 the Makefile didn't contain the
build target and so I thought it was only for pylint etc.

>> The installed package is missing some Depends: "ModuleNotFoundError:
> No module named 'straight'".
> 
> Recent dependencies  for the .deb package looks ok to me. Note that the
> straight.plugin and sudo deps have been dropped by upstream.

Alright. I think debian/py3dist-overrides is left over and can be deleted.


Regards,
  Juhani

[1] https://wiki.debian.org/UpstreamGuide#Verbose_builds

Bug#887126: RFS: ddupdate/0.2.0-1 #886546

[Michael Kolmodin]

Hi Juhani!

Thanks for your reply, and sorry that I missed it! It was probably lost
in the noise, was not really prepared for a reply from the bug  so to
speak. Listening to high-volume lists is not always easy :(

For better or worse, both upstream and the packaging has evolved since
your review.

On Tue, 16 Jan 2018 15:22:37 +0200 Juhani Numminen
 wrote:
> Alec Leamas kirjoitti 14.01.2018 klo 11:07:
> > I am looking for a sponsor for my package "ddupdate"
>
> Here's a review, but please note that I cannot sponsor you.

It's a pity, but thanks anyway! Perhaps someone else could be motivated
once we are finished with this...
 
> I don't have network admin knowledge, so I didn't test the
functionality of ddupdate.

It's actually rather straight-forward these days, especially using the
ddupdate-config configuration script (which wasn't there when you
reviewed). That said, focusing on the packaging seems perfectly fine for me.

> Please use up-to-date lintian. It'll give you an error tag and several
> informational and pedantic tags, some of which are easily dealt with.

I'm using sid, updated as of current?!
 
> This review is based on the package you have uploaded to mentors, but
I also
> had a look at your git repo, where you wrote in a commit message:
> > debian: Fix Standards-Version: to current sid 4.0.0
> Your sources for that information are outdated, you should check [1]
instead.

This one beats me... should I read it that current standard is 4.1.3?

Fixing using the ideas Standards-Version == 4.1.3 and compat level ==
11. Still unsure, though.

> At the mentors site, you write:
> > I cannot understand what's wrong with the copyright file. I guess
it's a silly oversight.
> >
> > uscan works just fine for me, the watch file error seems weird.
>
> If you're referring to "P: ddupdate source: no-dep5-copyright", it's
because your
> debian/copyright doesn't follow the specification[2]: it doesn't have
a header paragraph
> and the license text for MIT isn't specified.

Fixed

> Uscan works for me as well, mentors.debian.net has a broken check indeed.

Good to hear :)
 
> debian/control: Please add Vcs-Git. To specify the branch, see
Policy[1] §5.6.26.

Fixed

> Typo in Description: ubiquotious->ubiquitous.

Fixed (actually not a typo, silly me couldn't  spell it).

> debian/ddupdate-docs.docs: There is no "ddupdate-docs" binary package
so this file
> doesn't do anything[3], please remove.

Fixed
 
> debian/README.debian: Typo: updatet->updated.

Fixed

> I think Debian should be capitalized as a proper noun in user
documentation.

Right, fixed

> debian/rules:
> Debhelper has picked Makefile instead of setup.py, so you should add
> "--buildsystem=pybuild" after the --with arguments. Then you can
remove override_dh_build,
> override_dh_auto_install and override_dh_python3 rules, and delete the
file debian/install.

However, this is on purpose. I control upstream, and the Makefile
actually does the right things. Is there anything wrong with this approach?

That said, rules is in a much better shape since the review, cleaned up
and with a dh_override_missing added.

> However, this causes that every file that setup.py installs goes into
the package.
> To control what gets installed, you can add something like this to
debian/rules:
> override_dh_install:
> dh_install
> rm debian/ddupdate/usr/share/doc/ddupdate/CONTRIBUTE.md \
> debian/ddupdate/usr/share/doc/ddupdate/LICENSE.txt

This is fixed upstream (which used to install these files, one of my
really bad ideas).

> The installed package is missing some Depends: "ModuleNotFoundError:
No module named 'straight'".

Recent dependencies  for the .deb package looks ok to me. Note that the
straight.plugin and sudo deps have been dropped by upstream.


Cheers!
--alec

Bug#887126: RFS: ddupdate/0.2.0-1 #886546

[Juhani Numminen]

Alec Leamas kirjoitti 14.01.2018 klo 11:07:
> I am looking for a sponsor for my package "ddupdate"

Here's a review, but please note that I cannot sponsor you.

I don't have network admin knowledge, so I didn't test the functionality of 
ddupdate.

Please use up-to-date lintian. It'll give you an error tag and several
informational and pedantic tags, some of which are easily dealt with.

This review is based on the package you have uploaded to mentors, but I also
had a look at your git repo, where you wrote in a commit message:
> debian: Fix Standards-Version: to current sid 4.0.0
Your sources for that information are outdated, you should check [1] instead.

At the mentors site, you write:
> I cannot understand what's wrong with the copyright file. I guess it's a 
> silly oversight.
>
> uscan works just fine for me, the watch file error seems weird.

If you're referring to "P: ddupdate source: no-dep5-copyright", it's because 
your
debian/copyright doesn't follow the specification[2]: it doesn't have a header 
paragraph
and the license text for MIT isn't specified.

Uscan works for me as well, mentors.debian.net has a broken check indeed.

debian/control: Please add Vcs-Git. To specify the branch, see Policy[1] 
§5.6.26.
Typo in Description: ubiquotious->ubiquitous.

debian/ddupdate-docs.docs: There is no "ddupdate-docs" binary package so this 
file
doesn't do anything[3], please remove.

debian/README.debian: Typo: updatet->updated.  I think Debian should be 
capitalized
as a proper noun in user documentation.

debian/rules:
Debhelper has picked Makefile instead of setup.py, so you should add
"--buildsystem=pybuild" after the --with arguments. Then you can remove 
override_dh_build,
override_dh_auto_install and override_dh_python3 rules, and delete the file 
debian/install.

However, this causes that every file that setup.py installs goes into the 
package.
To control what gets installed, you can add something like this to debian/rules:
override_dh_install:
dh_install
rm debian/ddupdate/usr/share/doc/ddupdate/CONTRIBUTE.md \
   debian/ddupdate/usr/share/doc/ddupdate/LICENSE.txt

The installed package is missing some Depends: "ModuleNotFoundError: No module 
named 'straight'".
The Depends will be automatically added if you implement the debian/rules 
changes
that I suggested above.


Regards,
Juhani

[1] https://www.debian.org/doc/debian-policy/
[2] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
[3] See manpage for dh_installdocs(1)

Bug#887126: RFS: ddupdate/0.2.0-1 #886546

[Alec Leamas]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "ddupdate"

   Package name: ddupdate
   Version : 0.2.0-1
   Upstream Author : Alec Leamas
   URL : https://github.com/leamas/ddupdate
   License : MIT
   Section : net

It builds those binary packages:

ddupdate   - Tool updating DNS data for dynamic IP addresses

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/ddupdate

Alternatively, one can download the package with dget using this command:

dget -x
https://mentors.debian.net/debian/pool/main/d/ddupdate/ddupdate_0.2.0-1.dsc

More information about ddupdate is on README at
https://github.com/leamas/ddupdate. Packaging-wise it's a small python3
package with very few dependencies.

Changes since the last upload:

ddupdate (0.2.0-1) experimental; urgency=medium

  * Initial debian package, closes: #886546.


 -- Alec Leamas   Sat, 13 Jan 2018 17:35:38 +0100


Regards,
   --Alec Leamas