Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Gianfranco Costamagna]

On Fri, 16 Mar 2018 16:50:18 +0100 Muri Nicanor  wrote:
> hm, somehow i didn't receive that mail...
> 
> On 03/15/2018 10:54 AM, Gianfranco Costamagna wrote:
> > control: owner -1 ! control: tags -1 moreinfo
> > 1) please fix the qt bug in this upload
> > 2) missing lots of copyrights, e.g. src/ThirdParty/Catch/* 
> > src/ThirdParty/PEGTL/*
> > do you need such external libraries? why aren't it packaged separately?
> they are- i apparently forgot to readd the folder to files-excluded at
> some point. i readded the folder now and repackaged and reimported the
> archive.
> 
> > 3) std-version is 4.1.3
> yes, should it not be?
> 
> > 4)  dh ${@} --parallel --with=autoreconf
> > isn't this automatic with compat level 10?
> both removed.
> 
> i've also fixed a bug in the usbguard.postinst script that errored out
> if one of the chmoded files didn't exist.
> 
> i've uploaded new versions of the packages to mentors.d.o and pushed all
> the commits to salsa.
> 
> cheers and thanks,

happily sponsored!

G.

> muri
> 

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Muri Nicanor]

hm, somehow i didn't receive that mail...

On 03/15/2018 10:54 AM, Gianfranco Costamagna wrote:
> control: owner -1 ! control: tags -1 moreinfo
> 1) please fix the qt bug in this upload
> 2) missing lots of copyrights, e.g. src/ThirdParty/Catch/* 
> src/ThirdParty/PEGTL/*
> do you need such external libraries? why aren't it packaged separately?
they are- i apparently forgot to readd the folder to files-excluded at
some point. i readded the folder now and repackaged and reimported the
archive.

> 3) std-version is 4.1.3
yes, should it not be?

> 4)  dh ${@} --parallel --with=autoreconf
> isn't this automatic with compat level 10?
both removed.

i've also fixed a bug in the usbguard.postinst script that errored out
if one of the chmoded files didn't exist.

i've uploaded new versions of the packages to mentors.d.o and pushed all
the commits to salsa.

cheers and thanks,
muri



signature.asc
Description: OpenPGP digital signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo

1) please fix the qt bug in this upload
2) missing lots of copyrights, e.g. src/ThirdParty/Catch/* 
src/ThirdParty/PEGTL/*
do you need such external libraries? why aren't it packaged separately?
3) std-version is 4.1.3
4)  dh ${@} --parallel --with=autoreconf
isn't this automatic with compat level 10?

dh ${@} should be enough now

other stuff LGTM

G.



signature.asc
Description: OpenPGP digital signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Nicolas Braud-Santoni]

On Sun, Feb 11, 2018 at 11:43:08PM +0100, Nicolas Braud-Santoni wrote:
> Hi Muri,
> 
> On Sun, Feb 11, 2018 at 10:45:44PM +0100, Muri Nicanor wrote:
> > i've pushed the tags, thanks for pointing that out.
> 
> You are welcome, and thanks for the swift reply.  :)

I won't have time to review with much depth tonight, but here is some quick
feedback:

- Standards-Version is out-of-date, this should be bumped to 4.1.3

- I think it should be possible to ship /etc/usbguard files with the right
  permissions, rather than clobbering the permissions in a maintainer script.

  I might have a stab at that tomorrow.

- The changelog could be improved:
  - It lacks some of the changes you made, like switching to dh 11, updating
debian/watch, adding a dep on asciidoctor, using dh_missing, ...
  - The changes don't seem sorted in a logical way; for instance “use 
dh_missing”
and “drop the dh-systemd dep” belong under “switch to debhelper 11”
  - You mention “bump standards version” without saying to what.
Same for “add correct section to libusbguard0”

  Here is what the changelog could look like:

>  * New upstream version 0.7.2
>+ Fix failure with read-only /etc (Closes: #868160)
>+ Fix usbguard leaking filehandles (Closes: #887671)
>+ Update upstream's signing key
>+ Remove upstreamed patches
>+ Add build dependencies on libaudit and asciidoctor
>+ Update debian/copyright
>
>  * Switch to debhelper 11
>+ Remove dh-systemd
>  It is part of debhelper (>= 9.20160709)
>+ Use dh_missing
>
>  * Bump standards version to 4.1.2
>+ debian/copyright: Use HTTPS format URI
>
>  * Update debian/watch
>  * Move the packaging repository to salsa.d.o
>  * Add metadata for scan-copyrights
>  * Set libusbguard0's section to lib
>  * debian/rules: Do not parse dpkg-genchangelog
>  * Add a postinstall script to fix file permissions in /etc/usbguard

  Note that this is very much not prescriptive advice: I'm not aware of
  a specific, required style for Debian changelogs.  However, I think this
  would convey more information, in a more structured way, to someone else
  reading the changelog.


Best,

  nicoo


signature.asc
Description: PGP signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Nicolas Braud-Santoni]

Hi Muri,

On Sun, Feb 11, 2018 at 10:45:44PM +0100, Muri Nicanor wrote:
> i've pushed the tags, thanks for pointing that out.

You are welcome, and thanks for the swift reply.  :)


Best,

  nicoo


signature.asc
Description: PGP signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Muri Nicanor]

Hi nicoo,

On 02/11/2018 08:32 PM, Nicolas Braud-Santoni wrote:
> On Wed, Jan 24, 2018 at 08:23:12PM +0100, Muri Nicanor wrote:
>> i've fixed the bugs and uploaded the new version of usbguard to mentors,
>> and i've also pushed all the commits to salsa.
> 
> Hi!
> 
> Thanks for the good work on usbguard.
> 
> 
> I started taking a look, but it seems you forgot to push tags to the
> repository on salsa.d.o, so it's a bit annoying to diff with the version
> currently in Debian (or even just run `gbp buildpackage`).
> 
> Could you do that?  It's just a `git push --tags`  :)

i've pushed the tags, thanks for pointing that out.

cheers,
muri

> 
> 
> Best,
> 
>   nicoo
> 



signature.asc
Description: OpenPGP digital signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Nicolas Braud-Santoni]

On Wed, Jan 24, 2018 at 08:23:12PM +0100, Muri Nicanor wrote:
> i've fixed the bugs

PS: You should tag those bugs as “pending” (meaning, pending upload);
I assumed you meant #868160 and #887671, which are closed by the
changelog, so I just did that.


signature.asc
Description: PGP signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Nicolas Braud-Santoni]

On Wed, Jan 24, 2018 at 08:23:12PM +0100, Muri Nicanor wrote:
> i've fixed the bugs and uploaded the new version of usbguard to mentors,
> and i've also pushed all the commits to salsa.

Hi!

Thanks for the good work on usbguard.


I started taking a look, but it seems you forgot to push tags to the
repository on salsa.d.o, so it's a bit annoying to diff with the version
currently in Debian (or even just run `gbp buildpackage`).

Could you do that?  It's just a `git push --tags`  :)


Best,

  nicoo


signature.asc
Description: PGP signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Muri Nicanor]

control: reopen -1
control: retitle -1 RFS: usbguard/0.7.2+ds-1

On 01/23/2018 08:36 AM, Tobias Frost wrote:
> Please do not close RFS in this cases, so that the context is maintained.
> A RFS should be only be closed when uploaded (or when there is no longer
> something to sponsor).
> 
> When you have a new version, please recycle the bug, and retitle it
> appropiatly.

oke! i'm reopening the bug and retitleing for the new version.
i've fixed the bugs and uploaded the new version of usbguard to mentors,
and i've also pushed all the commits to salsa.

cheers,
muri



signature.asc
Description: OpenPGP digital signature

Bug#887665: marked as done (RFS: usbguard/0.7.1+ds-1)

[Tobias Frost]

> Date: Mon, 22 Jan 2018 17:27:02 +0100
> From: Muri Nicanor 
> To: Adam Borowski , 887665-d...@bugs.debian.org
> Subject: Re: Bug#887665: RFS: usbguard/0.7.1+ds-1
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
>  Thunderbird/52.4.0
> 
> Hi,
> 
> thanks Adam for the review and the input. There was a new usbguard
> release today, so i'll close this RFS and reopen a new one for the new
> release soon. I'll fix the mentioned shortcomings in the new upload.
> 
> cheers,
> muri
> 

Please do not close RFS in this cases, so that the context is maintained.
A RFS should be only be closed when uploaded (or when there is no longer
something to sponsor).

When you have a new version, please recycle the bug, and retitle it
appropiatly.

Thanks!