Bug#888495: check_haproxy_stats: Please change default location admin sock

[Jean-Michel Vourgère]

Control: tags -1 +patch

Trivial patch attached
Description: Change haproxy default socket to match debian haproxy
 haproxy enables admin socket at /var/run/haproxy/admin.sock by default since 1.5~dev24-2.
 .
 This fixes the default location to work out of the box.
Bug-Debian: https://bugs.debian.org/888495
Forwarded: not-needed
Author: Jean-Michel Vourgère 
Last-Update: 2018-02-14

--- a/check_haproxy_stats/check_haproxy_stats.pl
+++ b/check_haproxy_stats/check_haproxy_stats.pl
@@ -57,7 +57,7 @@
 in list.
 
 -s, --sock, --socket
-Use named UNIX socket instead of default (/var/run/haproxy.sock)
+Use named UNIX socket instead of default (/var/run/haproxy/admin.sock)
 
 -w, --warning
 Set warning threshold for sessions number to the specified percentage (see -c)
@@ -114,7 +114,7 @@
 # Defaults
 my $swarn = 80.0;
 my $scrit = 90.0;
-my $sock  = "/var/run/haproxy.sock";
+my $sock  = "/var/run/haproxy/admin.sock";
 my $dump;
 my $proxy;
 my $help;


signature.asc
Description: This is a digitally signed message part.

Bug#888495: check_haproxy_stats: Please change default location admin sock

[Jean-Michel Vourgère]

Package: nagios-plugins-contrib
Version: 21.20170222
Severity: minor

Dear Maintainer,

Running
/usr/lib/nagios/plugins/check_haproxy_stats
returns:
> Unable to connect to haproxy socket: connect: No such file or directory at 
> /usr/lib/nagios/plugins/check_haproxy_stats line 144.

/usr/lib/nagios/plugins/check_haproxy_stats --help
says:
> -s, --sock, --socket
>   Use named UNIX socket instead of default (/var/run/haproxy.sock)

/usr/lib/nagios/plugins/check_haproxy_stats -s /var/run/haproxy/admin.sock
runs ok.

Please change default socket location to match debian default.
See haproxy (1.5~dev24-2) changelog at
http://metadata.ftp-master.debian.org/changelogs/main/h/haproxy/unstable_changelog
and commit at
https://anonscm.debian.org/cgit/pkg-haproxy/haproxy.git/commit/?id=8b77d5e324bb11466a3e10cd4885234f9cbf8a61

Thank you!

-- System Information:
Debian Release: 9.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), 
LANGUAGE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

nagios-plugins-contrib depends on no packages.

Versions of packages nagios-plugins-contrib recommends:
ii  bind9-host 1:9.10.3.dfsg.P4-12.3+deb9u4
ii  binutils   2.28-5
pn  freeipmi-tools 
ii  libc6  2.24-11+deb9u1
pn  libdata-validate-domain-perl   
pn  libdata-validate-ip-perl   
pn  libdate-manip-perl 
pn  libdbd-mysql-perl  
ii  libio-socket-ssl-perl  2.044-1
ii  libipc-run-perl0.94-1
ii  liblocale-gettext-perl 1.07-3+b1
pn  liblwp-useragent-determined-perl   
pn  libmail-imapclient-perl
pn  libmemcached11 
pn  libmemcachedutil2  
pn  libmonitoring-plugin-perl | libnagios-plugin-  
pn  libnet-cups-perl   
ii  libnet-dns-perl1.07-1
pn  libnet-dns-sec-perl
ii  libnet-smtp-ssl-perl   1.04-1
pn  libnet-smtp-tls-perl   
pn  libnet-smtpauth-perl   
pn  libnet-snmp-perl   
ii  libnet-ssleay-perl 1.80-1
pn  libreadonly-perl   
pn  libredis-perl  
ii  libtimedate-perl   2.3000-2
pn  libvarnishapi1 
pn  libwebinject-perl  
pn  libxml-simple-perl 
pn  libyaml-syck-perl  
ii  lsof   4.89+dfsg-0.1
pn  nagios-plugins-basic   
ii  openssl1.1.0f-3+deb9u1
ii  perl   5.24.1-3+deb9u2
ii  perl-base [libsocket-perl] 5.24.1-3+deb9u2
ii  python 2.7.13-2
pn  python-pymongo 
pn  ruby | ruby-interpreter
pn  snmp   
ii  whois  5.2.17~deb9u1

Versions of packages nagios-plugins-contrib suggests:
pn  backuppc   
pn  cciss-vol-status   
pn  expect 
pn  libsys-virt-perl   
ii  moreutils  0.60-1
pn  mpt-status 
pn  nagios-plugin-check-multi  
pn  percona-toolkit
pn  perl-doc   
ii  python2.7  2.7.13-2+deb9u2
pn  smstools