Bug#888950: brotli: Use dh_missing --fail-missing

2018-02-04 Thread Jeremy Bicha 
On Sat, Feb 3, 2018 at 2:19 AM, Tomasz Buchert  wrote:
> I first bumped the compat level and update the changelog, but then
> thought that maybe you actually really on the version 10.3 of
> debhelper, so I reverted my change ... without reverting the
> changelog.

You can bump the compat level if you want (especially since you
already mentioned it in your changelog).

The only reason I hesitated is because I'll need to lower the compat
to 10 for when I backport brotli to Ubuntu 17.10. (But I'll have to
lower the compat to 9 for 16.04 LTS anyway so not a big deal.)

berto has been doing "sloppy backports" of webkit2gtk to oldstable so
he would need to adjust the debhelper dependency and compat level for
that too.

The brotli backports will be needed by webkit2gtk 2.20 +.

Thanks,
Jeremy Bicha

Bug#888950: brotli: Use dh_missing --fail-missing

2018-02-02 Thread Tomasz Buchert 
On 31/01/18 21:37, Jeremy Bicha wrote:
> On Wed, Jan 31, 2018 at 5:56 PM, Tomasz Buchert  wrote:
> > Both bugs you reported will be fixed in the next upload.
>
> Thanks.
>
> By the way, your debian/changelog says you bumped the debhelper compat
> to 11, but that didn't happen in your git repo.
>
> Jeremy Bicha

Yeah, sorry.

I first bumped the compat level and update the changelog, but then
thought that maybe you actually really on the version 10.3 of
debhelper, so I reverted my change ... without reverting the
changelog.

Tomasz


signature.asc
Description: PGP signature

Bug#888950: brotli: Use dh_missing --fail-missing

2018-01-31 Thread Jeremy Bicha 
On Wed, Jan 31, 2018 at 5:56 PM, Tomasz Buchert  wrote:
> Both bugs you reported will be fixed in the next upload.

Thanks.

By the way, your debian/changelog says you bumped the debhelper compat
to 11, but that didn't happen in your git repo.

Jeremy Bicha

Bug#888950: brotli: Use dh_missing --fail-missing

2018-01-31 Thread Tomasz Buchert 
On 31/01/18 09:30, Jeremy Bicha wrote:
>  [...]

Thanks Jeremy!
Both bugs you reported will be fixed in the next upload.

Cheers,
Tomasz


signature.asc
Description: PGP signature

Bug#888950: brotli: Use dh_missing --fail-missing

2018-01-31 Thread Jeremy Bicha 

From 0c7c14cb850530f3f7424f4f1fd2442a10577403 Mon Sep 17 00:00:00 2001
From: Jeremy Bicha 
Date: Wed, 31 Jan 2018 08:38:33 -0500
Subject: [PATCH] Use dh_missing --fail-missing

Closes: #888950
---
 debian/control | 2 +-
 debian/rules   | 7 +++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 154fda9..5198d3c 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,7 @@ Priority: optional
 Maintainer: Tomasz Buchert 
 Uploaders: Ondřej Surý 
 Build-Depends: cmake,
-   debhelper (>= 10),
+   debhelper (>= 10.3),
dh-python,
python,
python-dev,
diff --git a/debian/rules b/debian/rules
index 8af3950..bc20677 100755
--- a/debian/rules
+++ b/debian/rules
@@ -28,3 +28,10 @@ override_dh_auto_clean:
 override_dh_auto_test:
 	dh_auto_test
 	dh_auto_test --buildsystem=cmake
+
+override_dh_install:
+	find debian/tmp -name '*.a' -print -delete
+	dh_install
+
+override_dh_missing:
+	dh_missing --fail-missing
-- 
2.15.1

Bug#888950: brotli: Use dh_missing --fail-missing

2018-01-31 Thread Jeremy Bicha 
Source: brotli
Version: 1.0.2-2
Tags: patch

I am attaching a patch in my next email to use dh_missing
--fail-missing. It's useful for packages that ship multiple binary
packages to make sure nothing is accidentally missing when packaging
new versions.

This issue was discovered by Didier Roche during Ubuntu "main" review
https://launchpad.net/bugs/1737053

Thanks,
Jeremy Bicha