Package: libglibmm-2.4-dev
Version: 2.54.1-3
Severity: normal

There is a typo in the glibmm/threads.h header file, a missing & in the
GPrivate::gobj() method.

It has so far not caused that many issues, but if gcc-8 is used for
compiling the typo starts generating FTBFS errors for software
including the header, also if the GPrivate::gobj() is not used.

The bug is fixed upstream in the 2.54 branch:

https://github.com/GNOME/glibmm/commit/37d57ae

Patch attached (this is the patch used in Fedora).

        Mattias
From 37d57ae9572b7d74aa385a30313eceae7f2d3fce Mon Sep 17 00:00:00 2001
From: Kjell Ahlstedt <kjellahlst...@gmail.com>
Date: Wed, 20 Dec 2017 20:00:32 +0100
Subject: [PATCH] Glib::Threads::Private: Fix gobj()

Bug 791711
---
 glib/src/threads.hg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/glib/src/threads.hg b/glib/src/threads.hg
index 86d7a17b62f4..c82a6130bbeb 100644
--- a/glib/src/threads.hg
+++ b/glib/src/threads.hg
@@ -628,7 +628,7 @@ public:
    */
   inline void replace(T* data);
 
-  GPrivate* gobj() { return gobject_; }
+  GPrivate* gobj() { return &gobject_; }
 
 private:
   GPrivate gobject_;
-- 
2.14.3

diff -urN glibmm-2.54.1-old/glib/glibmm/threads.h glibmm-2.54.1/glib/glibmm/threads.h
--- glibmm-2.54.1-old/glib/glibmm/threads.h	2018-02-02 16:44:05.000000000 +0100
+++ glibmm-2.54.1/glib/glibmm/threads.h	2018-02-02 16:47:04.000000000 +0100
@@ -657,7 +657,7 @@
    */
   inline void replace(T* data);
 
-  GPrivate* gobj() { return gobject_; }
+  GPrivate* gobj() { return &gobject_; }
 
 private:
   GPrivate gobject_;

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to