Bug#890290: rmysql: Please build-depend on default-libmysqlclient-dev, not libmariadb-dev

[Dirk Eddelbuettel]

On 12 February 2018 at 17:53, Steve Langasek wrote:
| > Coincidentally, doesn't Ubuntu also default to MariaDB?  Who doesn't,
| > these days?
| 
| No, Ubuntu defaults to MySQL.

I mostly deploy on Ubuntu too (eg at work) and had issues with MySQL. I tend
to just build R package of the CRAN repo though.

Luckily, the code takes either one ...

Dirk

-- 
http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org

Bug#890290: rmysql: Please build-depend on default-libmysqlclient-dev, not libmariadb-dev

[Steve Langasek]

On Mon, Feb 12, 2018 at 07:37:47PM -0600, Dirk Eddelbuettel wrote:

> On 12 February 2018 at 16:22, Steve Langasek wrote:
> | Package: rmysql
> | Version: 0.10.13-1
> | Severity: wishlist
> | Tags: patch
> | User: ubuntu-de...@lists.ubuntu.com
> | Usertags: origin-ubuntu bionic ubuntu-patch

> | Hi Dirk,

> | As discussed at
> | ,
> | packages in Debian should build-depend on default-libmysqlclient-dev, not
> | directly on either libmariadb-dev or libmysqlclient-dev.  Part of the
> | reasoning for this is to allow downstreams to make different decisions about
> | their "supported" implementations of MySQL.

> | The attached patch which implements this also fixes a build failure of
> | rmysql in Ubuntu, which appears to be an incompatibility between rmysql and
> | mariadb-connector-c version 3.0.3.  Since mariadb *is* the default mysql in
> | Debian, this won't help for any build failure there, but nevertheless
> | appears to be a correct change.

> Done!

> Coincidentally, doesn't Ubuntu also default to MariaDB?  Who doesn't,
> these days?

No, Ubuntu defaults to MySQL.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: PGP signature

Bug#890290: rmysql: Please build-depend on default-libmysqlclient-dev, not libmariadb-dev

[Dirk Eddelbuettel]

On 12 February 2018 at 16:22, Steve Langasek wrote:
| Package: rmysql
| Version: 0.10.13-1
| Severity: wishlist
| Tags: patch
| User: ubuntu-de...@lists.ubuntu.com
| Usertags: origin-ubuntu bionic ubuntu-patch
| 
| Hi Dirk,
| 
| As discussed at
| ,
| packages in Debian should build-depend on default-libmysqlclient-dev, not
| directly on either libmariadb-dev or libmysqlclient-dev.  Part of the
| reasoning for this is to allow downstreams to make different decisions about
| their "supported" implementations of MySQL.
| 
| The attached patch which implements this also fixes a build failure of
| rmysql in Ubuntu, which appears to be an incompatibility between rmysql and
| mariadb-connector-c version 3.0.3.  Since mariadb *is* the default mysql in
| Debian, this won't help for any build failure there, but nevertheless
| appears to be a correct change.

Done!

Coincidentally, doesn't Ubuntu also default to MariaDB?  Who doesn't, these 
days?

Cheers, Dirk

-- 
http://dirk.eddelbuettel.com | @eddelbuettel | e...@debian.org

Bug#890290: rmysql: Please build-depend on default-libmysqlclient-dev, not libmariadb-dev

[Steve Langasek]

Package: rmysql
Version: 0.10.13-1
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch

Hi Dirk,

As discussed at
,
packages in Debian should build-depend on default-libmysqlclient-dev, not
directly on either libmariadb-dev or libmysqlclient-dev.  Part of the
reasoning for this is to allow downstreams to make different decisions about
their "supported" implementations of MySQL.

The attached patch which implements this also fixes a build failure of
rmysql in Ubuntu, which appears to be an incompatibility between rmysql and
mariadb-connector-c version 3.0.3.  Since mariadb *is* the default mysql in
Debian, this won't help for any build failure there, but nevertheless
appears to be a correct change.

Thanks,
-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -u rmysql-0.10.13/debian/control rmysql-0.10.13/debian/control
--- rmysql-0.10.13/debian/control
+++ rmysql-0.10.13/debian/control
@@ -2,8 +2,8 @@
 Section: gnu-r
 Priority: optional
 Maintainer: Dirk Eddelbuettel 
-Build-Depends: debhelper (>= 7.0.0), cdbs, r-base-dev (>= 3.4.1), 
libmariadb-dev, r-cran-dbi (>= 0.4), r-cran-viridislite
+Build-Depends: debhelper (>= 7.0.0), cdbs, r-base-dev (>= 3.4.1), 
default-libmysqlclient-dev, r-cran-dbi (>= 0.4), r-cran-viridislite
 Standards-Version: 4.0.0
 Homepage: https://github.com/rstats-db/RMySQL