Bug#891773: Related bug #871229 (but it didn't break my system))

On vrijdag 2 maart 2018 09:49:39 CET John Paul Adrian Glaubitz wrote: > Here's an updated patch sparc64-support.patch which should address the > issue, > it contains these two patches: > > http://lists.gnu.org/archive/html/grub-devel/2018-03/msg00016.html > >

Bug#891773: Related bug #871229 (but it didn't break my system))

On 03/02/2018 02:58 PM, Diederik de Haas wrote: Still works without segfaults. Any particular info you'd like to see as well? No. But you should re-test version -3 that was just uploaded once it becomes available. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer -

Bug#891773: Related bug #871229 (but it didn't break my system))

Hi! Here's an updated patch sparc64-support.patch which should address the issue, it contains these two patches: > http://lists.gnu.org/archive/html/grub-devel/2018-03/msg00016.html > http://lists.gnu.org/archive/html/grub-devel/2018-03/msg00018.html @Martin and Diederik, could you test these

Bug#891773: Related bug #871229 (but it didn't break my system))

On 03/01/2018 05:15 PM, Diederik de Haas wrote: No more segfaults :-) Alright. Attaching an updated patch for sparc64 support for Colin. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de

Bug#891773: Related bug #871229 (but it didn't break my system))

On donderdag 1 maart 2018 17:02:28 CET John Paul Adrian Glaubitz wrote: > I have updated the packages with the patch I just came up with: > > https://people.debian.org/~glaubitz/grub-891773/ > > Can you retry? No more segfaults :-) signature.asc Description: This is a digitally signed message

Bug#891773: Related bug #871229 (but it didn't break my system))

On 03/01/2018 03:22 PM, Diederik de Haas wrote: So it didn't seem to have fixed the issue, but maybe some additional info. If you need other info or want me to run other (debugging) commands, let me know. Preferably with detailed instructions as I just learned today how to do the 'bt' command.

Bug#891773: Related bug #871229 (but it didn't break my system))

On 03/01/2018 04:06 PM, John Paul Adrian Glaubitz wrote: Let me test a patch. The problem is that of_path is empty here and the strcat tries to append "disk" to an empty buffer which fails. This fixes it for me: diff --git a/grub-core/osdep/linux/ofpath.c b/grub-core/osdep/linux/ofpath.c

Bug#891773: Related bug #871229 (but it didn't break my system))

Looking at the code in grub-core/osdep/linux/ofpath.c, the issue is most likely that the buffer that of_path is pointing to of_path_of_nvme() is not large enough to hold both the contents of *of_path and disk[MAX_DISK_CAT]. Let me test a patch. Adrian -- .''`. John Paul Adrian Glaubitz : :'

Bug#891773: Related bug #871229 (but it didn't break my system))

On 03/01/2018 03:30 PM, John Paul Adrian Glaubitz wrote: On 03/01/2018 03:22 PM, Diederik de Haas wrote: #2  of_path_of_nvme (sys_devname=0x55973f55efd0 "/dev/nvme0n1", devnode=0x55973f55d950 "/dev/nvme0n", devicenode=0x55973f55df10 "nvme0n", device=) at

Bug#891773: Related bug #871229 (but it didn't break my system))

Adding GRUB upstream. On 03/01/2018 03:22 PM, Diederik de Haas wrote: #2 of_path_of_nvme (sys_devname=0x55973f55efd0 "/dev/nvme0n1", devnode=0x55973f55d950 "/dev/nvme0n", devicenode=0x55973f55df10 "nvme0n", device=) at ../../grub-core/osdep/linux/ofpath.c:388 It crashes in

Bug#891773: Related bug #871229 (but it didn't break my system))

On donderdag 1 maart 2018 15:14:40 CET John Paul Adrian Glaubitz wrote: > >> If you have a .deb package, then yes. > > > > I just uploaded a patched version of grub2 to my Debian webspace [1]. > > PS: grub-probe is located in the grub-common package, so it should hopefully > be enough to just

Bug#891773: Related bug #871229 (but it didn't break my system))

On 03/01/2018 03:10 PM, John Paul Adrian Glaubitz wrote: If you have a .deb package, then yes. I just uploaded a patched version of grub2 to my Debian webspace [1]. PS: grub-probe is located in the grub-common package, so it should hopefully be enough to just install

Bug#891773: Related bug #871229 (but it didn't break my system))

On 03/01/2018 03:07 PM, Diederik de Haas wrote: On donderdag 1 maart 2018 14:25:25 CET John Paul Adrian Glaubitz wrote: It might be that this patch fixes it [1]. I can build a grub package with the patch and provide it for testing purpose. Anyone who is affected by the bug would be willing to

Bug#891773: Related bug #871229 (but it didn't break my system))

On donderdag 1 maart 2018 14:25:25 CET John Paul Adrian Glaubitz wrote: > It might be that this patch fixes it [1]. I can build a grub package > with the patch and provide it for testing purpose. Anyone who is > affected by the bug would be willing to test my packages? If you have a .deb package,

Bug#891773: Related bug #871229 (but it didn't break my system))

CC'ing Eric Snowberg who authored the patches. On 03/01/2018 02:18 PM, Colin Watson wrote: Thanks for the backtrace; that's very helpful. This is a regression introduced by the sparc64 support patches introduced in #854568, and the latest patch there won't help. Adrian, could you please look

Bug#871229: Bug#891773: Related bug #871229 (but it didn't break my system))

Control: severity 871229 important Control: tag 871229 moreinfo Control: severity 891773 grave On Thu, Mar 01, 2018 at 12:37:33PM +0100, Diederik de Haas wrote: > Backtrace: > > # gdb /usr/sbin/grub-probe core > GNU gdb (Debian 7.12-6+b1) 7.12.0.20161007-git > Copyright (C) 2016 Free Software

Bug#871229: Bug#891773: Related bug #871229 (but it didn't break my system))

Backtrace: # gdb /usr/sbin/grub-probe core GNU gdb (Debian 7.12-6+b1) 7.12.0.20161007-git Copyright (C) 2016 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO

Bug#891773: Related bug #871229 (but it didn't break my system)

Checked pkg-grub-devel and found related bug #871229. Normally I'd merge the bugs, but this bug didn't break my system. I have rebooted my PC and the boot process *may* have taken a bit longer, I'm not sure. But the boot was successful. Also I just updated my Sid system, no major things like in