Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Graham Inggs]

Control: tags -1 + fixed-upstream

This was fixed upstream for arm64 and m68k in r38866 [1], and fixed for 
m68k in salsa [2] now.



[1] 
https://svn.freepascal.org/cgi-bin/viewvc.cgi/trunk/utils/fpcm/fpcmmain.pp?r1=38866=38865=38866
[2] 
https://salsa.debian.org/pascal-team/fpc/commit/7327829338a931bbb77a630a12abcae7d6bc57e7

Bug#892285: [Pkg-pascal-devel] Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Graham Inggs]

Control: reopen -1
Control: tags -1 + patch


Hi Abou

This needs to be fixed for arm64 as well.

FPC names the compiler ppca64, but fpcmake looks for ppcaarch64.
Please see the attached diff against add-arm64-support.patch.

Regards
Graham
--- a/debian/patches/add-arm64-support.patch
+++ b/debian/patches/add-arm64-support.patch
@@ -36817,7 +36817,7 @@
  
ppcSuffix : array[TCpu] of string=(
 -'386','m68k','ppc','sparc','x86_64','arm','ppc64','avr','armeb', 'armel', 'mips', 'mipsel', 'mips64', 'mips64el', 'jvm','8086'
-+'386','m68k','ppc','sparc','x64','arm','ppc64','avr','armeb', 'armel', 'mips', 'mipsel', 'mips64', 'mips64el', 'jvm','8086','aarch64'
++'386','m68k','ppc','sparc','x64','arm','ppc64','avr','armeb', 'armel', 'mips', 'mipsel', 'mips64', 'mips64el', 'jvm','8086','a64'
);
  
OSStr : array[TOS] of string=(

Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Abou Al Montacir]

On Sat, 14 Apr 2018 16:54:23 +0200 Abou Al Montacir 
wrote:
> Control: forwarded -1 https://bugs.freepascal.org/view.php?id=33606
> 
> I've created https://bugs.freepascal.org/view.php?id=33606 to track the
compiler
> name in fpcmake.Upstream accepted the proposed bug and the upstream bug is now
closed.We don't need to worry about this patch as it will need to be abandoned
for next release.
-- 
Cheers,
Abou Al Montacir


signature.asc
Description: This is a digitally signed message part

Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Abou Al Montacir]

Control: forwarded -1 https://bugs.freepascal.org/view.php?id=33606

I've created https://bugs.freepascal.org/view.php?id=33606 to track the compiler
name in fpcmake.
-- 
Cheers,
Abou Al Montacir

signature.asc
Description: This is a digitally signed message part

Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Abou Al Montacir]

Hi All,
On Thu, 2018-03-08 at 09:34 +0100, Abou Al Montacir wrote:
> Hi Paul,
> 
> On Thu, 2018-03-08 at 08:44 +0100, Paul Gevers wrote:
> > > Probably none of them need to define FPCDIR.
> > Currently Lazarus FTBFS without it.¹
> I'll have a look at it and try to fix it this WE.
I could finally find time for this issue. There was an issue with fpcmake
looking for fpc executable using a wrong name on amd64 architecture.FPC
executable is ppcx64 while fpcmake was looking for ppcx86_64. I had a commit
fixing this issue: cff270e15f4d9342ea6918a4b69d038df5184af2
However this commit revealed another bug: currently we are shipping
Makefiles.fpc in fpc-source package, which install to /usr/share/fpc-
source/${FPCVER}.However fpcmake seems too look for them at units directories.
This seems more logical and make me remeber the lpk files  for Lazarus.Also by
shipping Makefile.fpc with binaries we get rid of the constraint of depending on
fpc-source to be able to build any fpc programe using fpcmake.
To be discussed more.
-- Cheers,
Abou Al Montacir

signature.asc
Description: This is a digitally signed message part

Bug#892285: [Pkg-pascal-devel] Bug#892285: Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Graham Inggs]

Control: block 887967 by 892285


On 07/03/2018 23:57, Abou Al Montacir wrote:

Probably none of them need to define FPCDIR.


transgui also FTBFS if FPCDIR is not defined.

On 08/03/2018 10:34, Abou Al Montacir wrote:
> I'll have a look at it and try to fix it this WE.

Great, thanks!

Bug#892285: [Pkg-pascal-devel] Bug#892285: Bug#892285: Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Abou Al Montacir]

Hi Paul,

On Thu, 2018-03-08 at 08:44 +0100, Paul Gevers wrote:
> > Probably none of them need to define FPCDIR.
> Currently Lazarus FTBFS without it.¹
> 
I'll have a look at it and try to fix it this WE. 
-- 
Cheers,
Abou Al Montacir

signature.asc
Description: This is a digitally signed message part

Bug#892285: [Pkg-pascal-devel] Bug#892285: Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Paul Gevers]

Hi Abou,

On 07-03-18 22:57, Abou Al Montacir wrote:
> On Wed, 2018-03-07 at 21:29 +0100, Paul Gevers wrote:
>> Lazarus is defining FPCDIR in its d/rules file to prevent this like:
>> FPCDIR=/usr/share/fpcsrc/${FPCVER}
>>
>> Transgui is/was doing it like:
>> FPCDIR=/usr/lib/fpc/${FPCDIR}
>>
>> I believe neither should be needed. Also, which one of the two is correct (or
>> better, if neither is really correct)?
> Probably none of them need to define FPCDIR.

Currently Lazarus FTBFS without it.¹

Paul

¹
http://debomatic-amd64.debian.net/distribution#unstable/lazarus/1.8.2+dfsg-4/buildlog



signature.asc
Description: OpenPGP digital signature

Bug#892285: [Pkg-pascal-devel] Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Abou Al Montacir]

Hi,

On Wed, 2018-03-07 at 21:29 +0100, Paul Gevers wrote:
> Lazarus is defining FPCDIR in its d/rules file to prevent this
> like:FPCDIR=/usr/share/fpcsrc/${FPCVER}
> 
> Transgui is/was doing it like:
> FPCDIR=/usr/lib/fpc/${FPCDIR}
> 
> I believe neither should be needed. Also, which one of the two is correct (or
> better, if neither is really correct)?
Probably none of them need to define FPCDIR.
-- 
Cheers,
Abou Al Montacir

signature.asc
Description: This is a digitally signed message part

Bug#892285: /usr/bin/fpcmake: fpcmake should find units in Debian without fiddling with FPCDIR

[Paul Gevers]

Package: fp-utils-3.0.4
Version: 3.0.4+dfsg-15
Severity: normal
File: /usr/bin/fpcmake

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

fpcmake doesn't work out of the box in Debian (maybe since the multiarch
changes, but I am not sure about that). E.g. in the Lazarus source tree I get 
this:
paul@testavoira ~/lazarus $ fpcmake -r -v
FPCMake Version 2.0.0 [2017-02-13 rev 35434]
Processing Makefile.fpc
 Targets: "x86_64-linux"
 Globals:
FPCDIR = ""
PACKAGESDIR = "$(FPCDIR)/packages $(FPCDIR)/packages/base 
$(FPCDIR)/packages/extra $(FPCDIR)/packages"
UNITSDIR = "$(FPCDIR)/units/$(FULLTARGET)"
BASEDIR = "/home/paul/packages/freepascal/lazarus"
 Required packages for linux-x86_64: rtl regexpr
 Package "rtl": Looking for Makefile.fpc: " /packages/rtl/Makefile.fpc 
/packages/base/rtl/Makefile.fpc /packages/extra/rtl/Makefile.fpc 
/packages/rtl/Makefile.fpc "
 Package "rtl": Looking for Package.fpc: " /units/x86_64-linux/rtl/Package.fpc "
Error: Target "linux", package "rtl" not found

Lazarus is defining FPCDIR in its d/rules file to prevent this like:
FPCDIR=/usr/share/fpcsrc/${FPCVER}

Transgui is/was doing it like:
FPCDIR=/usr/lib/fpc/${FPCDIR}

I believe neither should be needed. Also, which one of the two is correct (or
better, if neither is really correct)?

Paul

- -- System Information:
Debian Release: buster/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (200, 'testing'), (50, 
'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.14.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages fp-utils-3.0.4 depends on:
ii  fpc-source-3.0.4  3.0.4+dfsg-15
ii  libc6 2.26-6

Versions of packages fp-utils-3.0.4 recommends:
ii  fp-compiler-3.0.4  3.0.4+dfsg-15

fp-utils-3.0.4 suggests no packages.

- -- no debconf information

-BEGIN PGP SIGNATURE-

iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAlqgS6YACgkQnFyZ6wW9
dQpVjAf/WKH9mpTybtk9CC29DdxupoZ0yvpsA3fnGcbPC9cNLUGm5CqG7EtC2jY1
25mKsm+QzZXMu/gbexZfnqFK4mhEGCWfoXSK47QUsEspu+c3cuao97ySE75iIXJY
OSHtNUB9uHeN0jjbVXAE7fI2IEiTKYBwlSxXvhTC65tYikjcdqgdbFNa1jsYdjA3
Z/tNM2iI7SsSmubLvQiCQq/ZP3fYkAA9vydE+dw1/uIUh3/z7gIzVlpT2nd2uXpb
iidAMmLsMQ0gyZ079u8Yt+X2eNrAb3sre3mGjyRfjYkprqoWrbICHJZ8eN5Tc001
SjAE1D68CBzuvFAtyErMudwg06AWGg==
=4I4S
-END PGP SIGNATURE-