Bug#892656: even more tests fail with version 2.0.2

[Paul Gevers]

Hi Paolo,

On 14-01-2019 08:24, Paolo Greppi wrote:
> Hi Paul, seems like npm registry now has is-descriptor 3.0.0:
> https://www.npmjs.com/package/is-descriptor
> 
> but even define-property 2.0.2 still wants is-descriptor 1.0.2:
> https://github.com/jonschlinkert/define-property/blob/master/package.json#L27
> 
> Now that we consider acceptable to embed tiny node modules (and is-descriptor 
> certainly is tiny) we have two options:
> 1. (old #3) downgrade node-is-descriptor to 1.0.2
> 2. remove node-is-descriptor 2.0.0 and embed is-descriptor 1.0.2 into 
> node-define-property

I hope you can make the call yourself as I am a mere bystander. But I do
want to get rid of RC bugs as they are delaying the release.

Paul



signature.asc
Description: OpenPGP digital signature

Bug#892656: even more tests fail with version 2.0.2

[Paolo Greppi]

Il 13/01/19 16:52, Paul Gevers ha scritto:
> user debian-rele...@lists.debian.org
> usertags 884543 bsp-2019-01-nl-venlo
> thanks
> 
> On Mon, 23 Apr 2018 14:36:00 +0200 Paolo Greppi 
> wrote:
>> So I'd propose we go straight for option #3 (downgrade node-is-descriptor to 
>> 1.0).
>> Can you do that please ?
> 
> Is this what needs to happen? Should this be packaged:
> https://github.com/jonschlinkert/is-descriptor/archive/1.0.2.tar.gz ?
> 
> Paul
> Sent from the BSP in Venlo

Hi Paul, seems like npm registry now has is-descriptor 3.0.0:
https://www.npmjs.com/package/is-descriptor

but even define-property 2.0.2 still wants is-descriptor 1.0.2:
https://github.com/jonschlinkert/define-property/blob/master/package.json#L27

Now that we consider acceptable to embed tiny node modules (and is-descriptor 
certainly is tiny) we have two options:
1. (old #3) downgrade node-is-descriptor to 1.0.2
2. remove node-is-descriptor 2.0.0 and embed is-descriptor 1.0.2 into 
node-define-property

Paolo

Bug#892656: even more tests fail with version 2.0.2

[Paul Gevers]

user debian-rele...@lists.debian.org
usertags 884543 bsp-2019-01-nl-venlo
thanks

On Mon, 23 Apr 2018 14:36:00 +0200 Paolo Greppi 
wrote:
> So I'd propose we go straight for option #3 (downgrade node-is-descriptor to 
> 1.0).
> Can you do that please ?

Is this what needs to happen? Should this be packaged:
https://github.com/jonschlinkert/is-descriptor/archive/1.0.2.tar.gz ?

Paul
Sent from the BSP in Venlo



signature.asc
Description: OpenPGP digital signature

Bug#892656: even more tests fail with version 2.0.2

[Paolo Greppi]

Il 12/04/2018 06:19, Pirate Praveen ha scritto:
> 
> 
> On April 12, 2018 2:48:32 AM GMT+05:30, Paolo Greppi  
> wrote:
>> Normally you'd expect to fix bugs with a new version, in this case
>> while trying to update node-define-property 1.0.0-1 -> 2.0.2 the
>> failing tests actually increased from 1 to 4.
>>
>> What puzzled me was that no tests fail on upstream's CI (travis), which
>> also tests nodejs version 8.
>>
>> Turns out that we have upgraded node-is-descriptor to version 2.0.0,
>> but the npm registry only has 1.0.2.
>>
>> I have forwarded the issue upstream, and I expect upstream to answer
>> that define-property correctly pins the major version of is-descriptor
>> with ^1.0.2 (https://docs.npmjs.com/misc/semver), stating that it won't
>> work with 2.x.
>>
>> ^1.0.2 should be translated with >= 1.0.2 && < 2.0.0 but we can't
>> encode that in debian/control.
>>
>> So how can we check reverse dependencies for this type of issues in the
>> future ?
>>
>> Paolo
> 
> build-and-upload script from ruby-team/meta can help if we have enabled 
> tests. If we used that, then is-descriptor 1.0 -> 2.0 update would notify the 
> failure before upload. But its likely we added is-descriptor 2.0 directly.
> 
> The best choice is upstream updating their dependency. Second choice is we 
> update and send merge request.
> 
> As a worse case, we can downgrade node-is-descriptor to 1.0 if we have no 
> other reverse dependency or embed 1.0 in node-define-property.
> 

Upstream closed the issue I reported:
https://github.com/jonschlinkert/define-property/issues/3
so that rules out option #1.

I have checked and in Debian we have no other dependent than 
node-define-property:

apt-cache rdepends node-is-descriptor
node-is-descriptor
Reverse Depends:
  node-define-property

whereas on npm registry there are 5 dependents listed:
- react-native-handcheque-engine
- dk_2018_1_1
- @ngxvoice/ngx-voicelistner
- define-property
- vue-size-tracker
none of which has ITP/RFP.

So I'd propose we go straight for option #3 (downgrade node-is-descriptor to 
1.0).
Can you do that please ?

Paolo

Bug#892656: even more tests fail with version 2.0.2

[Pirate Praveen]

On April 12, 2018 2:48:32 AM GMT+05:30, Paolo Greppi  
wrote:
>Normally you'd expect to fix bugs with a new version, in this case
>while trying to update node-define-property 1.0.0-1 -> 2.0.2 the
>failing tests actually increased from 1 to 4.
>
>What puzzled me was that no tests fail on upstream's CI (travis), which
>also tests nodejs version 8.
>
>Turns out that we have upgraded node-is-descriptor to version 2.0.0,
>but the npm registry only has 1.0.2.
>
>I have forwarded the issue upstream, and I expect upstream to answer
>that define-property correctly pins the major version of is-descriptor
>with ^1.0.2 (https://docs.npmjs.com/misc/semver), stating that it won't
>work with 2.x.
>
>^1.0.2 should be translated with >= 1.0.2 && < 2.0.0 but we can't
>encode that in debian/control.
>
>So how can we check reverse dependencies for this type of issues in the
>future ?
>
>Paolo

build-and-upload script from ruby-team/meta can help if we have enabled tests. 
If we used that, then is-descriptor 1.0 -> 2.0 update would notify the failure 
before upload. But its likely we added is-descriptor 2.0 directly.

The best choice is upstream updating their dependency. Second choice is we 
update and send merge request.

As a worse case, we can downgrade node-is-descriptor to 1.0 if we have no other 
reverse dependency or embed 1.0 in node-define-property.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Bug#892656: even more tests fail with version 2.0.2

[Paolo Greppi]

Normally you'd expect to fix bugs with a new version, in this case while trying 
to update node-define-property 1.0.0-1 -> 2.0.2 the failing tests actually 
increased from 1 to 4.

What puzzled me was that no tests fail on upstream's CI (travis), which also 
tests nodejs version 8.

Turns out that we have upgraded node-is-descriptor to version 2.0.0, but the 
npm registry only has 1.0.2.

I have forwarded the issue upstream, and I expect upstream to answer that 
define-property correctly pins the major version of is-descriptor with ^1.0.2 
(https://docs.npmjs.com/misc/semver), stating that it won't work with 2.x.

^1.0.2 should be translated with >= 1.0.2 && < 2.0.0 but we can't encode that 
in debian/control.

So how can we check reverse dependencies for this type of issues in the future ?

Paolo