Bug#893866: stretch-pu: package systemd/232-25+deb9u3

[Adam D. Barratt]

Control: tags -1 + pending

On Tue, 2018-03-27 at 00:35 +0200, Michael Biebl wrote:
> Am 26.03.2018 um 18:54 schrieb Adam D. Barratt:
> > Control: tags -1 + confirmed
> > 
> > On Fri, 2018-03-23 at 14:15 +0100, Michael Biebl wrote:
> > > The last stable upload of systemd introduced a rather nasty
> > > regression
> > > in networkd, which broke IPv6 support for lots of users.
> > > 
> > > KiBi was so kind to dig out the relevant upstream commit which
> > > fixes
> > > this and got confirmation from the bug reporter(s) that with this
> > > patch applied, networkd behaves properly.
> > 
> > Please go ahead.
> 
> Uploaded

Flagged for acceptance into p-u.

> > > I thus would like to get this
> > > update into stable as quickly as possible.
> > 
> > As per the earlier IRC discussion, I assume you mean "into stable-
> > updates" here (or "available to users of stable"), which we'll
> > endeavour to get sorted. The update can't actually make it in to
> > stable
> > any sooner than the next point release, as that's the only time
> > that
> > stable changes.
> 
> I did indeed mean "available to users of stable". Sorry for not using
> the proper nomenclature.
> 

No worries, just making sure we were on the same page; sorry if I was
overly grumpy.

Regards,

Adam

Bug#893866: stretch-pu: package systemd/232-25+deb9u3

[Michael Biebl]

Am 26.03.2018 um 18:54 schrieb Adam D. Barratt:
> Control: tags -1 + confirmed
> 
> On Fri, 2018-03-23 at 14:15 +0100, Michael Biebl wrote:
>> The last stable upload of systemd introduced a rather nasty
>> regression
>> in networkd, which broke IPv6 support for lots of users.
>>
>> KiBi was so kind to dig out the relevant upstream commit which fixes
>> this and got confirmation from the bug reporter(s) that with this
>> patch applied, networkd behaves properly.
> 
> Please go ahead.

Uploaded

>> I thus would like to get this
>> update into stable as quickly as possible.
> 
> As per the earlier IRC discussion, I assume you mean "into stable-
> updates" here (or "available to users of stable"), which we'll
> endeavour to get sorted. The update can't actually make it in to stable
> any sooner than the next point release, as that's the only time that
> stable changes.

I did indeed mean "available to users of stable". Sorry for not using
the proper nomenclature.

Regards,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#893866: stretch-pu: package systemd/232-25+deb9u3

[Adam D. Barratt]

Control: tags -1 + confirmed

On Fri, 2018-03-23 at 14:15 +0100, Michael Biebl wrote:
> The last stable upload of systemd introduced a rather nasty
> regression
> in networkd, which broke IPv6 support for lots of users.
> 
> KiBi was so kind to dig out the relevant upstream commit which fixes
> this and got confirmation from the bug reporter(s) that with this
> patch applied, networkd behaves properly.

Please go ahead.

> I thus would like to get this
> update into stable as quickly as possible.

As per the earlier IRC discussion, I assume you mean "into stable-
updates" here (or "available to users of stable"), which we'll
endeavour to get sorted. The update can't actually make it in to stable
any sooner than the next point release, as that's the only time that
stable changes.

Regards,

Adam

Bug#893866: stretch-pu: package systemd/232-25+deb9u3

[Michael Biebl]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Hi,

we already briefly discussed this via IRC on #debian-release.

The last stable upload of systemd introduced a rather nasty regression
in networkd, which broke IPv6 support for lots of users.

KiBi was so kind to dig out the relevant upstream commit which fixes
this and got confirmation from the bug reporter(s) that with this patch
applied, networkd behaves properly. I thus would like to get this
update into stable as quickly as possible.

Here's the changelog, debdiff is attached:

systemd (232-25+deb9u3) stretch; urgency=medium

  [ Cyril Brulebois ]
  * networkd-ndisc: Handle missing mtu gracefully.
The previous upload made networkd respect the MTU field in IPv6 RA but
unfortunately broke setups where there's no such field. (Closes: #892794)

 -- Michael Biebl   Fri, 23 Mar 2018 13:55:43 +0100


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), 
LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff --git a/debian/changelog b/debian/changelog
index e7b7ff1..1117655 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+systemd (232-25+deb9u3) stretch; urgency=medium
+
+  [ Cyril Brulebois ]
+  * networkd-ndisc: Handle missing mtu gracefully.
+The previous upload made networkd respect the MTU field in IPv6 RA but
+unfortunately broke setups where there's no such field. (Closes: #892794)
+
+ -- Michael Biebl   Fri, 23 Mar 2018 13:55:43 +0100
+
 systemd (232-25+deb9u2) stretch; urgency=medium
 
   * networkd: Handle MTU field in IPv6 RA (Closes: #878162)
diff --git 
a/debian/patches/networkd-ndisc-handle-missing-mtu-gracefully-4913.patch 
b/debian/patches/networkd-ndisc-handle-missing-mtu-gracefully-4913.patch
new file mode 100644
index 000..59d6808
--- /dev/null
+++ b/debian/patches/networkd-ndisc-handle-missing-mtu-gracefully-4913.patch
@@ -0,0 +1,28 @@
+From: =?utf-8?q?J=C3=B6rg_Thalheim?= 
+Date: Mon, 19 Dec 2016 15:34:07 +0100
+Subject: networkd-ndisc: handle missing mtu gracefully (#4913)
+
+At least bird's implementation of router advertisement does not
+set MTU option by default (instead it supplies an option to the user).
+In this case just leave MTU as it is.
+
+(cherry picked from commit 29b5ad083a6925efec8e188013d1298742e0baaa)
+---
+ src/network/networkd-ndisc.c | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/src/network/networkd-ndisc.c b/src/network/networkd-ndisc.c
+index 9cfdf01..d3fa56b 100644
+--- a/src/network/networkd-ndisc.c
 b/src/network/networkd-ndisc.c
+@@ -117,7 +117,9 @@ static void ndisc_router_process_default(Link *link, 
sd_ndisc_router *rt) {
+ }
+ 
+ r = sd_ndisc_router_get_mtu(rt, );
+-if (r < 0) {
++if (r == -ENODATA)
++mtu = 0;
++else if (r < 0) {
+ log_link_warning_errno(link, r, "Failed to get default router 
MTU from RA: %m");
+ return;
+ }
diff --git a/debian/patches/series b/debian/patches/series
index 3f93454..2866963 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -78,6 +78,7 @@ networkd-handle-MTU-field-in-IPv6-RA-4719.patch
 shared-Add-a-linker-script-so-that-all-functions-are-tagg.patch
 resolved-fix-loop-on-packets-with-pseudo-dns-types.patch
 machinectl-don-t-output-No-machines.-with-no-legend-optio.patch
+networkd-ndisc-handle-missing-mtu-gracefully-4913.patch
 debian/Use-Debian-specific-config-files.patch
 debian/don-t-try-to-start-autovt-units-when-not-running-wit.patch
 debian/Make-logind-hostnamed-localed-timedated-D-Bus-activa.patch