Bug#893967: [php-maint] Bug#893967: php-defaults: Drop distribution name from package descriptions

[Jeremy Bicha]

On Mon, Mar 26, 2018 at 6:18 AM, Ondřej Surý  wrote:
> the d/control is generated from d/control.in and the contents are crafted 
> based on number of supported PHP version, as the default PHP version and 
> supported versions might differ between Debian, Ubuntu and other 
> distributions.
>
> It might be just fine to replace Debian with a substvar though, patches are 
> welcome, php-defaults is hosted on salsa.d.o.

I actually tried that before filing this bug. But it looked to me like
debian/control has to be manually regenerated (unlike Debian GNOME
packages where debian/control is actually modified during the build
but only to update the Uploaders field.)

So unless I also modify debian/rules to update debian/control (or
maybe dh_gencontrol) during the build, Ubuntu still wouldn't be able
to literally sync the package from Debian to have the package not
claim to be representing Debian's default PHP version. It looked like
using dh_gencontrol would be a bit ugly.

Thanks,
Jeremy Bicha

Bug#893967: [php-maint] Bug#893967: php-defaults: Drop distribution name from package descriptions

[Ondřej Surý]

Jeremy,

the d/control is generated from d/control.in and the contents are crafted based 
on number of supported PHP version, as the default PHP version and supported 
versions might differ between Debian, Ubuntu and other distributions.

It might be just fine to replace Debian with a substvar though, patches are 
welcome, php-defaults is hosted on salsa.d.o.

Cheers.
Ondrej
-- 
Ondřej Surý 

On Sat, Mar 24, 2018, at 18:15, Jeremy Bicha wrote:
> Source: php-defaults
> Version: 60
> 
> The packages in php-defaults have this sentence which is a bit
> problematic for derivative distributions:
> 
> "This package is a dependency package, which depends on Debian's
> default PHP version"
> 
> Please consider removing the specific mention of Debian here. Ubuntu
> modifies php-defaults to replace "Debian" with "Ubuntu" but that feels
> like extra unneeded work.
> 
> Other Comments
> --
> 1. Please drop the Ubuntu "precise" rule from debian/rules since
> Ubuntu 12.04 LTS is no longer in regular support status and it doesn't
> make sense to backport new php-defaults versions there any more.
> 
> 2. Please finish the php7.2 transition to allow Ubuntu to sync this
> package. See the final comment at
> https://bugs.debian.org/872998
> 
> Thanks,
> Jeremy Bicha
> 
> ___
> pkg-php-maint mailing list
> pkg-php-ma...@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-php-maint

Bug#893967: php-defaults: Drop distribution name from package descriptions

[Jeremy Bicha]

Source: php-defaults
Version: 60

The packages in php-defaults have this sentence which is a bit
problematic for derivative distributions:

"This package is a dependency package, which depends on Debian's
default PHP version"

Please consider removing the specific mention of Debian here. Ubuntu
modifies php-defaults to replace "Debian" with "Ubuntu" but that feels
like extra unneeded work.

Other Comments
--
1. Please drop the Ubuntu "precise" rule from debian/rules since
Ubuntu 12.04 LTS is no longer in regular support status and it doesn't
make sense to backport new php-defaults versions there any more.

2. Please finish the php7.2 transition to allow Ubuntu to sync this
package. See the final comment at
https://bugs.debian.org/872998

Thanks,
Jeremy Bicha