Bug#894175: ddccontrol: Please drop gksu dependency on Ubuntu

[Miroslav Kravec]

On Thu, Apr 19, 2018 at 11:03 AM, Simon McVittie  wrote:
> Control: tags -1 + pending
>
> On Tue, 27 Mar 2018 at 06:21:57 +, Miroslav Kravec wrote:
>> Sorry for accidental drop of your changes. Please provide a patch containing
>> your changes.
>
> They appear to have been committed upstream as
> https://github.com/ddccontrol/debian-ddccontrol/commit/b8205d744649f80f509cca074aa9df48123501bd

It was merged in this PR:
https://github.com/ddccontrol/debian-ddccontrol/pull/1.

I'll add a patch to use pkexec as a replacement of gksu. And, then
release a new version of Debian package.

> This did make an excellent example for #850156 of a package where the
> existence of d/p/ubuntu.series was harmful to Ubuntu, though, so thanks
> for (accidentally) providing that :-)
>
>> As for gksu, current version of ddccontrol still depends on it.
>
> Does this mean that gddccontrol has never worked as intended on Debian,
> only on Ubuntu?

Looking at changelog, it was added in:

ddccontrol (0.4.2-9) unstable; urgency=low
-- ... <...@...>  Fri, 01 Jul 2011 14:39:06 +0200

I have no idea, what was intended then. But, I don't consider an
application without access to its resources (i2c) devices to be
working correctly.

>> This will
>> change with next release of ddccontrol, where D-Bus daemon is used to perform
>> HW access
>
> That is a much better approach to this sort of controlled privilege
> escalation. (Note that I haven't reviewed the specific implementation
> here.)

Quality of implementation matters, and that's the reason why I'm not
rushing a release of the new ddccontrol version. However, it takes
much longer, than expected, because I have much less free time now.

>> It will get into next Ubuntu release.
>
> (It didn't get into the next Ubuntu release. Ubuntu bionic contains
> a patched version in which Jeremy reapplied the 0.4.2-11 changes to
> fix this.)

I had in mind 18.10, as it was already after Debian import freeze for
18.04. As I see, this gksu removal is quite a special case, which
ignores freeze, and a new debian package version gets pushed anyway.

I'll add this pkexec patch on this weekend, and release a new Debian package.

Bug#894175: ddccontrol: Please drop gksu dependency on Ubuntu

[Simon McVittie]

Control: tags -1 + pending

On Tue, 27 Mar 2018 at 06:21:57 +, Miroslav Kravec wrote:
> Sorry for accidental drop of your changes. Please provide a patch containing
> your changes.

They appear to have been committed upstream as
https://github.com/ddccontrol/debian-ddccontrol/commit/b8205d744649f80f509cca074aa9df48123501bd

This did make an excellent example for #850156 of a package where the
existence of d/p/ubuntu.series was harmful to Ubuntu, though, so thanks
for (accidentally) providing that :-)

> As for gksu, current version of ddccontrol still depends on it.

Does this mean that gddccontrol has never worked as intended on Debian,
only on Ubuntu?

> This will
> change with next release of ddccontrol, where D-Bus daemon is used to perform
> HW access

That is a much better approach to this sort of controlled privilege
escalation. (Note that I haven't reviewed the specific implementation
here.)

> It will get into next Ubuntu release.

(It didn't get into the next Ubuntu release. Ubuntu bionic contains
a patched version in which Jeremy reapplied the 0.4.2-11 changes to
fix this.)

smcv

Bug#894175: ddccontrol: Please drop gksu dependency on Ubuntu

[Miroslav Kravec]

Sorry for accidental drop of your changes. Please provide a patch
containing your changes.

As for gksu, current version of ddccontrol still depends on it. This will
change with next release of ddccontrol, where D-Bus daemon is used to
perform HW access:
https://github.com/ddccontrol/ddccontrol/blob/master/CHANGELOG.md

But, the next version wasn't throughly tested, I will test it more. It will
get into next Ubuntu release. And, I hope that I'll be able to make more
improvements, also.

Kind regards,
Miroslav Kravec

Dňa ut 27. 3. 2018 o 4:45 Jeremy Bicha  napísala(a):

> Source: ddccontrol
> Version: 0.4.3-1
> Severity: important
>
> Your 0.4.3-1 upload accidentally dropped my 0.4.2-11 changes. In
> particular this change is needed by Ubuntu since Ubuntu may be trying
> to drop gksu for 18.04 LTS.
>
>   "Drop Ubuntu-specific gksu dependency and patch.
>gksu will be removed from Debian and Ubuntu soon."
>
> Thanks,
> Jeremy Bicha
>

Bug#894175: ddccontrol: Please drop gksu dependency on Ubuntu

[Jeremy Bicha]

Source: ddccontrol
Version: 0.4.3-1
Severity: important

Your 0.4.3-1 upload accidentally dropped my 0.4.2-11 changes. In
particular this change is needed by Ubuntu since Ubuntu may be trying
to drop gksu for 18.04 LTS.

  "Drop Ubuntu-specific gksu dependency and patch.
   gksu will be removed from Debian and Ubuntu soon."

Thanks,
Jeremy Bicha