Bug#896115: RFS: python-cerberus/1.2-1 [ITP]

[Joel Cross]

> Hm, from what I've seen the package is pretty much the same as it was
> when you submitted it.  I'm using the following repository:
> 
>   https://salsa.debian.org/python-team/modules/python-cerberus
> 
> And I don't see the fixes I asked you to do.  Maybe I'm looking at the
> wrong place?

Oops, I `dput` the package but I didn't push the repo back to Salsa. I have 
done that now.

> >> 2) On d/rules, there's no need to override dh_compress.  It
> > automatically excludes HTML files when compressing things.
> >
> > I read in the docs that HTML files are supposed to be excluded, but
> > for some reason the one HTML file changelog.html was being gzipped. I
> > couldn't figure out why, but adding the exclude line fixed the
> > problem.
> 
> Ah, thanks for explaining.  I didn't know that.  I guess it has
> something to do with the name "changelog"; it's probably installed by
> dh_installchangelogs...
> 
> Can you please add a comment on top of the override_dh_compress rule
> explaining this, then?
Done

Bug#896115: RFS: python-cerberus/1.2-1 [ITP]

[Sergio Durigan Junior]

On Thursday, April 26 2018, Joel Cross wrote:

> Hi Sergio,

Hey, Joel,

> Thanks for all the comments. I've addressed most of them and re-uploaded the 
> package. As for this one:

Hm, from what I've seen the package is pretty much the same as it was
when you submitted it.  I'm using the following repository:

  https://salsa.debian.org/python-team/modules/python-cerberus

And I don't see the fixes I asked you to do.  Maybe I'm looking at the
wrong place?

>> 2) On d/rules, there's no need to override dh_compress.  It
> automatically excludes HTML files when compressing things.
>
> I read in the docs that HTML files are supposed to be excluded, but
> for some reason the one HTML file changelog.html was being gzipped. I
> couldn't figure out why, but adding the exclude line fixed the
> problem.

Ah, thanks for explaining.  I didn't know that.  I guess it has
something to do with the name "changelog"; it's probably installed by
dh_installchangelogs...

Can you please add a comment on top of the override_dh_compress rule
explaining this, then?

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#896115: RFS: python-cerberus/1.2-1 [ITP]

[Joel Cross]

Hi Sergio,

Thanks for all the comments. I've addressed most of them and re-uploaded the 
package. As for this one:

> 2) On d/rules, there's no need to override dh_compress.  It
automatically excludes HTML files when compressing things.

I read in the docs that HTML files are supposed to be excluded, but for some 
reason the one HTML file changelog.html was being gzipped. I couldn't figure 
out why, but adding the exclude line fixed the problem.

Please can you take a look at the updated package and let me know if you think 
it's ready for upload now?

-- 
  Joel Cross

Bug#896115: RFS: python-cerberus/1.2-1 [ITP]

[Sergio Durigan Junior]

Control: tags -1 + moreinfo

On Friday, April 20 2018, I wrote:

> On Thursday, April 19 2018, Joel Cross wrote:
>
>>   Dear mentors,
>>
>>   I am looking for a sponsor for my package "python-cerberus"
>>
>>  * Package name: python-cerberus
>>Version : 1.2-1
>>Upstream Author : Nicola Iarocci 
>>  * URL : http://github.com/pyeve/cerberus
>>  * License : ISC
>>Section : python
>>
>>   It builds those binary packages:
>>
>> python-cerberus-doc - Documentation for python3-cerberus
>>  python3-cerberus - Lightweight, extensible data validation library for 
>> Python
>
> Thanks for the package, Joel.  A few nits, mostly small:
[...]

Hi there,

I saw you were accepted by the DPMT.  Great!  Now you can create a
repository under the python-team/modules namespace and just move your
stuff there.

I'm just marking this bug with the moreinfo tag so that it doesn't fall
into the cracks.  Let me know when you've addressed the comments, and we
can go from there.

Cheers,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#896115: RFS: python-cerberus/1.2-1 [ITP]

[Sergio Durigan Junior]

On Thursday, April 19 2018, Joel Cross wrote:

>   Dear mentors,
>
>   I am looking for a sponsor for my package "python-cerberus"
>
>  * Package name: python-cerberus
>Version : 1.2-1
>Upstream Author : Nicola Iarocci 
>  * URL : http://github.com/pyeve/cerberus
>  * License : ISC
>Section : python
>
>   It builds those binary packages:
>
> python-cerberus-doc - Documentation for python3-cerberus
>  python3-cerberus - Lightweight, extensible data validation library for Python

Thanks for the package, Joel.  A few nits, mostly small:

1) The d/control file is missing a Vcs-Browser field, which informs the
URL where the git repository can be visited using a web browser.  It
should be:

  Vcs-Browser: https://salsa.debian.org/joelcross-guest/python-cerberus

2) On d/rules, there's no need to override dh_compress.  It
automatically excludes HTML files when compressing things.

3) Because your package installs online documentation, you'll need to
provide a .doc-base file for the -doc package.  Look at:

  


for an example, and at:

  

for more info.

4) You can enable the testsuite from autopkgtest to run automatically on
Python packages.  On d/control, just use:

  Testsuite: autopkgtest-pkg-python

5) Thanks for taking care of the privacy issue with a patch on
d/patches/.  Just one nit: you don't actually need the disclaimer "The
information above should follow...".  Please remove that.  And do you
think upstream would consider this patch?  I think it's worth trying
sending it.

Also, still on the topic of patch management, it's a good practice to
not push the "patch-queue/master" branch to the official repository.

6) There are a bunch of spelling errors in the manpage.  You can see
them by using:

  lintian -EI --pedantic python-cerberus_1.2-1_amd64.changes

You might consider fixing them in another patch, and submitting the fix
upstream as well.  But I'm OK with uploading the package with these
spelling errors initially, and fixing them later.

7) You will want to install CHANGES.rst as the changelog file.  Just
override dh_installchangelogs:

  override_dh_installchangelogs:
  dh_installchangelogs CHANGES.rst




Other than that, the package is ready for upload.  Let's just wait until
you're accepted into the Debian Python team (so you can move the
repository to the official Debian Python namespace on salsa and change
the Vcs-* fields accordingly), and then I will happily upload it.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#896115: RFS: python-cerberus/1.2-1 [ITP]

[Sergio Durigan Junior]

Control: owner -1 !

On Thursday, April 19 2018, Joel Cross wrote:

>   Dear mentors,
>
>   I am looking for a sponsor for my package "python-cerberus"
>
>  * Package name: python-cerberus
>Version : 1.2-1
>Upstream Author : Nicola Iarocci 
>  * URL : http://github.com/pyeve/cerberus
>  * License : ISC
>Section : python
>
>   It builds those binary packages:
>
> python-cerberus-doc - Documentation for python3-cerberus
>  python3-cerberus - Lightweight, extensible data validation library for Python
>
>   To access further information about this package, please visit the following
> URL:
>
>   https://mentors.debian.net/package/python-cerberus
>
>
>   Alternatively, one can download the package with dget using this command:
>
> dget -x https://mentors.debian.net/debian/pool/main/p/python-
> cerberus/python-cerberus_1.2-1.dsc
>
>   More information about Cerberus can be obtained from http://python-
> cerberus.org/.
>
>   Regards,
>Joel Cross

Thanks for your interest.  I'll review this package.

Cheers,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#896115: RFS: python-cerberus/1.2-1 [ITP]

[Joel Cross]

Package: sponsorship-requests
Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package "python-cerberus"

 * Package name: python-cerberus
   Version : 1.2-1
   Upstream Author : Nicola Iarocci 
 * URL : http://github.com/pyeve/cerberus
 * License : ISC
   Section : python

  It builds those binary packages:

python-cerberus-doc - Documentation for python3-cerberus
 python3-cerberus - Lightweight, extensible data validation library for Python

  To access further information about this package, please visit the following
URL:

  https://mentors.debian.net/package/python-cerberus


  Alternatively, one can download the package with dget using this command:

dget -x https://mentors.debian.net/debian/pool/main/p/python-
cerberus/python-cerberus_1.2-1.dsc

  More information about Cerberus can be obtained from http://python-
cerberus.org/.

  Regards,
   Joel Cross



-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), 
LANGUAGE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled