Bug#896943: bug still appears unfixed in diagram after closing with Version header

2018-04-26 Thread Don Armstrong
On Thu, 26 Apr 2018, Daniel Pocock wrote:
> The precise upstream version with the fix is an accurate piece of
> information, is there a strong reason not to accept that information
> from a maintainer and then use the version comparison algorithm to
> automatically decide which changelog versions are fixed?

The reason is that there's no universal way to turn arbitrary upstream
version strings into the corresponding Debian version.

Sometimes it's obvious (like this case), but it's not obvious in enough
cases that there's no heuristic for it.

Producing more informative errors/warning messages when bugs are closed
with wrong versions is on my todo list. [Currently, if you used
fixed/found with invalid versions, you do get warnings, but Versions:
to -done doesn't produce that output.]

-- 
Don Armstrong  https://www.donarmstrong.com

Le temps est un grand maître, dit-on; le malheur est qu'il soit un
maître inhumain qui tue ses élèves.
Time is a great teacher, but unfortunately it kills all its pupils.
 -- Hector Berlioz



Bug#896943: bug still appears unfixed in diagram after closing with Version header

2018-04-26 Thread Daniel Pocock


On 26/04/18 11:20, Adam D. Barratt wrote:
> On 2018-04-26 09:20, Daniel Pocock wrote:
>> I closed this bug by sending an email to the -done address and include a
>> Version pseudo-header:
>>
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=724305;msg=70
>>
>> The diagram displayed at the top right corner of the page still suggests
>> the bug is open in versions after the fix:
>>
>> https://bugs.debian.org/cgi-bin/version.cgi?collapse=1;package=postbooks;info=1;fixed=4.5.0;found=postbooks%2F4.0.2-3;absolute=0
>>
> 
> There are no Debian package versions "after" 4.5.0, because there never
> has been such a version. (See below rather than repeating why.)
> 
>> A subsequent message sent to the control server (using a different
>> version number) has fixed the diagram though.  Why didn't the Version
>> pseudo-header work?
> 
> Because there has never been an upload of postbooks to Debian that used
> the version number "4.5.0" in a changelog stanza.
> 
> Versions aren't arbitrary strings in BTS version tracking. If you want
> to use them in fixed / found lists, they need to match actual Debian
> version numbers that appear in the package's debian/changelog as
> uploaded to the archive.
> 


Could the BTS send a response explaining that when somebody tries to use
a Version it won't handle?

The precise upstream version with the fix is an accurate piece of
information, is there a strong reason not to accept that information
from a maintainer and then use the version comparison algorithm to
automatically decide which changelog versions are fixed?

Regards,

Daniel



Bug#896943: bug still appears unfixed in diagram after closing with Version header

2018-04-26 Thread Adam D. Barratt

On 2018-04-26 09:20, Daniel Pocock wrote:
I closed this bug by sending an email to the -done address and include 
a

Version pseudo-header:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=724305;msg=70

The diagram displayed at the top right corner of the page still 
suggests

the bug is open in versions after the fix:

https://bugs.debian.org/cgi-bin/version.cgi?collapse=1;package=postbooks;info=1;fixed=4.5.0;found=postbooks%2F4.0.2-3;absolute=0


There are no Debian package versions "after" 4.5.0, because there never 
has been such a version. (See below rather than repeating why.)



A subsequent message sent to the control server (using a different
version number) has fixed the diagram though.  Why didn't the Version
pseudo-header work?


Because there has never been an upload of postbooks to Debian that used 
the version number "4.5.0" in a changelog stanza.


Versions aren't arbitrary strings in BTS version tracking. If you want 
to use them in fixed / found lists, they need to match actual Debian 
version numbers that appear in the package's debian/changelog as 
uploaded to the archive.


Regards,

Adam



Bug#896943: bug still appears unfixed in diagram after closing with Version header

2018-04-26 Thread Daniel Pocock
package: bugs.debian.org


Hi,

I closed this bug by sending an email to the -done address and include a
Version pseudo-header:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=724305;msg=70

The diagram displayed at the top right corner of the page still suggests
the bug is open in versions after the fix:

https://bugs.debian.org/cgi-bin/version.cgi?collapse=1;package=postbooks;info=1;fixed=4.5.0;found=postbooks%2F4.0.2-3;absolute=0


A subsequent message sent to the control server (using a different
version number) has fixed the diagram though.  Why didn't the Version
pseudo-header work?

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=724305;msg=74

Regards,

Daniel