Bug#897577: cinnamon-settings-daemon: stop using deprecated libdbus-glib-1-dev

[Simon McVittie]

On Thu, 03 May 2018 at 15:10:39 +0200, Helmut Grohne wrote:
> On Thu, May 03, 2018 at 12:24:42PM +0200, Maximiliano Curia wrote:
> > What do you suggests as a replacement of dbus-binding-tool?
> 
> It's not just about dbus-binding-tool. E.g. csd-datetime-mechanism.c
> says #include . That'll have to go away as well. We're
> talking about switching an entire library.

Am I right in thinking that cinnamon-settings-daemon is a fork of
gnome-settings-daemon? The modules that make up g-s-d were ported from
dbus-glib to GDBus (variously described as "GDBus" or "GIO's DBus API"
in NEWS) between versions 2.91.2 (2010) and 3.3.90 (2012), according to
g-s-d's NEWS file. Many (all?) of those changes are probably applicable
to c-s-d.

dbus-binding-tool generates code that uses . To convert
c-s-d to GDBus, it would be necessary to change all calls into code
generated by dbus-binding-tool, and any hand-written dbus_foo() calls,
to their GDBus equivalents. The closest equivalent of dbus-binding-tool
for GDBus is gdbus-codegen.

https://gitlab.gnome.org/GNOME/gnome-settings-daemon/commit/d7cd7cfef5c77e16e6693b8991cb2ae5a187db12
is an example of conversion from dbus-glib to GDBus without using
gdbus-codegen. gnome-settings-daemon doesn't seem to use gdbus-codegen
for service-side code.

>From some searches on
https://github.com/linuxmint/cinnamon-settings-daemon it looks as though
the datetime plugin is the only part still using dbus-glib. The equivalent
in gnome-settings-daemon was deleted in

and replaced by a new plugin using systemd-timedated and Geoclue in
.

If it is a goal for Cinnamon to support non-systemd system services,
I would suggest using a compatible reimplementation of the timedated
API 
such as  rather than having a
Cinnamon-specific system-level daemon.

smcv

Bug#897577: cinnamon-settings-daemon: stop using deprecated libdbus-glib-1-dev

[Helmut Grohne]

On Thu, May 03, 2018 at 12:24:42PM +0200, Maximiliano Curia wrote:
> > libdbus-glib-1-dev: is deprecated (#895291). We want to remove it in the
> > long run, so cinnamon-settings-daemon should stop using it. In
> > particular, it is presently using dbus-binding-tool and that happens to
> > not work well for cross compilation (see #873617). Rather than fixing
> > dbus-glib, the work should be invested in reducing reverse dependencies.
> > cinnamon-settings-daemon is one of those. Refer to #895291 for
> > suggestions on how to move forward.
> 
> What do you suggests as a replacement of dbus-binding-tool?

It's not just about dbus-binding-tool. E.g. csd-datetime-mechanism.c
says #include . That'll have to go away as well. We're
talking about switching an entire library.

Simon McVittie has summarized the options on #895291. If that is too
short, maybe we can ask him to elaborate.

Helmut

Bug#897577: cinnamon-settings-daemon: stop using deprecated libdbus-glib-1-dev

[Maximiliano Curia]

¡Hola Helmut!

El 2018-05-03 a las 07:12 +0200, Helmut Grohne escribió:

Source: cinnamon-settings-daemon
Version: 3.6.2-1
Tags: upstream
User: helm...@debian.org
Usertags: rebootstrap
Control: block 895291 by -1



libdbus-glib-1-dev: is deprecated (#895291). We want to remove it in the
long run, so cinnamon-settings-daemon should stop using it. In
particular, it is presently using dbus-binding-tool and that happens to
not work well for cross compilation (see #873617). Rather than fixing
dbus-glib, the work should be invested in reducing reverse dependencies.
cinnamon-settings-daemon is one of those. Refer to #895291 for
suggestions on how to move forward.


What do you suggests as a replacement of dbus-binding-tool?

Happy hacking,
--
"If you can't write it down in English, you can't code it." -- Peter Halpern
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature

Bug#897577: cinnamon-settings-daemon: stop using deprecated libdbus-glib-1-dev

[Helmut Grohne]

Source: cinnamon-settings-daemon
Version: 3.6.2-1
Tags: upstream
User: helm...@debian.org
Usertags: rebootstrap
Control: block 895291 by -1

libdbus-glib-1-dev: is deprecated (#895291). We want to remove it in the
long run, so cinnamon-settings-daemon should stop using it. In
particular, it is presently using dbus-binding-tool and that happens to
not work well for cross compilation (see #873617). Rather than fixing
dbus-glib, the work should be invested in reducing reverse dependencies.
cinnamon-settings-daemon is one of those. Refer to #895291 for
suggestions on how to move forward.

Helmut