Bug#903555: ser2net: replies with WONT COM_PORT on DO COM_PORT
tags #903555 fixed-upstream confirmed pending thanks
Bug#903555: ser2net: replies with WONT COM_PORT on DO COM_PORT
On 07/11/2018 05:02 AM, Uwe Kleine-König wrote:
Package: ser2net
Version: 2.10.1-1
Severity: normal
Hello,
I'm currently working on improving rfc2217-support in microcom and think
that ser2net behaves wrong in reply to microcom's improved behaviour.
Actually, I realized yesterday working on ser2net that this patch is wrong.
You need to add "remctl" to the configuration to enable rfc2217
processing. It is
off by default, but if you add that ser2net will send a WILL for this.
That's the
functions at the end of the line there doing that.
I probably need to do something about the "DO" being sent.
-corey
When I connect to ser2net and then "say":
IAC DO COM_PORT
(i.e. \xff \xfd \x2c) ser2net replies with
IAC WONT COM_PORT
(i.e. \xff \xfc \x2c) which is bogus because that's the purpose of
ser2net and it works just fine if I don't ask for it.
I didn't test, but I guess the fix is:
-{ TN_OPT_COM_PORT,1, 0, 0, 0, 0, 0,
+{ TN_OPT_COM_PORT,1, 1, 0, 0, 0, 0,
in dataxfer.c.
You might also consider to initially send
IAC DO COM_PORT
IAC WILL COM_PORT
(and adapt telnet_cmds[] accordingly).
Best regards
Uwe
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (700, 'testing'), (600, 'unstable'), (500, 'unstable-debug'),
(500, 'stable'), (499, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.16.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages ser2net depends on:
ii libc6 2.27-3
ii libwrap0 7.6.q-27
ser2net recommends no packages.
Versions of packages ser2net suggests:
ii telnet 0.17-41
Bug#903555: ser2net: replies with WONT COM_PORT on DO COM_PORT
tags #903555 confirmed thanks On Wed, Jul 11, 2018 at 01:18:48PM +0200, Uwe Kleine-König wrote: > Looking at the upstream repository this bug was fixed in commit > 59090a089484654e93ea753b87d66a1af37b41b9 two years ago. I will package the new upstream version in due time. Greetings Marc -- - Marc Haber | "I don't trust Computers. They | Mailadresse im Header Leimen, Germany| lose things."Winona Ryder | Fon: *49 6224 1600402 Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
Bug#903555: ser2net: replies with WONT COM_PORT on DO COM_PORT
Control: tag -1 + fixed-upstream
On Wed, Jul 11, 2018 at 12:02:50PM +0200, Uwe Kleine-König wrote:
> I'm currently working on improving rfc2217-support in microcom and think
> that ser2net behaves wrong in reply to microcom's improved behaviour.
>
> When I connect to ser2net and then "say":
>
> IAC DO COM_PORT
>
> (i.e. \xff \xfd \x2c) ser2net replies with
>
> IAC WONT COM_PORT
>
> (i.e. \xff \xfc \x2c) which is bogus because that's the purpose of
> ser2net and it works just fine if I don't ask for it.
>
> I didn't test, but I guess the fix is:
>
> -{ TN_OPT_COM_PORT,1, 0, 0, 0, 0, 0,
> +{ TN_OPT_COM_PORT,1, 1, 0, 0, 0, 0,
>
> in dataxfer.c.
Looking at the upstream repository this bug was fixed in commit
59090a089484654e93ea753b87d66a1af37b41b9 two years ago.
See
https://sourceforge.net/p/ser2net/code/ci/59090a089484654e93ea753b87d66a1af37b41b9
which is exactly the patch I suggested.
Best regards
Uwe
signature.asc
Description: PGP signature
Bug#903555: ser2net: replies with WONT COM_PORT on DO COM_PORT
Package: ser2net
Version: 2.10.1-1
Severity: normal
Hello,
I'm currently working on improving rfc2217-support in microcom and think
that ser2net behaves wrong in reply to microcom's improved behaviour.
When I connect to ser2net and then "say":
IAC DO COM_PORT
(i.e. \xff \xfd \x2c) ser2net replies with
IAC WONT COM_PORT
(i.e. \xff \xfc \x2c) which is bogus because that's the purpose of
ser2net and it works just fine if I don't ask for it.
I didn't test, but I guess the fix is:
-{ TN_OPT_COM_PORT,1, 0, 0, 0, 0, 0,
+{ TN_OPT_COM_PORT,1, 1, 0, 0, 0, 0,
in dataxfer.c.
You might also consider to initially send
IAC DO COM_PORT
IAC WILL COM_PORT
(and adapt telnet_cmds[] accordingly).
Best regards
Uwe
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (700, 'testing'), (600, 'unstable'), (500, 'unstable-debug'),
(500, 'stable'), (499, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.16.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages ser2net depends on:
ii libc6 2.27-3
ii libwrap0 7.6.q-27
ser2net recommends no packages.
Versions of packages ser2net suggests:
ii telnet 0.17-41
