Bug#904261: [pkg-go] Bug#904261: dh-golang: Don't install files listed in DH_GOLANG_EXCLUDES to dev pacakge
On 9/14/18 3:11 PM, Martín Ferrari wrote: > On 12/09/18 15:59, Martín Ferrari wrote: > >>> I'm not sure it warrants an upload right away, but it would be nice to >>> have it before debhelper is updated. >>> >>> Could anyone sponsor that ? >> >> I would be happy to, but I have not been following dh-golang devel much >> to decide if we sHould upload now.. Any other opinion? > > I have just uploaded it. > > Thanks ! -- nodens
Bug#904261: [pkg-go] Bug#904261: dh-golang: Don't install files listed in DH_GOLANG_EXCLUDES to dev pacakge
On 12/09/18 15:59, Martín Ferrari wrote: >> I'm not sure it warrants an upload right away, but it would be nice to >> have it before debhelper is updated. >> >> Could anyone sponsor that ? > > I would be happy to, but I have not been following dh-golang devel much > to decide if we sHould upload now.. Any other opinion? I have just uploaded it. -- Martín Ferrari (Tincho)
Bug#904261: [pkg-go] Bug#904261: dh-golang: Don't install files listed in DH_GOLANG_EXCLUDES to dev pacakge
On 12/09/18 10:37, Clément Hermann wrote: >> So, if no one objects, I'll merge the branch, add the relevant changelog >> entries and upload^Wask for someone to upload. ;) >> >> (and I'll take care of the bug creation on debhelper meanwhile). > > And it has been merged. THanks for your work!! > I'm not sure it warrants an upload right away, but it would be nice to > have it before debhelper is updated. > > Could anyone sponsor that ? I would be happy to, but I have not been following dh-golang devel much to decide if we sHould upload now.. Any other opinion? -- Martín Ferrari (Tincho)
Bug#904261: [pkg-go] Bug#904261: dh-golang: Don't install files listed in DH_GOLANG_EXCLUDES to dev pacakge
On 10/09/2018 12:47, Clément Hermann wrote: > The change is implemented (see [1]), and Niels is OK to add something to > the compatibility notes of debhelper, as long as we provide the text and > open a bug. This is #908656. > So, if no one objects, I'll merge the branch, add the relevant changelog > entries and upload^Wask for someone to upload. ;) > > (and I'll take care of the bug creation on debhelper meanwhile). And it has been merged. I'm not sure it warrants an upload right away, but it would be nice to have it before debhelper is updated. Could anyone sponsor that ? Cheers, -- nodens
Bug#904261: [pkg-go] Bug#904261: dh-golang: Don't install files listed in DH_GOLANG_EXCLUDES to dev pacakge
On 16/08/2018 17:37, Clément Hermann wrote: > On 16/08/2018 17:13, Clément Hermann wrote: >> On 16/08/2018 16:26, Martín Ferrari wrote: > >>> We could also change the default in the next debhelper compat mode; >>> dunno how this is normally handled, but it would be good to coordinate >>> so this change is documented.. In that case it might be even be sensible >>> to add the switch in the code now. >> That's a great idea. It looks easy enough to add the switch in the code, >> but I couldn't find how those things are usually handled for modules >> outside debhelper itself. I'll ask the perl team, apparently that's >> something they did in the past. > > It's actually a bad example, as it's part of debhelper and not an > external module. > > I'll send an email to the debhelper team and ask directly (CC-ing this BR). > > Cheers, > The change is implemented (see [1]), and Niels is OK to add something to the compatibility notes of debhelper, as long as we provide the text and open a bug. So, if no one objects, I'll merge the branch, add the relevant changelog entries and upload^Wask for someone to upload. ;) (and I'll take care of the bug creation on debhelper meanwhile). Cheers, [1] https://salsa.debian.org/go-team/packages/dh-golang/merge_requests/3 -- nodens
Bug#904261: [pkg-go] Bug#904261: dh-golang: Don't install files listed in DH_GOLANG_EXCLUDES to dev pacakge
Hi ! On 22/07/2018 16:49, Shengjing Zhu wrote: > On Sun, Jul 22, 2018 at 10:34 PM Michael Stapelberg > wrote: >> >> There was a discussion on the pkg-go mailing list titled “honoring >> DH_GOLANG_EXCLUDES for sources” a while ago, started by Clément (cc'ed). >> > > Ah, right, I thought I've read this before, but forget where. > Yes, and life happened meanwhile, but it's still on my radar, and I definitely intend to have a proper look at it a submit a MR during DebCamp :) -- nodens
Bug#904261: [pkg-go] Bug#904261: dh-golang: Don't install files listed in DH_GOLANG_EXCLUDES to dev pacakge
There was a discussion on the pkg-go mailing list titled “honoring
DH_GOLANG_EXCLUDES for sources” a while ago, started by Clément (cc'ed).
On Sun, Jul 22, 2018 at 1:58 PM, Shengjing Zhu wrote:
> Package: dh-golang
> Severity: wishlist
>
> Dear Maintainer,
>
> In install phase, dh-golang just calls `cp -r -T src/$ENV{DH_GOPKG}
> $dest_src`,
> which installs DH_GOLANG_EXCLUDES files to /usr/share/gocode/src/.
>
> Shouldn't these files not be installed as well?
>
> A real example is, paride asked on irc that why golang-github-prometheus-
> client-golang
> installs `examples` files twice in -dev package, (once installed by
> dh-golang,
> once installed by dh_installexamples).
>
> --
> Best regards,
> Shengjing Zhu
>
> ___
> Pkg-go-maintainers mailing list
> pkg-go-maintain...@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/
> pkg-go-maintainers
--
Best regards,
Michael
