Bug#905881: lintian: detect packages containing X11 fonts that do not run update-fonts-* or do not dep on xfonts-utils

2018-08-12 Thread Chris Lamb 
Hi Paul,

> A few fixes are needed:

Should be addressed in:

  
https://salsa.debian.org/lintian/lintian/commit/f8c6c421ec09c19ffeae1bba72db36ddbfe9925c
  
https://salsa.debian.org/lintian/lintian/commit/27e64df93736cea60a607572880ca408b97cd9aa


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#905881: lintian: detect packages containing X11 fonts that do not run update-fonts-* or do not dep on xfonts-utils

2018-08-11 Thread Paul Wise 
On Sat, 2018-08-11 at 10:07 +0100, Chris Lamb wrote:

>   
> https://salsa.debian.org/lintian/lintian/commit/1fe8f33d7ffaab74c47d5ed61c56d8a8a0abb693

Thanks.

A few fixes are needed:

s/which comes/which come/

s/If you are using dh_installxfonts/If you are using debhelper/

The code unconditionally detects update-fonts-scale but the
dh_installxfonts code only inserts that conditionally (see below).

The code does not detect update-fonts-alias being missing but
dh_installxfonts conditionally inserts calls to that (see below).

One of the tag descriptions mentions an update-fonts-utils script,
but that does not exist:

$ find /usr/sbin/update-fonts-*
/usr/sbin/update-fonts-alias
/usr/sbin/update-fonts-dir
/usr/sbin/update-fonts-scale

Here is most of the code from dh_installxfonts:

foreach my $package (@{$dh{DOPACKAGES}}) {
my $tmp=tmpdir($package);

# Find all font directories in the package build directory.
my @fontdirs;
foreach my $parentdir ("$tmp/usr/share/fonts/X11/") {
opendir(DIR, $parentdir) || next;
@fontdirs = grep { -d "$parentdir/$_" && !/^\./ } (readdir DIR);
closedir DIR;
}

if (@fontdirs) {
# Figure out what commands the postinst and postrm will need 
# to call.
my @cmds;
my @cmds_postinst;
my @cmds_postrm;
# Sort items for reproducible binary package contents.
foreach my $f (sort @fontdirs) {
# This must come before update-fonts-dir.
push @cmds, "update-fonts-scale $f"
if -f "$tmp/etc/X11/fonts/$f/$package.scale";
push @cmds, "update-fonts-dir --x11r7-layout $f";
if (-f "$tmp/etc/X11/fonts/$f/$package.alias") {
push @cmds_postinst, "update-fonts-alias 
--include /etc/X11/fonts/$f/$package.alias $f";
push @cmds_postrm, "update-fonts-alias 
--exclude /etc/X11/fonts/$f/$package.alias $f";
}
}

autoscript($package, "postinst", "postinst-xfonts",
{ 'CMDS' => join(";", @cmds, @cmds_postinst) });
autoscript($package, "postrm", "postrm-xfonts",
{ 'CMDS' => join(";", @cmds, @cmds_postrm) });

if (@cmds_postrm) {
addsubstvar($package, "misc:Depends", "xfonts-utils", 
">= 1:7.5+2");
} else {
addsubstvar($package, "misc:Depends", "xfonts-utils");
}
}
}

-- 
bye,
pabs

https://wiki.debian.org/PaulWise



signature.asc
Description: This is a digitally signed message part

Bug#905881: lintian: detect packages containing X11 fonts that do not run update-fonts-* or do not dep on xfonts-utils

2018-08-11 Thread Chris Lamb 
tags 905881 + pending
thanks

Implemented in:

  
https://salsa.debian.org/lintian/lintian/commit/283f67292b51f2173835bfbd9f5f8f8bd51f465f


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#905881: lintian: detect packages containing X11 fonts that do not run update-fonts-* or do not dep on xfonts-utils

2018-08-11 Thread Chris Lamb 
Chris Lamb wrote:

> Implemented in:

That should have been:

  
https://salsa.debian.org/lintian/lintian/commit/1fe8f33d7ffaab74c47d5ed61c56d8a8a0abb693


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#905881: lintian: detect packages containing X11 fonts that do not run update-fonts-* or do not dep on xfonts-utils

2018-08-10 Thread Paul Wise 
Package: lintian
Version: 2.5.96
Severity: wishlist

As a result of a thread[1] on debian-fonts, I found that lmodern and
tex-gyre contain X11 fonts but do not run update-fonts-* from their
postinst and do not depend on xfonts-utils via ${misc:Depends}, both
of these are automatically added by dh_installxfonts if run correctly.

I filed bugs[2] about these issues but it would be nice to have lintian
detect binary packages containing X11 fonts[3] that do not depend on
xfonts-utils or do not have the dh_installxfonts snippet[4] that
debhelper installs into the maintainer scripts.

1. 
https://lists.debian.org/msgid-search/CAJqvfD-A1EPXxF_mS=_baq0ftqygvwruf+23wqsqrksmygv...@mail.gmail.com
2. https://bugs.debian.org/905879
   https://bugs.debian.org/905880
3. /usr/share/fonts/X11/**/*.pcf.gz
   /usr/share/fonts/X11/**/*.pcf
   /usr/share/fonts/X11/**/*.pfa
   /usr/share/fonts/X11/**/*.pfb
   /usr/share/fonts/X11/**/*.afm
4. For example:
 # Automatically added by dh_installxfonts/11.3.5
 if [ -x "`which update-fonts-dir 2>/dev/null`" ]; then
update-fonts-scale Type1;update-fonts-dir --x11r7-layout Type1
 fi

-- System Information:
Debian Release: buster/sid
  APT prefers testing-debug
  APT policy: (900, 'testing-debug'), (900, 'testing'), (800, 
'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700, 
'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.17.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8), 
LANGUAGE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils   2.31.1-2
ii  bzip2  1.0.6-8.1
ii  diffstat   1.61-1+b1
ii  dpkg   1.19.0.5+b1
ii  file   1:5.33-3
ii  gettext0.19.8.1-6+b1
ii  intltool-debian0.35.0+20060710.4
ii  libapt-pkg-perl0.1.34
ii  libarchive-zip-perl1.60-1
ii  libclass-accessor-perl 0.51-1
ii  libclone-perl  0.39-1
ii  libdpkg-perl   1.19.0.5
ii  libemail-valid-perl1.202-1
ii  libfile-basedir-perl   0.08-1
ii  libipc-run-perl20180523.0-1
ii  liblist-moreutils-perl 0.416-1+b3
ii  libparse-debianchangelog-perl  1.2.0-12
ii  libtext-levenshtein-perl   0.13-1
ii  libtimedate-perl   2.3000-2
ii  liburi-perl1.74-1
ii  libxml-simple-perl 2.25-1
ii  libyaml-libyaml-perl   0.72+repack-1
ii  man-db 2.8.4-2
ii  patchutils 0.3.4-2
ii  perl [libdigest-sha-perl]  5.26.2-6
ii  t1utils1.41-2
ii  xz-utils   5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
ii  binutils-multiarch 2.31.1-2
ii  dpkg-dev   1.19.0.5
ii  libhtml-parser-perl3.72-3+b2
ii  libtext-template-perl  1.53-1

-- no debconf information

-- 
bye,
pabs

https://wiki.debian.org/PaulWise



signature.asc
Description: This is a digitally signed message part