Bug#906211: lintian: python-script-but-no-python-dep despite Recommends
Hi Chris, > > Just wondering what the next steps for Lintian are here? > > Gentle ping on this? sorry, this got lost in the INBOX pile. As you pointed out, there’s currently no way to model the right thing, given the implicit choice in the shebang line. So I think there’s nothing left to do for lintian (feel free to close the bug if you agree), and I’ll go with an override, for now. In this particular case, being a Recommends, needed only for a helper script shipped by the package, and given that half the package relationship matches, I think that’s ok. bye, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-235 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Bug#906211: lintian: python-script-but-no-python-dep despite Recommends
Chris Lamb wrote: > tags 906211 + moreinfo > thanks > > Chris Lamb wrote: > > > If you want to keep using Python 2.x then simply leaving the script as- > > is and recommending only python (ie. Python 2.x) is the correct > > solution here. > > > > Once this customer moves to (and is comfortable with) deploying Python > > 3, you can update the shebang and the Recommends. > > > > "Silencing" Lintian is not the correct approachas "python | python3" > > is, alas, simply not correct. > > Just wondering what the next steps for Lintian are here? Gentle ping on this? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#906211: lintian: python-script-but-no-python-dep despite Recommends
tags 906211 + moreinfo thanks Chris Lamb wrote: > If you want to keep using Python 2.x then simply leaving the script as- > is and recommending only python (ie. Python 2.x) is the correct > solution here. > > Once this customer moves to (and is comfortable with) deploying Python > 3, you can update the shebang and the Recommends. > > "Silencing" Lintian is not the correct approachas "python | python3" > is, alas, simply not correct. Just wondering what the next steps for Lintian are here? Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#906211: lintian: python-script-but-no-python-dep despite Recommends
Thorsten, > > I would suggest changing the shebang to "#!/usr/bin/env python3" and > > recommending only python3. > > It’s just a Recommends, sure, but this is a package that, while > I always also test it on sid, currently targets jessie and PHP5 > on the customer’s site, so I’m a bit wary of requiring py3k yet > (also I didn’t test it with that old a version). If you want to keep using Python 2.x then simply leaving the script as- is and recommending only python (ie. Python 2.x) is the correct solution here. Once this customer moves to (and is comfortable with) deploying Python 3, you can update the shebang and the Recommends. "Silencing" Lintian is not the correct approachas "python | python3" is, alas, simply not correct. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#906211: lintian: python-script-but-no-python-dep despite Recommends
Thorsten, > It might be the python 2-or-3 thing. The lines used to read > Recommends: python > and it did not trigger this rule, but recently it started to > trigger another rule (obsolete python version), so I ported > the script to work with both 2.7 and 3.6 and extended the > Recommends so either version would suffice. In that case, regardless of the Lintian logic here your OR is not correct for this package. Gven that the shebang points to #!/usr/bin/python (ie. Python 2.x) this would not be satisfied by the "| python3" suffix I would suggest changing the shebang to "#!/usr/bin/env python3" and recommending only python3. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#906211: lintian: python-script-but-no-python-dep despite Recommends
Hi Chris, > > It might be the python 2-or-3 thing. The lines used to read > > Recommends: python > > and it did not trigger this rule, but recently it started to > > trigger another rule (obsolete python version), so I ported > > the script to work with both 2.7 and 3.6 and extended the > > Recommends so either version would suffice. > > In that case, regardless of the Lintian logic here your OR is not > correct for this package. Gven that the shebang points to > #!/usr/bin/python (ie. Python 2.x) this would not be satisfied by the > "| python3" suffix hrm. Right. > I would suggest changing the shebang to "#!/usr/bin/env python3" and > recommending only python3. It’s just a Recommends, sure, but this is a package that, while I always also test it on sid, currently targets jessie and PHP5 on the customer’s site, so I’m a bit wary of requiring py3k yet (also I didn’t test it with that old a version). Perhaps just removing the shebang and chmod -x’ing it would si‐ lence lintian? bye, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-235 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg * **Besuchen Sie uns auf der dmexco 2018!** 12**. **& 13. September 2018, Koelnmesse / **Halle 7,** **Stand A-031** Digital Business, Marketing und Innovation [www.tarent.de/dmexco](http://www.tarent.de/dmexco) * **Visit us at dmexco 2018!** 12th & 13th September, 2018, Koelnmesse / **Hall 7,** **Booth A-031** Digital business, marketing and innovation [www.tarent.de/dmexco](http://www.tarent.de/dmexco) *
Bug#906211: lintian: python-script-but-no-python-dep despite Recommends
Hi Chris, > > Recommends: python | python3 > > > > Binary package also contains the Recommends line (checked). > > > > E: simkolab-common: python-script-but-no-python-dep usr/share/simkolab/ > > php_unserialize.py #!/usr/bin/python > > Can't seem to work out why this triggers. $all_parsed in checks/ > scripts.pm contains Recommends and is being checked against "python:any > | python-minimal:any | python2:any | python2-minimal:any". I wonder if > is is the architecture restrictions. It might be the python 2-or-3 thing. The lines used to read Recommends: python and it did not trigger this rule, but recently it started to trigger another rule (obsolete python version), so I ported the script to work with both 2.7 and 3.6 and extended the Recommends so either version would suffice. bye, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-235 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg * **Besuchen Sie uns auf der dmexco 2018!** 12**. **& 13. September 2018, Koelnmesse / **Halle 7,** **Stand A-031** Digital Business, Marketing und Innovation [www.tarent.de/dmexco](http://www.tarent.de/dmexco) * **Visit us at dmexco 2018!** 12th & 13th September, 2018, Koelnmesse / **Hall 7,** **Booth A-031** Digital business, marketing and innovation [www.tarent.de/dmexco](http://www.tarent.de/dmexco) *
Bug#906211: lintian: python-script-but-no-python-dep despite Recommends
Hi Thorsten, > Recommends: python | python3 > > Binary package also contains the Recommends line (checked). > > E: simkolab-common: python-script-but-no-python-dep usr/share/simkolab/ > php_unserialize.py #!/usr/bin/python Can't seem to work out why this triggers. $all_parsed in checks/ scripts.pm contains Recommends and is being checked against "python:any | python-minimal:any | python2:any | python2-minimal:any". I wonder if is is the architecture restrictions. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#906211: lintian: python-script-but-no-python-dep despite Recommends
Package: lintian Version: 2.5.96 Severity: normal Source package stanza: Package: simkolab-common […] Recommends: python | python3 […] Binary package also contains the Recommends line (checked). E: simkolab-common: python-script-but-no-python-dep usr/share/simkolab/php_unserialize.py #!/usr/bin/python -- System Information: Debian Release: buster/sid APT prefers unreleased APT policy: (500, 'unreleased'), (500, 'buildd-unstable'), (500, 'unstable'), (100, 'experimental') Architecture: x32 (x86_64) Foreign Architectures: i386, amd64 Kernel: Linux 4.17.0-1-amd64 (SMP w/8 CPU cores) Locale: LANG=C, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=C (charmap=UTF-8) Shell: /bin/sh linked to /bin/lksh Init: sysvinit (via /sbin/init) Versions of packages lintian depends on: ii binutils 2.31.1-4 ii bzip2 1.0.6-9 ii diffstat 1.61-1 ii dpkg 1.19.0.5+b1 ii file 1:5.34-2 ii gettext0.19.8.1-7 ii intltool-debian0.35.0+20060710.4 ii libapt-pkg-perl0.1.34 ii libarchive-zip-perl1.60-1 ii libclass-accessor-perl 0.51-1 ii libclone-perl 0.39-1 ii libdigest-sha-perl 6.02-1 ii libdpkg-perl 1.19.0.5 ii libemail-valid-perl1.202-1 ii libfile-basedir-perl 0.08-1 ii libipc-run-perl20180523.0-1 ii liblist-moreutils-perl 0.416-1+b3 ii libparse-debianchangelog-perl 1.2.0-12 ii libtext-levenshtein-perl 0.13-1 ii libtimedate-perl 2.3000-2 ii liburi-perl1.74-1 ii libxml-simple-perl 2.25-1 ii libyaml-libyaml-perl 0.72+repack-1 ii man-db 2.8.4-2 ii patchutils 0.3.4-2 ii perl [libdigest-sha-perl] 5.26.2-7 ii t1utils1.41-2 ii xz-utils 5.2.2-1.3 Versions of packages lintian recommends: pn libperlio-gzip-perl Versions of packages lintian suggests: ii binutils-multiarch 2.31.1-4 ii dpkg-dev 1.19.0.5 ii libhtml-parser-perl3.72-3+b2 pn libtext-template-perl -- no debconf information