Bug#907905: garli: FTBFS randomly (failing tests)

2018-09-04 Thread Andreas Tille
Control: severity -1 normal
Control: tags -1 upstream
Control: forwarded -1 https://github.com/Ashod/garli/issues/1

Hi Santiago,

thanks for your QA effort.

On Mon, Sep 03, 2018 at 10:05:21PM +, Santiago Vila wrote:
> 
> That's how the build ends and not necessarily the relevant part, but
> I've put several build logs here:
> 
> https://people.debian.org/~sanvila/build-logs/garli/
> 
> I estimate that the failure rate might be around 10% so I leave the severity 
> to you.
> 
> ...
>
> The tests seem to perform simulations based on random numbers, this is
> the perfect recipe to make the failure rate to be a number strictly
> greater than zero, which is a pity.
> 
> A simple fix would be to use a fixed random seed for those random numbers,
> that way at least the random numbers would always be the same.

I uploaded respecting this hint by setting randseed accordingly.
Interestingly some randomness is remaining since not every single build
results in the very same log output (but the diff is drastically smaller
and I think it reduces randomness to a level that the FTBFS issue is
solved.)

Since I think the test failures are an interesting issue for upstream
I opened an issue there

   https://github.com/Ashod/garli/issues/1

and kept the Debian bug open for further documentation.  However I took
the freedom to set the severity to normal.

Thanks again

   Andreas.

BTW, since I did further enhancements to the package by providing an MPI
build the package needs to pass new.  Please wait for version 2.1-3 before
doing new tests.

-- 
http://fam-tille.de



Bug#907905: garli: FTBFS randomly (failing tests)

2018-09-03 Thread Santiago Vila
Package: src:garli
Version: 2.1-2
Tags: ftbfs

Hello Andreas et al.

I tried to build this package in buster but it failed:


[...]
 debian/rules build-indep
dh build-indep
   dh_update_autotools_config -i
   dh_autoreconf -i
aclocal: warning: couldn't open directory 'config/m4': No such file or directory
configure.ac:355: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in 
body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2601: _AC_COMPILE_IFELSE is expanded from...
../../lib/autoconf/general.m4:2617: AC_COMPILE_IFELSE is expanded from...
configure.ac:355: the top level
configure.ac:355: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in 
body
../../lib/autoconf/lang.m4:193: AC_LANG_CONFTEST is expanded from...
../../lib/autoconf/general.m4:2601: _AC_COMPILE_IFELSE is expanded from...
../../lib/autoconf/general.m4:2617: AC_COMPILE_IFELSE is expanded from...

[... snipped ...]

pass 14: -480.5087   (branch= 0.  subset rates= 0.)
Looking for minimum length branches...
Final score = -480.5086
Time used = 0 hours, 0 minutes and 0 seconds
Writing site likelihoods for tree 1 ...

###

Completed 1 replicate search(es) (of 1).
Results:
Replicate 1 : -480.5086   

Parameter estimates:

Partition model subset 1:
 Model contains no estimated parameters

Partition model subset 2:
 Model contains no estimated parameters

Partition model subset 3:
 Model contains no estimated parameters

Treelengths and subset rate multipliers:
  TL   R(1)  R(2)  R(3)
rep 1:  16.376 0.637 1.899 2.724

NOTE: collapsebranches setting ignored when writing and comparing optimized 
trees...

Writing optimized trees and models to scr.p.mkO.ssr.best.all.tre
***TEST**
***Score is 480.50865
***Expected is 477.6848
***SCORE DIFFERENCE IS 2.82385
***ALLOWED ERROR IS 0.05
***Scoring test failed for ./scoring/p.mkO.ssr.conf ***
make[3]: *** [Makefile:425: check-local] Error 1
make[3]: Leaving directory '/<>/tests'
make[2]: *** [Makefile:308: check-am] Error 2
make[2]: Leaving directory '/<>/tests'
make[1]: *** [Makefile:394: check-recursive] Error 1
make[1]: Leaving directory '/<>'
dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
make: *** [debian/rules:6: build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit 
status 2


That's how the build ends and not necessarily the relevant part, but
I've put several build logs here:

https://people.debian.org/~sanvila/build-logs/garli/

I estimate that the failure rate might be around 10% so I leave the severity to 
you.

Please note, however, that there has been a failure on mips for this
version:

https://buildd.debian.org/status/fetch.php?pkg=garli=mips=2.1-2%2Bb1=1534400116=0

(but I've not checked if it's the same type of failure).

The tests seem to perform simulations based on random numbers, this is
the perfect recipe to make the failure rate to be a number strictly
greater than zero, which is a pity.

A simple fix would be to use a fixed random seed for those random numbers,
that way at least the random numbers would always be the same.

Thanks.