Bug#909785: python-pcl: Incomplete debian/copyright and/or "freeware" source code?
Hi Chris, * Chris Lamb [2018-09-30 20:27]: Great stuff; thanks! The only thing I would add would be something that explicitly addresses the the "freeware" term - it is a bit of a "trigger word" for people looking for DFSG violations. Now I get why you where asking for this, thanks for the explanation :). I updated the comment here: https://salsa.debian.org/science-team/pcl/commit/a99ca3f9916a6a5e9d66cc2e7e4eb4adc7d3ade9 Cheers Jochen signature.asc Description: PGP signature
Bug#909785: python-pcl: Incomplete debian/copyright and/or "freeware" source code?
Hi Jochen, > I added comments here: > > https://salsa.debian.org/python-team/modules/python-pcl/commit/bff3480ce174fe28192abe3e256a195081a2013d > > Also, I added a comment to the PCL copyright: > > https://salsa.debian.org/science-team/pcl/commit/df7d3a72113e1b55f2820ae4b5d8773572df43f5 Great stuff; thanks! The only thing I would add would be something that explicitly addresses the the "freeware" term - it is a bit of a "trigger word" for people looking for DFSG violations. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#909785: python-pcl: Incomplete debian/copyright and/or "freeware" source code?
Hi Chris, thanks again to bringing this to my attention. * Chris Lamb [2018-09-28 16:56]: However, as a concrete suggestion I would add "Comment" section to your debian/copyright and almost-literally copy your (own) words, ie.: I added comments here: https://salsa.debian.org/python-team/modules/python-pcl/commit/bff3480ce174fe28192abe3e256a195081a2013d Also, I added a comment to the PCL copyright: https://salsa.debian.org/science-team/pcl/commit/df7d3a72113e1b55f2820ae4b5d8773572df43f5 Cheers Jochen signature.asc Description: PGP signature
Bug#909785: python-pcl: Incomplete debian/copyright and/or "freeware" source code?
Jochen, > Do you have a proposal how to better document this? Not entirely sure what you mean by "better" as you currently do not document this at all (unless I am missing something). However, as a concrete suggestion I would add "Comment" section to your debian/copyright and almost-literally copy your (own) words, ie.: > This is only a comment, copied from the PCL sources (and I believe not > even true over there). Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#909785: python-pcl: Incomplete debian/copyright and/or "freeware" source code?
Hi Chris, * Chris Lamb [2018-09-28 10:07]: I just ACCEPTed python-pcl from NEW but noticed it was missing attribution or similar in debian/copyright for at least some files listed as "freeware" (!= is this even DFSG-free software?). I guess you are talking about this line: https://salsa.debian.org/python-team/modules/python-pcl/blob/master/pcl/pcl_segmentation.pxd#L760 This is only a comment, copied from the PCL sources (and I believe not even true over there). The actual license of python-pcl is stated over here: https://salsa.debian.org/python-team/modules/python-pcl/blob/master/docs/source/license.rst Do you have a proposal how to better document this? Cheers Jochen signature.asc Description: PGP signature
Bug#909785: python-pcl: Incomplete debian/copyright and/or "freeware" source code?
Source: python-pcl Version: 0.3.0~rc1+dfsg-1 Severity: serious Justication: Policy 12.5 X-Debbugs-CC: Jochen Sprickerhof , ftpmas...@debian.org Hi, I just ACCEPTed python-pcl from NEW but noticed it was missing attribution or similar in debian/copyright for at least some files listed as "freeware" (!= is this even DFSG-free software?). This is in no way exhaustive so please check over the entire package carefully and address these on your next upload. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
