Bug#910594: lintian: complain about missing versioned dependency on init-system-helpers

[Chris Lamb]

tags 910594 + pending
thanks

Implemented in Git, pending upload:

  
https://salsa.debian.org/lintian/lintian/commit/369b5d9618f13eb06cbe9805352bea661e1bf4e6

  checks/scripts.desc| 14 +++
  checks/scripts.pm  |  6 +
  debian/changelog   |  3 +++
  .../debian/debian/control.in   | 29 ++
  ...ed-depends-on-init-system-helpers-with.postinst | 10 
  ...depends-on-init-system-helpers-without.postinst | 10 
  .../desc   |  5 
  .../tags   |  3 +++
  8 files changed, 80 insertions(+)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#910594: lintian: complain about missing versioned dependency on init-system-helpers

[Stuart Prescott]

Hi Chris,

> > Over in #910593, I reported that the maintainer script was using a feature
> > of update-rc.d that is not available in stretch.
> 
> Yes, this is something that Lintian could indeed spot.
> 
> > One could also look for the dh_installinit call in debian/rules […]
> 
> Not quite sure what you mean by this bit?

The offending postinst would almost always be created by 

override_dh_installinit:
dh_installinit -u defaults-disabled

So in principle, lintian could look for that call from d/rules rather than the 
update-rc.d call in the postinst. I'm not sure what the relative abilities of 
lintian's d/rules and postinst checkers are, and whether that is a useful 
snippet of information.

Cheers
Stuart

-- 
Stuart Prescotthttp://www.nanonanonano.net/   stu...@nanonanonano.net
Debian Developer   http://www.debian.org/ stu...@debian.org
GPG fingerprint90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7

Bug#910594: lintian: complain about missing versioned dependency on init-system-helpers

[Chris Lamb]

Hi Stuart,

> Over in #910593, I reported that the maintainer script was using a feature of
> update-rc.d that is not available in stretch.

Yes, this is something that Lintian could indeed spot.

> One could also look for the dh_installinit call in debian/rules […]

Not quite sure what you mean by this bit?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#910594: lintian: complain about missing versioned dependency on init-system-helpers

[Stuart Prescott]

Package: lintian
Version: 2.5.108
Severity: wishlist

Over in #910593, I reported that the maintainer script was using a feature of
update-rc.d that is not available in stretch. Could lintian spot that usage
in the maintainer script and, if a versioned dependency on init-system-helpers
is not found, complain? The 'defaults-disabled' option was introduced in
init-system-helpers 1.50. (One could also look for the dh_installinit call
in debian/rules, but looking in the binary package's postinst seems easier.)

regards
Stuart