Bug#913548: spamassassin: running /etc/cron.daily/spamassassin gives: Unescaped left brace in regex is deprecated here
* Brian May [2018-11-30 15:11 +1100]:
> Elimar Riesebieter writes:
>
> > Here we go:
> >
> > root@toy>pts/4 /etc/spamassassin/sa-update-hooks.d # ./amavisd-new
> > Unescaped left brace in regex is deprecated here (and will be fatal in Perl
> > 5.32), passed through in regex; marked by <-- HERE in m/ ( { <-- HERE } (?:
> > / \* )? | \* ) / at (eval 109) line 830.
> > root@toy>pts/4 /etc/spamassassin/sa-update-hooks.d #
> >
> > Get the same result as user amavis
>
> Ok, thanks. Unfortunately I just cannot
> reproduce this error:
>
> (buster-amd64-default)root@silverfish:/etc/spamassassin/sa-update-hooks.d#
> ./amavisd-new
> (buster-amd64-default)root@silverfish:/etc/spamassassin/sa-update-hooks.d#
>
> (similar results on a sid chroot)
>
> Is it possible this is a problem with your config files or something?
The attached patch fixed it for me. The patch is done before debian
patches the source! Harald pointed me to the right place ;)
Elimar
--
The path to source is always uphill!
-unknown-
From c781008678fc330fd5ae8caab1c5aa986bafe298 Mon Sep 17 00:00:00 2001
From: Elimar Riesebieter
Date: Fri, 14 Dec 2018 13:04:46 +0100
Subject: [PATCH] Fix an unescaped brace in amavisd
---
amavisd | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/amavisd b/amavisd
index 7f93194..70a8a28 100755
--- a/amavisd
+++ b/amavisd
@@ -28848,7 +28848,7 @@ sub run_av(@) {
my $f = $bare_fnames->[$k]; my $multi = 0;
if ($one_at_a_time) { # glob templates may be substrings anywhere
local($1); @query_expanded = @query_template; # start afresh
- s{ ( {} (?: / \* )? | \* ) }
+ s{ ( \{\} (?: / \* )? | \* ) }
{ $1 eq '{}' ? "$tempdir/parts"
: $1 eq '{}/*' ? ($multi=1,"$tempdir/parts/$f")
: $1 eq '*'? ($multi=1,$f) : $1
--
2.20.0
signature.asc
Description: PGP signature
Bug#913548: spamassassin: running /etc/cron.daily/spamassassin gives: Unescaped left brace in regex is deprecated here
Elimar Riesebieter writes:
> Here we go:
>
> root@toy>pts/4 /etc/spamassassin/sa-update-hooks.d # ./amavisd-new
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl
> 5.32), passed through in regex; marked by <-- HERE in m/ ( { <-- HERE } (?: /
> \* )? | \* ) / at (eval 109) line 830.
> root@toy>pts/4 /etc/spamassassin/sa-update-hooks.d #
>
> Get the same result as user amavis
Ok, thanks. Unfortunately I just cannot
reproduce this error:
(buster-amd64-default)root@silverfish:/etc/spamassassin/sa-update-hooks.d#
./amavisd-new
(buster-amd64-default)root@silverfish:/etc/spamassassin/sa-update-hooks.d#
(similar results on a sid chroot)
Is it possible this is a problem with your config files or something?
Also line 830 of /usr/sbin/amavisd-new appears to be a comment. Wish the
error included the filename so I can be sure I was looking at the right
file...
--
Brian May
Bug#913548: spamassassin: running /etc/cron.daily/spamassassin gives: Unescaped left brace in regex is deprecated here
* Brian May [2018-11-30 08:10 +1100]:
> > Well, it seems that this is a bug in amavisd-new which is started by
> > /etc/spamassassin/sa-update-hooks.d/amavisd-new. Reassigned hereby.
>
> Why do you think amavisd-new is causing this?
>
> This is a simple shell script that calls another shell script,
> /etc/init.d/amavis. As far as I can tell, stdout gets directed to
> /dev/null and stderr is closed by start-stop-daemon, so cannot display
> anything. In addition, I think amavis-new might redirect stderr, not
> 100% sure here.
>
> Furthermore, if I run this script by hand on a sid system it is silent.
Here we go:
root@toy>pts/4 /etc/spamassassin/sa-update-hooks.d # ./amavisd-new
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.32), passed through in regex; marked by <-- HERE in m/ ( { <-- HERE } (?: /
\* )? | \* ) / at (eval 109) line 830.
root@toy>pts/4 /etc/spamassassin/sa-update-hooks.d #
Get the same result as user amavis
Elimar
--
355/113: Not the famous irrational number pi,
but an incredible simulation!
-unknown
signature.asc
Description: PGP signature
Bug#913548: spamassassin: running /etc/cron.daily/spamassassin gives: Unescaped left brace in regex is deprecated here
> Well, it seems that this is a bug in amavisd-new which is started by > /etc/spamassassin/sa-update-hooks.d/amavisd-new. Reassigned hereby. Why do you think amavisd-new is causing this? This is a simple shell script that calls another shell script, /etc/init.d/amavis. As far as I can tell, stdout gets directed to /dev/null and stderr is closed by start-stop-daemon, so cannot display anything. In addition, I think amavis-new might redirect stderr, not 100% sure here. Furthermore, if I run this script by hand on a sid system it is silent. So kind of wondering how to reproduce this. -- Brian May
Bug#913548: spamassassin: running /etc/cron.daily/spamassassin gives: Unescaped left brace in regex is deprecated here
Control: reassign -1 amavisd-new
* Noah Meyerhans [2018-11-24 14:25 -0800]:
> Control: tags -1 + moreinfo
>
> On Mon, Nov 12, 2018 at 09:05:01AM +0100, Elimar Riesebieter wrote:
> >
> > running /etc/cron.daily/spamassassin gives:
> > Unescaped left brace in regex is deprecated here (and will be fatal in Perl
> > 5.32), passed through in regex; marked by <-- HERE in m/ ( {<-- HERE } (?:
> > / \* )? | \* ) / at (eval 109) line 830.
> >
>
> I'm not seeing this with 3.4.2-1 and perl 5.28.0-4. This was a known
> upstream issue (https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404)
> and should be fixed in 3.4.2.
>
> It seems that there are two possibilities:
>
> 1. The upstream fix was incomplete.
>
> 2. There are some spamassassin components on your system from outside
> the packaging system.
>
> Can you confirm that you're running /usr/bin/sa-update and that there
> aren't any other copies of that program that could be getting picked up
> by the cron job?
>
Well, it seems that this is a bug in amavisd-new which is started by
/etc/spamassassin/sa-update-hooks.d/amavisd-new. Reassigned hereby.
Elimar
--
Excellent day for drinking heavily.
Spike the office water cooler;-)
signature.asc
Description: PGP signature
Bug#913548: spamassassin: running /etc/cron.daily/spamassassin gives: Unescaped left brace in regex is deprecated here
Control: tags -1 + moreinfo
On Mon, Nov 12, 2018 at 09:05:01AM +0100, Elimar Riesebieter wrote:
>
> running /etc/cron.daily/spamassassin gives:
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl
> 5.32), passed through in regex; marked by <-- HERE in m/ ( {<-- HERE } (?: /
> \* )? | \* ) / at (eval 109) line 830.
>
I'm not seeing this with 3.4.2-1 and perl 5.28.0-4. This was a known
upstream issue (https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404)
and should be fixed in 3.4.2.
It seems that there are two possibilities:
1. The upstream fix was incomplete.
2. There are some spamassassin components on your system from outside
the packaging system.
Can you confirm that you're running /usr/bin/sa-update and that there
aren't any other copies of that program that could be getting picked up
by the cron job?
Unfortunately the message shown doesn't give a indication of exactly
where the problematic regex is, so I'll likely need some more info from
you to identify the source. Can you confirm that it's the sa-update
invocation that's actually triggering the warning?
Invoking sa-update as follows (as root) may provide some additional
detail:
# start-stop-daemon --chuid debian-spamd:debian-spamd --start --exec
/usr/bin/sa-update -- --gpghomedir /var/lib/spamassassin/sa-update-keys -v -D
Thanks
noah
signature.asc
Description: PGP signature
Bug#913548: spamassassin: running /etc/cron.daily/spamassassin gives: Unescaped left brace in regex is deprecated here
Package: spamassassin
Version: 3.4.2-1
Severity: important
Hi,
running /etc/cron.daily/spamassassin gives:
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.32), passed through in regex; marked by <-- HERE in m/ ( {<-- HERE } (?: / \*
)? | \* ) / at (eval 109) line 830.
--
Elimar
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (990, 'unstable'), (500, 'testing'), (100, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 4.14.71-toy-lxtec-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8),
LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
Versions of packages spamassassin depends on:
ii adduser 3.118
ii curl7.62.0-1
ii init-system-helpers 1.55
ii libhtml-parser-perl 3.72-3+b3
ii libhttp-date-perl 6.02-1
ii libmail-dkim-perl 0.53-1
ii libnet-dns-perl 1.17-1
ii libnetaddr-ip-perl 4.079+dfsg-1+b3
ii libsocket6-perl 0.29-1+b1
ii libsys-hostname-long-perl 1.5-1
ii libwww-perl 6.36-1
ii lsb-base9.20170808
ii perl [libarchive-tar-perl] 5.28.0-3
ii w3m 0.5.3-36+b1
Versions of packages spamassassin recommends:
ii gnupg 2.2.10-3
ii libio-socket-inet6-perl2.72-2
ii libmail-spf-perl 2.9.0-4
ii perl [libsys-syslog-perl] 5.28.0-3
pn sa-compile
ii spamc 3.4.2-1
Versions of packages spamassassin suggests:
ii libdbi-perl 1.642-1+b1
pn libencode-detect-perl
pn libgeo-ip-perl
ii libio-socket-ssl-perl 2.060-3
pn libnet-patricia-perl
ii perl [libcompress-zlib-perl] 5.28.0-3
ii pyzor 1:1.0.0-3
ii razor 1:2.85-4.2+b5
-- Configuration Files:
/etc/default/spamassassin changed [not included]
-- no debconf information
