Package: git-buildpackage
Version: 0.9.10+nmu1
Severity: normal

Hi,

The documentation claims that the -Pq suffixes are optional but
they appear not to be. For example, writing this new commit message
on the exported branch:

  Subject line here

  Gbp: Name target-filename.patch

… when exported yields a "0001-Subject-line-here.patch" file
instead of "target-filename.patch". The code in question appears to
be:

        cmds = {'topic': topic} if topic else {}
        # Parse 'Gbp: ' style commands
        (cmds_gbp, info['body']) = parse_gbp_commands(info, 'gbp',
                                                      ('ignore'),
                                                      ('topic', 'name'),
                                                      ('topic', 'name'))
        cmds.update(cmds)
        # Parse 'Gbp-Pq: ' style commands
        (cmds_gbp_pq, info['body']) = parse_gbp_commands(info,
                                                         'gbp-pq',
                                                         ('ignore'),
                                                         ('topic', 'name'),
                                                         ('topic', 'name'))
        cmds.update(cmds_gbp_pq)


(Are we, perhaps not finding the 'Name' in the second call to
`parse_gbp_commands` and then removing the name from `cmds`?)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-

Reply via email to