On Fri, Aug 02, 2019 at 05:15:21PM +0000, Verma, Vishal L wrote: > On Thu, 2019-08-01 at 03:00 +0200, Adam Borowski wrote: > > util/json.c uses libndctl symbols, and is included by daxctl. These > > functions should then get pruned as unused, but on some platforms the > > toolchain fails to do so.
> > this has been requested in https://bugs.debian.org/914348 > Thanks for the report and the patch - however, historically, we've > avoided linking from daxctl to libndctl. > > I think we can still avoid this by moving the libndctl users in > util/json.c and util/filter.c into respective ndctl/util/ files. > > The same goes for libdaxctl users in those files - they move into > daxctl/util/ > > I think that would be a cleaner approach, and I can take a shot at > making the split next week, however we're close to a v66 release, and it > will have to be after that happens. > > Perhaps the debian package can temporarily carry your patch for the > archs that fail? Sounds like a plan. CCing the bug. Breno: could you please take this patch for v65 or v66, until it gets done a better (but more intrusive) way? 喵! -- ⢀⣴⠾⠻⢶⣦⠀ Latin: meow 4 characters, 4 columns, 4 bytes ⣾⠁⢠⠒⠀⣿⡁ Greek: μεου 4 characters, 4 columns, 8 bytes ⢿⡄⠘⠷⠚⠋ Runes: ᛗᛖᛟᚹ 4 characters, 4 columns, 12 bytes ⠈⠳⣄⠀⠀⠀⠀ Chinese: 喵 1 character, 2 columns, 3 bytes <-- best!
