Bug#914384: sysstat: CVE-2018-19416: the remap_struct function in sa_common.c has an out-of-bounds read during a memmove call

2019-02-20 Thread Moritz Mühlenhoff 
On Thu, Nov 22, 2018 at 09:35:39PM +0100, Salvatore Bonaccorso wrote:
> Source: sysstat
> Version: 12.0.1-1
> Severity: important
> Tags: security upstream
> Forwarded: https://github.com/sysstat/sysstat/issues/196
> 
> Hi,
> 
> The following vulnerability was published for sysstat.
> 
> CVE-2018-19416[0]:
> | An issue was discovered in sysstat 12.1.1. The remap_struct function in
> | sa_common.c has an out-of-bounds read during a memmove call, as
> | demonstrated by sadf.

Fixed 
https://github.com/sysstat/sysstat/commit/fbc691eaaa10d0bcea6741d5a223dc3906106548

Can we please get that fixed for buster?

Cheers,
Moritz

Bug#914384: sysstat: CVE-2018-19416: the remap_struct function in sa_common.c has an out-of-bounds read during a memmove call

2018-11-24 Thread Markus Koschany 
Hi,

On Thu, 22 Nov 2018 21:35:39 +0100 Salvatore Bonaccorso
 wrote:
> Source: sysstat
> Version: 12.0.1-1
> Severity: important
> Tags: security upstream
> Forwarded: https://github.com/sysstat/sysstat/issues/196
> 
> Hi,
> 
> The following vulnerability was published for sysstat.
[...]

I can't reproduce the issue on Jessie. By executing the POC with sadf
stack_oob I get

Invalid system activity file: stack_oob
File created by sar/sadc from sysstat version 48.48.48.48
Current sysstat version can no longer read the format of this file (0x2175)

Looking closer at the affected source code I see that the vulnerable
function remap_struct was first introduced on 22.9.2017.

https://github.com/sysstat/sysstat/commit/65ac30359e49ee717397e39950d7c24a6610d57c#diff-cccb0877d1539c562536a98e0d17428f

Hence I think Jessie is not affected. If I am correct then Stretch
should be safe as well, double-checking that would be appreciated.

Regards,

Markus



signature.asc
Description: OpenPGP digital signature

Bug#914384: sysstat: CVE-2018-19416: the remap_struct function in sa_common.c has an out-of-bounds read during a memmove call

2018-11-22 Thread Salvatore Bonaccorso 
Source: sysstat
Version: 12.0.1-1
Severity: important
Tags: security upstream
Forwarded: https://github.com/sysstat/sysstat/issues/196

Hi,

The following vulnerability was published for sysstat.

CVE-2018-19416[0]:
| An issue was discovered in sysstat 12.1.1. The remap_struct function in
| sa_common.c has an out-of-bounds read during a memmove call, as
| demonstrated by sadf.

The poc to verify a fix (base64 encoded here):

ltV1ITAwMDBIAQAAMDAwMAEBMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwAgAAADAwMDkA
AAAC/wAkEDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMAAwMDAwMDAwMDAwMDAwMDAwMDAwMDABMDAwMDAwMAAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw

If you fix the vulnerability please also make sure to include the
CVE (Common Vulnerabilities & Exposures) id in your changelog entry.

For further information see:

[0] https://security-tracker.debian.org/tracker/CVE-2018-19416
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-19416
[1] https://github.com/sysstat/sysstat/issues/196
[2] https://bugzilla.novell.com/show_bug.cgi?id=1117001

Please adjust the affected versions in the BTS as needed.

Regards,
Salvatore