Source: cutesdr
Version: 1.20-2
Severity: serious
Justification: policy 4.6
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

cutesdr fails to cross build from source, because its builds two cmake
projects (one via dh_auto_foo and then the siqs directory explicitly in
override_dh_auto_install) and the latter invocation lacks cross flags.
The easiest way of fixing that is using dh_auto_configure. Doing so is
sufficient to make cutesdr cross buildable. Please consider applying the
attached patch.

I also noticed that cutesdr chains build commands with ";". Doing so is
prohibited by Debian policy section 4.6, thus satisfying serious
severity. My patch fixes this issue as well. Please lower the severity
of this bug if you fix the policy violation independently, but I think
it would be least effort to simply use the patch thus filing only one
bug.

Helmut
diff --minimal -Nru cutesdr-1.20/debian/changelog cutesdr-1.20/debian/changelog
--- cutesdr-1.20/debian/changelog       2018-08-29 06:18:15.000000000 +0200
+++ cutesdr-1.20/debian/changelog       2019-01-02 22:07:05.000000000 +0100
@@ -1,3 +1,11 @@
+cutesdr (1.20-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Let dh_auto_configure pass cross flags to cmake. (Closes: #-1)
+  * Propagate errors from cmake (policy 4.6).
+
+ -- Helmut Grohne <hel...@subdivi.de>  Wed, 02 Jan 2019 22:07:05 +0100
+
 cutesdr (1.20-2) unstable; urgency=medium
 
   * update to svn r75, builds with qt5.11. (Closes:#907226)
diff --minimal -Nru cutesdr-1.20/debian/rules cutesdr-1.20/debian/rules
--- cutesdr-1.20/debian/rules   2018-05-23 05:01:12.000000000 +0200
+++ cutesdr-1.20/debian/rules   2019-01-02 22:07:05.000000000 +0100
@@ -8,7 +8,8 @@
 override_dh_auto_install:
        dh_auto_install
        mkdir siqsbuild
-       (cd siqsbuild ; cmake ../siqs ; make)
+       dh_auto_configure --builddirectory=siqsbuild --sourcedirectory=siqs
+       dh_auto_build --builddirectory=siqsbuild
        cp siqsbuild/siqs_ftdi debian/cutesdr/usr/bin/siqs_ftdi
        rm -rf siqsbuild
        cp CuteSdr debian/cutesdr/usr/bin/CuteSdr

Reply via email to