Bug#918502: golang-github-opencontainers-runtime-tools: autopkgtest needs update for new version of golang-github-hashicorp-go-multierror
I pushed some changes to Salsa: * New upstream version 0.8.0+dfsg * Update patches * Add patch to build against hashicorp-multierror 1.0 Can someone upload this package, as I'm just DM and I don't have permission for that? I CC Dmitry as he's the original author of the package, but really, any DD from the Go team should feel free to tag a release and upload. For more context: There was very little changes upstream between 0.7 to 0.8, and no changes at all in the vendor tree, so the update was rather trivial. Additionally, we actually don't use this package (yet) to build any other package, so nothing can possibly break. Thanks, Arnaud
Bug#918502: golang-github-opencontainers-runtime-tools: autopkgtest needs update for new version of golang-github-hashicorp-go-multierror
Thanks for the report, I'm looking into that. The FTBFS is not fixed by updating opencontainers-runtime-tools to the latest version (0.8). Actually, the issue is that opencontainers-runtime-tools is using an outdated vendored copy of hashicorp-go-multierror. It doesn't build out of the box against the latest version of multierror. I'm cooking a little patch for that to work.
Bug#918502: golang-github-opencontainers-runtime-tools: autopkgtest needs update for new version of golang-github-hashicorp-go-multierror
Control: severity -1 serious On Sun, Jan 06, 2019 at 08:43:40PM +0100, Paul Gevers wrote: >... > --- FAIL: TestCheckMandatoryFields (0.00s) > --- FAIL: > TestCheckMandatoryFields/1_error_occurred:__*_'Spec.Version'_should_not_be_empty > (0.00s) > validate_test.go:759: > Error Trace:validate_test.go:759 > Error: Not equal: > expected: "1 error occurred:\n\n* > 'Spec.Version' should not be empty" > actual : "1 error occurred:\n\t* > 'Spec.Version' should not be empty\n\n" > > Diff: > --- Expected > +++ Actual > @@ -1,3 +1,4 @@ >1 error occurred: > + * 'Spec.Version' should not be empty > > -* 'Spec.Version' should not be empty > + > Test: > TestCheckMandatoryFields/1_error_occurred:__*_'Spec.Version'_should_not_be_empty > --- FAIL: > TestCheckMandatoryFields/1_error_occurred:__*_Spec_can't_be_nil (0.00s) > validate_test.go:759: > Error Trace:validate_test.go:759 > Error: Not equal: > expected: "1 error occurred:\n\n* Spec can't > be nil" > actual : "1 error occurred:\n\t* Spec can't > be nil\n\n" > > Diff: > --- Expected > +++ Actual > @@ -1,3 +1,4 @@ >1 error occurred: > + * Spec can't be nil > > -* Spec can't be nil > + > Test: > TestCheckMandatoryFields/1_error_occurred:__*_Spec_can't_be_nil > --- PASS: TestCheckMandatoryFields/#00 (0.00s) > --- FAIL: > TestCheckMandatoryFields/1_error_occurred:__*_'Root.Path'_should_not_be_empty > (0.00s) > validate_test.go:759: > Error Trace:validate_test.go:759 > Error: Not equal: > expected: "1 error occurred:\n\n* 'Root.Path' > should not be empty" > actual : "1 error occurred:\n\t* 'Root.Path' > should not be empty\n\n" > > Diff: > --- Expected > +++ Actual > @@ -1,3 +1,4 @@ >1 error occurred: > + * 'Root.Path' should not be empty > > -* 'Root.Path' should not be empty > + > Test: > TestCheckMandatoryFields/1_error_occurred:__*_'Root.Path'_should_not_be_empty This is also a FTBFS: https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/golang-github-opencontainers-runtime-tools.html cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
Bug#918502: golang-github-opencontainers-runtime-tools: autopkgtest needs update for new version of golang-github-hashicorp-go-multierror
Source: golang-github-opencontainers-runtime-tools Version: 0.7.0+dfsg-1 User: debian...@lists.debian.org Usertags: needs-update Control: affects -1 src:golang-github-hashicorp-go-multierror Dear maintainers, With a recent upload of golang-github-hashicorp-go-multierror the autopkgtest of golang-github-opencontainers-runtime-tools fails in testing when that autopkgtest is run with the binary packages of golang-github-hashicorp-go-multierror from unstable. It passes when run with only packages from testing. In tabular form: passfail golang-github-hashicorp-go-multierror from testing1.0.0-1 golang-github-opencontainers-runtime-tools from testing0.7.0+dfsg-1 all others from testingfrom testing I copied some of the output at the bottom of this report. Looking at the error, it seems you just need to update the reference. Currently this regression is contributing to the delay of the migration of golang-github-hashicorp-go-multierror to testing [1]. Of course, golang-github-hashicorp-go-multierror shouldn't just break your autopkgtest (or even worse, your package), but it seems to me that the change in golang-github-hashicorp-go-multierror was intended and your package needs to update to the new situation. If needed, please change the bug's severity. If this is a real problem in your package (and not only in your autopkgtest), the right binary package(s) from golang-github-hashicorp-go-multierror should really add a versioned Breaks on the unfixed version of (one of your) package(s). Note: the Breaks is nice even if the issue is only in the autopkgtest as it helps the migration software to figure out the right versions to combine in the tests. More information about this bug and the reason for filing it can be found on https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation Paul [0] You can see what packages were added from the second line of the log file quoted below. The migration software adds source package from unstable to the list if they are needed to install packages from golang-github-hashicorp-go-multierror/1.0.0-1. I.e. due to versioned dependencies or breaks/conflicts. [1] https://qa.debian.org/excuses.php?package=golang-github-hashicorp-go-multierror https://ci.debian.net/data/autopkgtest/testing/amd64/g/golang-github-opencontainers-runtime-tools/1651937/log.gz --- FAIL: TestCheckMandatoryFields (0.00s) --- FAIL: TestCheckMandatoryFields/1_error_occurred:__*_'Spec.Version'_should_not_be_empty (0.00s) validate_test.go:759: Error Trace:validate_test.go:759 Error: Not equal: expected: "1 error occurred:\n\n* 'Spec.Version' should not be empty" actual : "1 error occurred:\n\t* 'Spec.Version' should not be empty\n\n" Diff: --- Expected +++ Actual @@ -1,3 +1,4 @@ 1 error occurred: + * 'Spec.Version' should not be empty -* 'Spec.Version' should not be empty + Test: TestCheckMandatoryFields/1_error_occurred:__*_'Spec.Version'_should_not_be_empty --- FAIL: TestCheckMandatoryFields/1_error_occurred:__*_Spec_can't_be_nil (0.00s) validate_test.go:759: Error Trace:validate_test.go:759 Error: Not equal: expected: "1 error occurred:\n\n* Spec can't be nil" actual : "1 error occurred:\n\t* Spec can't be nil\n\n" Diff: --- Expected +++ Actual @@ -1,3 +1,4 @@ 1 error occurred: + * Spec can't be nil -* Spec can't be nil + Test: TestCheckMandatoryFields/1_error_occurred:__*_Spec_can't_be_nil --- PASS: TestCheckMandatoryFields/#00 (0.00s) --- FAIL: TestCheckMandatoryFields/1_error_occurred:__*_'Root.Path'_should_not_be_empty (0.00s) validate_test.go:759: Error Trace:validate_test.go:759 Error: Not equal: expected: "1 error occurred:\n\n* 'Root.Path' should not be empty" actual : "1 error occurred:\n\t* 'Root.Path' should not be empty\n\n" Diff: --- Expected
