Bug#920767: e2fsprogs: [REGRESSION] e4defrag version 1.44.5-1 segfaults on an armel system (but 1.44.4-2 doesn't)

[Bernhard Übelacker]

Hello all,

> Note that other declarations changed between 1.44.4 and 1.44.5 so
> there may be other similar problems.

This looks related to upstream change to take care
of debian bug #99. This change looks like it got
reverted again.

https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/log/misc/e4defrag.c
https://bugs.debian.org/99


> Something like printf("...%d...%s...", long_long_int, pointer_to_char)
> could lead to a segfault on armel, though usually there would be a
> conspicuous warning from the compiler.

These are really visible here:
https://buildd.debian.org/status/fetch.php?pkg=e2fsprogs=armel=1.44.5-1=1544943866=0

../../../misc/e4defrag.c:1606:29: warning: format '%u' expects argument of type 
'unsigned int', but argument 2 has type 'long long unsigned int' [-Wformat=]
   printf("\033[79;0H\033[K[%u/%u]%s:\t%3d%%",
~^
%llu
defraged_file_count, total_count, file, 100);
~~~   

Kind regards,
Bernhard

Bug#920767: e2fsprogs: [REGRESSION] e4defrag version 1.44.5-1 segfaults on an armel system (but 1.44.4-2 doesn't)

[Edmund Grimley Evans]

grep defraged_file_count `find * -type f`

reveals suspicious discrepency between declaration and format strings:

misc/e4defrag.c:static unsigned long longdefraged_file_count;
misc/e4defrag.c:"  extents: %d -> %d\n", defraged_file_count,
misc/e4defrag.c:"  extents: %d -> %d\n", defraged_file_count,
misc/e4defrag.c:printf("[%u/%u]", defraged_file_count, total_count);
misc/e4defrag.c:printf("[%u/%u]", defraged_file_count, total_count);

Note that other declarations changed between 1.44.4 and 1.44.5 so
there may be other similar problems.

Something like printf("...%d...%s...", long_long_int, pointer_to_char)
could lead to a segfault on armel, though usually there would be a
conspicuous warning from the compiler.

Bug#920767: e2fsprogs: [REGRESSION] e4defrag version 1.44.5-1 segfaults on an armel system (but 1.44.4-2 doesn't)

[Rogério Brito]

Package: e2fsprogs
Version: 1.44.5-1
Severity: important
X-Debbugs-CC: debian-...@lists.debian.org

Dear Ted,

I'm having a problem when running the version of e4defrag from buster on my
armel system (it's a KuroBox Pro running as a NAS box for my very small
local network).

When running e4defrag on such system, I get 100% of segfaults when I run a
command as simple as `e4defrag -v .` (both as root or as a regular user) in
whatever directory that I want.

I posted a long description of the command and running the e4defrag under
gdb at:

https://lists.debian.org/debian-arm/2019/01/msg00034.html

At the time I wrote the post above, I hadn't yet had the opportunity to
distill what I know today, which is to hunt down a working version of
e4defrag. Today, I know that reverting the packages

* e2fsprogs  from 1.44.4-2 to 1.44.5-1
* libext2fs2 from 1.44.4-2 to 1.44.5-1

(and nothing else) makes the problem go away.

If you want me to provide any further detail, please let me know and I will
try my best to provide what you want (I may take a little time because
compiling programs on the armel is a bit slow, but I will do my best
anyway).


Thanks in advance,

Rogério Brito.


-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing'), (150, 'unstable'), (100, 'experimental')
Architecture: armel (armv5tel)

Kernel: Linux 4.19.0-1-marvell
Locale: LANG=en_US.utf-8, LC_CTYPE=pt_BR.utf-8 (charmap=UTF-8), 
LANGUAGE=en_US.utf-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages e2fsprogs depends on:
ii  libblkid12.33.1-0.1
ii  libc62.28-5
ii  libcom-err2  1.44.5-1
ii  libext2fs2   1.44.5-1
ii  libss2   1.44.5-1
ii  libuuid1 2.33.1-0.1

Versions of packages e2fsprogs recommends:
pn  e2fsprogs-l10n  

Versions of packages e2fsprogs suggests:
pn  e2fsck-static  
pn  fuse2fs
pn  gpart  
pn  parted 

-- no debconf information


-- 
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br