Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any
Le 17/03/2019 à 18:15, Svante Signell a écrit : On Tue, 2019-03-12 at 13:37 +0100, Sylvestre Ledru wrote: Hello, Le 03/02/2019 à 15:28, Svante Signell a écrit : I will submit these patches to upstream too, in due time. Do you have an update about that? This is hard to maintain these patches (rebase, breakage[1], etc) I will probably disable these patches soon for snapshot if they aren't merged upstream. Sorry, Sylvestre [1] the most recent is: /build/llvm-toolchain-snapshot- 9~svn355904/tools/clang/lib/Driver/ToolChains/KFreeBSD.cpp: In member function 'virtual clang::SanitizerMask clang::driver::toolchains::kFreeBSD::getSupportedSanitizers() const': /build/llvm-toolchain-snapshot- 9~svn355904/tools/clang/lib/Driver/ToolChains/KFreeBSD.cpp:449:27: error: 'Efficiency' is not a member of 'clang::SanitizerKind' Res |= SanitizerKind::Efficiency; Hello Sylvestre, should I submit patches upstream for -7, -8 or snapshot-9? Are you working with all versions on Debian at the same time, which one will be in Buster? Just 9 (trunk upstream), the other aren't moving enough for these patches to be a pain :) 6 and 7 will be in buster. 8 will arrive too late. S
Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any
On Tue, 2019-03-12 at 13:37 +0100, Sylvestre Ledru wrote: > Hello, > > Le 03/02/2019 à 15:28, Svante Signell a écrit : > > > I will submit these patches to upstream too, in due time. > Do you have an update about that? > > This is hard to maintain these patches (rebase, breakage[1], etc) > > I will probably disable these patches soon for snapshot if they > aren't merged upstream. > > Sorry, > Sylvestre > > [1] the most recent is: > /build/llvm-toolchain-snapshot- > 9~svn355904/tools/clang/lib/Driver/ToolChains/KFreeBSD.cpp: In member > function 'virtual clang::SanitizerMask > clang::driver::toolchains::kFreeBSD::getSupportedSanitizers() const': > /build/llvm-toolchain-snapshot- > 9~svn355904/tools/clang/lib/Driver/ToolChains/KFreeBSD.cpp:449:27: > error: 'Efficiency' is not a member of 'clang::SanitizerKind' > Res |= SanitizerKind::Efficiency; Hello Sylvestre, should I submit patches upstream for -7, -8 or snapshot-9? Are you working with all versions on Debian at the same time, which one will be in Buster? Thanks!
Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any
Hello, Le 03/02/2019 à 15:28, Svante Signell a écrit : I will submit these patches to upstream too, in due time. Do you have an update about that? This is hard to maintain these patches (rebase, breakage[1], etc) I will probably disable these patches soon for snapshot if they aren't merged upstream. Sorry, Sylvestre [1] the most recent is: /build/llvm-toolchain-snapshot-9~svn355904/tools/clang/lib/Driver/ToolChains/KFreeBSD.cpp: In member function 'virtual clang::SanitizerMask clang::driver::toolchains::kFreeBSD::getSupportedSanitizers() const': /build/llvm-toolchain-snapshot-9~svn355904/tools/clang/lib/Driver/ToolChains/KFreeBSD.cpp:449:27: error: 'Efficiency' is not a member of 'clang::SanitizerKind' Res |= SanitizerKind::Efficiency; ^~
Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any
On Tue, 2019-02-05 at 12:12 +0100, Sylvestre Ledru wrote:
> Le 05/02/2019 à 12:05, Svante Signell a écrit :
> > reopen 921246
> > found 921246 1:7.0.1-6
> > thanks
> >
> > On Mon, 2019-02-04 at 09:02 +0100, Sylvestre Ledru wrote:
> > > When you work on pushing your changes to upstream, please note
> > > that
> > > I rebased your work :)
> > >
> > > https://salsa.debian.org/pkg-llvm-team/llvmtoolchain/tree/8/debian/patches/kfreebsd
> >
> > Hello again,
> >
> > The patches had one error making the builds still failing: The
> > binary
> > format is elf_{i386,x86_64}_fbsd, not the same as on e.g. Linux and
> > Hurd. (I did not know that). The updated patch kfreebsd-triple-
> > clang.diff reflects that change. (changed file is
> > clang/lib/Driver/ToolChains/Gnu.cpp)
> >
> Could you please do a MR
> https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/tree/7/ ?
How would I do that? I don't even have an account on Debian Salsa
Gitlab.
Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any
Le 03/02/2019 à 23:55, Svante Signell a écrit :
On Sun, 2019-02-03 at 23:39 +0100, Sylvestre Ledru wrote:
Le 03/02/2019 à 17:21, Sylvestre Ledru a écrit :
Le 03/02/2019 à 15:28, Svante Signell a écrit :
Source: llvm-toolchain-7
Version: 7_7.0.1-4
Severity: important
Tags: ftbfs, patch
User: debian-k...@lists.debian.org
Usertags: kfreebsd
Hello,
Currently llvm-toolchain-7 FTBFS on GNU/kFreeBSD dues to a missing
port to that
architecture. Attached are 14 patches...
clang_lib_Basic_Targets.diff
CMakeLists.txt.diff
compiler-rt_lib.diff
include_llvm_ADT_Triple.h.diff
kfreebsd-libcxx-threads-detection.diff
kfreebsd-openmp.diff
kfreebsd-threads-build.diff
kfreebsd-triple-clang.diff
kfreebsd-triple.diff
lib_Support.diff
lib_Target_X86.diff
lldb_source_Host_freebsd_Host.cpp.diff
lldb_source_Plugins_Process_FreeBSD.diff
tools_llvm-shlib_CMakeLists.txt.diff
Additionally, the install file for liblldb-7 needs a separate file:
liblldb-
7.install.kfreebsd. Adding [!kfreebsd-any] to the last row of
liblldb-7.install
(or liblldb-X.Y.install.in) did not work.
I will submit these patches to upstream too, in due time.
Wahou, impressive!
Don't hesitate to submit a MR next time!
S
I tried to build it on amd64 but it fails with
/build/llvm-toolchain-7-7.0.1/projects/compiler-
rt/lib/fuzzer/FuzzerUtilPosix.cpp:122:28:
error:
use of undeclared identifier 'LIBFUZZER_KFREEBSD'
LIBFUZZER_OPENBSD || LIBFUZZER_KFREEBSD) {
Index: llvm-toolchain-7-7.0.1/compiler-rt/lib/fuzzer/FuzzerDefs.h
===
--- llvm-toolchain-7-7.0.1.orig/compiler-rt/lib/fuzzer/FuzzerDefs.h
+++ llvm-toolchain-7-7.0.1/compiler-rt/lib/fuzzer/FuzzerDefs.h
@@ -28,6 +28,7 @@
#define LIBFUZZER_LINUX 1
#define LIBFUZZER_NETBSD 0
#define LIBFUZZER_FREEBSD 0
+#define LIBFUZZER_KFREEBSD 0
#define LIBFUZZER_OPENBSD 0
#define LIBFUZZER_WINDOWS 0
#elif __APPLE__
It fixed it (and it has to be replicated for the other archs)
Sorry, I was a little sloppy defining LIBFUZZER_KFREEBSD. Do you want an updated
patch?
No need, I fixed it, thanks!
S
Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any
Le 03/02/2019 à 23:55, Svante Signell a écrit : On Sun, 2019-02-03 at 23:39 +0100, Sylvestre Ledru wrote: Le 03/02/2019 à 17:21, Sylvestre Ledru a écrit : Le 03/02/2019 à 15:28, Svante Signell a écrit : Source: llvm-toolchain-7 Version: 7_7.0.1-4 Severity: important Tags: ftbfs, patch User: debian-k...@lists.debian.org Usertags: kfreebsd Hello, Currently llvm-toolchain-7 FTBFS on GNU/kFreeBSD dues to a missing Looks like it wasn't enough: https://buildd.debian.org/status/fetch.php?pkg=llvm-toolchain-7=kfreebsd-amd64=1%3A7.0.1-6=1549244138=0 /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-kfreebsd-gnu/8/../../../x86_64-kfreebsd-gnu/libc.so when searching for -lc /usr/bin/ld: /usr/lib/gcc/x86_64-kfreebsd-gnu/8/../../../x86_64-kfreebsd-gnu/libc.a(cxa_atexit.o): relocation R_X86_64_32 against `.bss' can not be used when making a shared object; recompile with -fPIC This might be caused by the stage2 build. I had similar issues that some flags were not passed from stage1 to stage2 I fixed that https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/blob/7/debian/rules#L355 but this might be a different issue! Cheers, S
Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any
On Sun, 2019-02-03 at 23:39 +0100, Sylvestre Ledru wrote:
> Le 03/02/2019 à 17:21, Sylvestre Ledru a écrit :
> > Le 03/02/2019 à 15:28, Svante Signell a écrit :
> > > Source: llvm-toolchain-7
> > > Version: 7_7.0.1-4
> > > Severity: important
> > > Tags: ftbfs, patch
> > > User: debian-k...@lists.debian.org
> > > Usertags: kfreebsd
> > >
> > > Hello,
> > >
> > > Currently llvm-toolchain-7 FTBFS on GNU/kFreeBSD dues to a missing
> > > port to that
> > > architecture. Attached are 14 patches...
> > > clang_lib_Basic_Targets.diff
> > > CMakeLists.txt.diff
> > > compiler-rt_lib.diff
> > > include_llvm_ADT_Triple.h.diff
> > > kfreebsd-libcxx-threads-detection.diff
> > > kfreebsd-openmp.diff
> > > kfreebsd-threads-build.diff
> > > kfreebsd-triple-clang.diff
> > > kfreebsd-triple.diff
> > > lib_Support.diff
> > > lib_Target_X86.diff
> > > lldb_source_Host_freebsd_Host.cpp.diff
> > > lldb_source_Plugins_Process_FreeBSD.diff
> > > tools_llvm-shlib_CMakeLists.txt.diff
> > >
> > > Additionally, the install file for liblldb-7 needs a separate file:
> > > liblldb-
> > > 7.install.kfreebsd. Adding [!kfreebsd-any] to the last row of
> > > liblldb-7.install
> > > (or liblldb-X.Y.install.in) did not work.
> > >
> > > I will submit these patches to upstream too, in due time.
> >
> > Wahou, impressive!
> >
> > Don't hesitate to submit a MR next time!
> >
> > S
> >
> I tried to build it on amd64 but it fails with
>
> /build/llvm-toolchain-7-7.0.1/projects/compiler-
> rt/lib/fuzzer/FuzzerUtilPosix.cpp:122:28:
> error:
>use of undeclared identifier 'LIBFUZZER_KFREEBSD'
>LIBFUZZER_OPENBSD || LIBFUZZER_KFREEBSD) {
>
>
> Index: llvm-toolchain-7-7.0.1/compiler-rt/lib/fuzzer/FuzzerDefs.h
> ===
> --- llvm-toolchain-7-7.0.1.orig/compiler-rt/lib/fuzzer/FuzzerDefs.h
> +++ llvm-toolchain-7-7.0.1/compiler-rt/lib/fuzzer/FuzzerDefs.h
> @@ -28,6 +28,7 @@
> #define LIBFUZZER_LINUX 1
> #define LIBFUZZER_NETBSD 0
> #define LIBFUZZER_FREEBSD 0
> +#define LIBFUZZER_KFREEBSD 0
> #define LIBFUZZER_OPENBSD 0
> #define LIBFUZZER_WINDOWS 0
> #elif __APPLE__
>
>
> It fixed it (and it has to be replicated for the other archs)
Sorry, I was a little sloppy defining LIBFUZZER_KFREEBSD. Do you want an updated
patch?
Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any
Le 03/02/2019 à 17:21, Sylvestre Ledru a écrit :
Le 03/02/2019 à 15:28, Svante Signell a écrit :
Source: llvm-toolchain-7
Version: 7_7.0.1-4
Severity: important
Tags: ftbfs, patch
User: debian-k...@lists.debian.org
Usertags: kfreebsd
Hello,
Currently llvm-toolchain-7 FTBFS on GNU/kFreeBSD dues to a missing
port to that
architecture. Attached are 14 patches...
clang_lib_Basic_Targets.diff
CMakeLists.txt.diff
compiler-rt_lib.diff
include_llvm_ADT_Triple.h.diff
kfreebsd-libcxx-threads-detection.diff
kfreebsd-openmp.diff
kfreebsd-threads-build.diff
kfreebsd-triple-clang.diff
kfreebsd-triple.diff
lib_Support.diff
lib_Target_X86.diff
lldb_source_Host_freebsd_Host.cpp.diff
lldb_source_Plugins_Process_FreeBSD.diff
tools_llvm-shlib_CMakeLists.txt.diff
Additionally, the install file for liblldb-7 needs a separate file:
liblldb-
7.install.kfreebsd. Adding [!kfreebsd-any] to the last row of
liblldb-7.install
(or liblldb-X.Y.install.in) did not work.
I will submit these patches to upstream too, in due time.
Wahou, impressive!
Don't hesitate to submit a MR next time!
S
I tried to build it on amd64 but it fails with
/build/llvm-toolchain-7-7.0.1/projects/compiler-rt/lib/fuzzer/FuzzerUtilPosix.cpp:122:28:
error:
use of undeclared identifier 'LIBFUZZER_KFREEBSD'
LIBFUZZER_OPENBSD || LIBFUZZER_KFREEBSD) {
Index: llvm-toolchain-7-7.0.1/compiler-rt/lib/fuzzer/FuzzerDefs.h
===
--- llvm-toolchain-7-7.0.1.orig/compiler-rt/lib/fuzzer/FuzzerDefs.h
+++ llvm-toolchain-7-7.0.1/compiler-rt/lib/fuzzer/FuzzerDefs.h
@@ -28,6 +28,7 @@
#define LIBFUZZER_LINUX 1
#define LIBFUZZER_NETBSD 0
#define LIBFUZZER_FREEBSD 0
+#define LIBFUZZER_KFREEBSD 0
#define LIBFUZZER_OPENBSD 0
#define LIBFUZZER_WINDOWS 0
#elif __APPLE__
It fixed it (and it has to be replicated for the other archs)
Cheers,
S
Bug#921246: llvm-toolchain-7: FTBFS on kfreebsd-any
Le 03/02/2019 à 15:28, Svante Signell a écrit : Source: llvm-toolchain-7 Version: 7_7.0.1-4 Severity: important Tags: ftbfs, patch User: debian-k...@lists.debian.org Usertags: kfreebsd Hello, Currently llvm-toolchain-7 FTBFS on GNU/kFreeBSD dues to a missing port to that architecture. Attached are 14 patches... clang_lib_Basic_Targets.diff CMakeLists.txt.diff compiler-rt_lib.diff include_llvm_ADT_Triple.h.diff kfreebsd-libcxx-threads-detection.diff kfreebsd-openmp.diff kfreebsd-threads-build.diff kfreebsd-triple-clang.diff kfreebsd-triple.diff lib_Support.diff lib_Target_X86.diff lldb_source_Host_freebsd_Host.cpp.diff lldb_source_Plugins_Process_FreeBSD.diff tools_llvm-shlib_CMakeLists.txt.diff Additionally, the install file for liblldb-7 needs a separate file: liblldb- 7.install.kfreebsd. Adding [!kfreebsd-any] to the last row of liblldb-7.install (or liblldb-X.Y.install.in) did not work. I will submit these patches to upstream too, in due time. Wahou, impressive! Don't hesitate to submit a MR next time! S
