Bug#922533: Review of proposed move of /var/log/account to /var/account
Hi, On Wed, 18 Mar 2020, Marcos Fouces wrote: > Any DD available for review and upload this new release. Uploaded! Cheers, -- ⢀⣴⠾⠻⢶⣦⠀ Raphaël Hertzog ⣾⠁⢠⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋The Debian Handbook: https://debian-handbook.info/get/ ⠈⠳⣄ Debian Long Term Support: https://deb.li/LTS
Bug#922533: Review of proposed move of /var/log/account to /var/account
Good! I already uploaded a new release in the git repo: https://salsa.debian.org/pkg-security-team/acct It contains this and other changes. Any DD available for review and upload this new release. Thank you. Greetings Marcos El mié, 18-03-2020 a las 11:33 +, Sergio Gelato escribió: > Thank you for the feedback. I'm quite happy for the change not to > happen. It's certainly less work that way. > > From: Marcos Fouces > Sent: Tuesday, March 17, 2020 18:48 > To: 922...@bugs.debian.org > Cc: Sergio Gelato > Subject: Re: Review of proposed move of /var/log/account to > /var/account > > Hello Sergio > > I am considering the fact that this change could do more harm than > good. The path for pacct* files was changed a long time ago and every > Debian user of acct is aware of it. > > The submiter himself has finally some doubts about it, so i believe > that it is pointless. > > I can't see any good reason to do this. > > I am all for listen to different point of view but i will close this > bug and revert this changes if no good reason arise. > > Greetings, > Marcos
Bug#922533: Review of proposed move of /var/log/account to /var/account
Hello Sergio I am considering the fact that this change could do more harm than good. The path for pacct* files was changed a long time ago and every Debian user of acct is aware of it. The submiter himself has finally some doubts about it, so i believe that it is pointless. I can't see any good reason to do this. I am all for listen to different point of view but i will close this bug and revert this changes if no good reason arise. Greetings, Marcos signature.asc Description: This is a digitally signed message part
Bug#922533: Review of proposed move of /var/log/account to /var/account
I'm looking at the proposed fix for this bug and have a few concerns. I hope they can be addressed before the next upload. 1. What about the possibility that /var/log and /var are different filesystems? The preinst may need some error checking to handle out-of-space conditions from mv, and the administrator needs to be warned in advance about the move (I think this calls at least for a mention in the release notes). Moreover, I'm not convinced that the currently proposed preinst script is idempotent (policy §6.2). How about adding a symbolic link from /var/account to /var/log/account on upgrade instead? 2. What happens if both /var/account and /var/log/account already exist? Is it really appropriate to try and clobber an existing /var/account without consulting the administrator? Again, consider the idempotency requirement. 3. I'm not sure offhand whether process accounting will be turned off while the preinst script is running. (The old prerm in buster only stops the acct service on remove, not on upgrade.) If not, there is a risk that accounting records will be written to the old location during the move. (At the same time, I'd like to keep any gap in process accounting coverage at a minimum; but this is a wish, not a requirement.)
