On Sat, 16 Mar 2019 11:40:16 +0100 Jakub Wilk wrote:
> Mine does it too, unless I'm missing something.
>
> If the first argument wasn't numeric, numargs would be 0, and then the
> "Something is majorly broken" path would be taken.
Ack. Due to #924717 I'm now thinking of a different approach
* Paul Wise , 2019-03-16, 14:34:
I like the idea, but how about the attached patch instead?
I prefer mine because it ensures the first argument is always numeric.
Mine does it too, unless I'm missing something.
If the first argument wasn't numeric, numargs would be 0, and then the
On Fri, 2019-03-15 at 23:46 +0100, Jakub Wilk wrote:
> BTW, what is the uid variable for? It's not used anywhere...
Not sure, it was there in the initial script but was never used.
Anyways, I've removed it in my wip branch:
https://salsa.debian.org/pabs/corekeeper/commits/wip
On Fri, 2019-03-15 at 23:35 +0100, Jakub Wilk wrote:
> I like the idea, but how about the attached patch instead?
I prefer mine because it ensures the first argument is always numeric.
--
bye,
pabs
https://wiki.debian.org/PaulWise
signature.asc
Description: This is a digitally signed
* Jakub Wilk , 2019-03-15, 23:35:
+for arg; do
+ case "$1" in
Ooops, that should be "$arg", not "$1".
BTW, what is the uid variable for? It's not used anywhere...
--
Jakub Wilk
* Paul Wise , 2019-03-15, 12:56:
I decided to just check if the arguments are integers, attached the
patch.
I like the idea, but how about the attached patch instead?
It's less repetitive, the diff is smaller, and it's hopefully slightly
easier to understand.
--
Jakub Wilk
diff --git
On Wed, 13 Mar 2019 16:41:02 +0100 Jakub Wilk wrote:
> We could append or prepend a character to %d to make sure the argument
> won't disappear after %-expansion, for example:
I decided to just check if the arguments are integers, attached the patch.
--
bye,
pabs
* Paul Wise , 2019-03-13, 08:54:
The majorly broken thing is, unfortunately, the Linux kernel. It does
argument splitting only _after_ it expanded the macros.
I think that this is a bug in the Linux kernel that needs to be fixed,
would you mind sending either a bug or a patch for this issue?
Control: tags -1 + patch
On Wed, 13 Mar 2019 08:54:26 +0800 Paul Wise wrote:
> Then the code will simply check for -- in $2 and $3 instead of checking
> for the number of arguments and bundle the remaining arguments into the
> core file name.
I've attached the updated dump script and patch,
On Tue, 2019-03-12 at 15:50 +0100, Jakub Wilk wrote:
> The majorly broken thing is, unfortunately, the Linux kernel.
> It does argument splitting only _after_ it expanded the macros.
I think that this is a bug in the Linux kernel that needs to be fixed,
would you mind sending either a bug or a
10 matches
Mail list logo
