Bug#927958: [pre-a] unblock: utf8proc/2.3.0-1
control: tags -1 -moreinfo Hi Niels, utf8proc 2.3.0-1 has been successfully built by all architectures: https://buildd.debian.org/status/package.php?p=utf8proc it should be ready to be unblocked. On Sat, Apr 27, 2019 at 06:58:00AM +, Niels Thykier wrote: > Please go ahead with the proposed changes and remove the moreinfo tag > once it is in unstable and ready to be unblocked. > > Thanks, > ~Niels
Bug#927958: [pre-a] unblock: utf8proc/2.3.0-1
Control: tags -1 moreinfo confirmed Mo Zhou: > Hi, > > Here are some incremental updates to 2.3.0-1 following the last mail: > > + * Patch: update unicode-data version strings to 12.1.0 > > Upstream code hard-coded unicode-data version in the code. I need to > patch those string literals. > > + * Patch: Upstream didn't bump minor version in build system and header. > > Upstream forgot to bump "MINOR" from 2 to 3 in the build system. > > + * Install the newly-added pkgconfig file. (Closes: #927260) > > a very simple pkg-config file. > > On Sat, Apr 27, 2019 at 02:38:44AM +, Mo Zhou wrote: >> control: tags -1 -moreinfo >> >> Hi, >> >> Debdiff has been attached. The patch is enormously large (3MB) but >> 99.9% of the content is automatically generated from unicode-data. >> See my extremely detailed comments to diffstat below: >> >> [...] Thanks for this. :) Please go ahead with the proposed changes and remove the moreinfo tag once it is in unstable and ready to be unblocked. Thanks, ~Niels
Bug#927958: [pre-a] unblock: utf8proc/2.3.0-1
Hi,
Here are some incremental updates to 2.3.0-1 following the last mail:
+ * Patch: update unicode-data version strings to 12.1.0
Upstream code hard-coded unicode-data version in the code. I need to
patch those string literals.
+ * Patch: Upstream didn't bump minor version in build system and header.
Upstream forgot to bump "MINOR" from 2 to 3 in the build system.
+ * Install the newly-added pkgconfig file. (Closes: #927260)
a very simple pkg-config file.
On Sat, Apr 27, 2019 at 02:38:44AM +, Mo Zhou wrote:
> control: tags -1 -moreinfo
>
> Hi,
>
> Debdiff has been attached. The patch is enormously large (3MB) but
> 99.9% of the content is automatically generated from unicode-data.
> See my extremely detailed comments to diffstat below:
>
> On Fri, Apr 26, 2019 at 06:58:00PM +, Niels Thykier wrote:
> > Please include a full debdiff of the changes. The link to a master
> > branch with no clear marking of start/end commits makes it too time
> > consuming for us to evaluate the request.
>
> Dch:
> * New upstream version 2.3.0
> * Bump unicode-data requirement to (>= 12.1) && (<< 12.2).
> * Refresh use-unicode-data.patch; Remove pass-hardening-flags.patch
> (merged).
> * Patch: update utf8proc_data.c against unicode-data 12.1.0~pre1.
> * Add a new symbol.
>
> diffstat for utf8proc-2.2.0 utf8proc-2.3.0
>
> .travis.yml | 19
> CMakeLists.txt | 14
>
> | we use Makefile and don't use cmake for the debian package.
>
> MANIFEST |2
> Makefile | 38
>
> | upstream merged Debian's patch. most changes are due to it.
>
> NEWS.md | 106
> README.md|4
> bench/Makefile |3
>
> | again, makefile change due to merging Debian patch.
>
> data/Makefile| 23
>
> | again, makefile change due to merging Debian patch.
>
> data/charwidths.jl | 119
>
> | this is not used in the build process.
>
> debian/changelog | 10
> debian/control |4
>
> | I need to bump unicode-data requirement
>
> debian/libutf8proc2.symbols |1
>
> | + utf8proc_unicode_version@Base 2.3.0
> | harmless symbol addition.
>
> debian/patches/pass-hardening-flags.patch| 69
>
> | removed. merged by upstream.
>
> debian/patches/series|2
> debian/patches/unicode-data-12.1.0pre1.patch | 8979
>
> | utf8proc_data.c is automatically generated from unicode-data (= 12.0)
> | I have to update the file against unicode-data (= 12.1) in unstable.
> | The change is 100% auto-generated.
>
> debian/patches/use-unicode-data.patch| 25
>
> | rebased.
>
> libutf8proc.pc.in| 10
>
> | this pkgconfig file is newly added. Still not installed in debian package.
>
> test/graphemetest.c | 22
>
> | space trimming and just one more test case
>
> test/misc.c |4
>
> | just one more assertion
>
> utf8proc.c | 22
>
> | Simpler character-width computation, and the new symbol:
> |
> |+UTF8PROC_DLLEXPORT const char *utf8proc_unicode_version(void) {
> |+ return "12.0.0";
> |+}
> |
> | Well, I should patch it to "12.1.0" after sending this mail.
>
> utf8proc.h |8
>
> | comment updates and the prototype for the new symbol
>
> utf8proc_data.c |1
> +--
>
> | 100% auto-generated from unicode-data 12.1.0~pre1 (unstable)
>
> 22 files changed, 16417 insertions(+), 7511 deletions(-)
>
Bug#927958: [pre-a] unblock: utf8proc/2.3.0-1
Control: tags -1 moreinfo Mo Zhou: > Package: release.debian.org > Severity: normal > User: release.debian@packages.debian.org > Usertags: unblock > > Please unblock package utf8proc > > (explain the reason for the unblock here) > > I'm astonished that the unicode (11.* -> 12.*) transition happend at > such a deep freeze stage. utf8proc is tightly coupled with the > unicode-data version, and the new unicode-data version incured FTBFS: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927941 > > The simplest way to fix this bug is to bump utf8proc to 2.3.0 > > (include/attach the debdiff against the package in testing) > > According to upstream NEWs/changelog > https://github.com/JuliaStrings/utf8proc/commit/eb39b060e7e518941a912e1f51bae1cc6316f547 > And the commit history (97ef668 -> 454f601) > https://github.com/JuliaStrings/utf8proc/commits/master > The major change from 2.2.0 (testing) to 2.3.0 (not yet packaged) > is the support for unicode-data (= 12). There is no breaking change. > So I request an unblock for 2.3.0-1 > > unblock utf8proc/2.3.0-1 > > [...] > Please include a full debdiff of the changes. The link to a master branch with no clear marking of start/end commits makes it too time consuming for us to evaluate the request. Thanks, ~Niels
Bug#927958: [pre-a] unblock: utf8proc/2.3.0-1
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package utf8proc (explain the reason for the unblock here) I'm astonished that the unicode (11.* -> 12.*) transition happend at such a deep freeze stage. utf8proc is tightly coupled with the unicode-data version, and the new unicode-data version incured FTBFS: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927941 The simplest way to fix this bug is to bump utf8proc to 2.3.0 (include/attach the debdiff against the package in testing) According to upstream NEWs/changelog https://github.com/JuliaStrings/utf8proc/commit/eb39b060e7e518941a912e1f51bae1cc6316f547 And the commit history (97ef668 -> 454f601) https://github.com/JuliaStrings/utf8proc/commits/master The major change from 2.2.0 (testing) to 2.3.0 (not yet packaged) is the support for unicode-data (= 12). There is no breaking change. So I request an unblock for 2.3.0-1 unblock utf8proc/2.3.0-1 -- System Information: Debian Release: 10.0 APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled
