Bug#929341: cinnamon-settings-daemon mis-built without wacom support

[Maximiliano Curia]

¡Hola Fabio!

Resending to the bug report.

El 2019-08-22 a las 13:19 +0200, Fabio Fantoni escribió:

@Maxy: why you wrote in description that wacom plugin is unbuildable? archs
where package is missed was already excluded by the build-dep you removed


I don't remember, I assume it wasn't buildable at the time.

Happy hacking,
--
"If the code and the comments disagree, then both are probable wrong."
-- Norm Schryer
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature

Bug#929341: cinnamon-settings-daemon mis-built without wacom support

[Fabio Fantoni]

Hi, I did a check now to amd64 build log (
https://buildd.debian.org/status/fetch.php?pkg=cinnamon-settings-daemon=amd64=3.8.4-2=1536055845=0
) and seems that configure set that not have its support even if wacom
build-deps are present:

> ...
>
> checking for WACOM... no
>
> ...
>
>From debian/control:

> |Build-Depends:|
>
> ...
>
> |libwacom-dev (>= 0.4) [linux-any],|
>
I checked configure.ac:

> PKG_CHECK_MODULES(WACOM, [libwacom >= $LIBWACOM_REQUIRED_VERSION x11
> xi xtst gudev-1.0 cinnamon-desktop xorg-wacom librsvg-2.0 >=
> $LIBRSVG_REQUIRED_VERSION gtk+-3.0 >= 3.8.0],
> [build_wacom="true" AC_DEFINE(HAVE_WACOM, 1, [Define if wacom is being
> build])], [build_wacom="false"])
>From a fast look seems xorg-wacom missed, was removed by this commit:

https://salsa.debian.org/cinnamon-team/cinnamon-settings-daemon/commit/5b50e7d8e441c14a584736b6f29dec97dd9d8ddb

@Maxy: why you wrote in description that wacom plugin is unbuildable?
archs where package is missed was already excluded by the build-dep you
removed

Bug#929341: cinnamon-settings-daemon mis-built without wacom support

[Pascal V.]

Dear all,

Any progress on this? Is there an issue with the wacom module that requires
it to stay disabled?

Bug#929341: cinnamon-settings-daemon mis-built without wacom support

[David Lamparter]

Package: cinnamon-settings-daemon
Version: 3.8.4-2
Severity: important

Dear Maximiliano, dear Debian maintainers,


it seems that the cinnamon-settings-daemon package available in buster
for amd64 was mis-built without wacom support.  I have fetched the
source package and compiled it on my local system, and there is a
difference in the files:

--- upstream-contents.txt   2019-05-22 02:58:17.414589122 +0200
+++ ../local-contents.txt   2019-05-22 02:58:21.754581540 +0200
@@ -24,0 +25 @@
+-rw-r--r-- root/root   269 
/etc/xdg/autostart/cinnamon-settings-daemon-wacom.desktop
@@ -42 +43 @@
--rwxr-xr-x root/root 22520 
/usr/lib/x86_64-linux-gnu/cinnamon-settings-daemon/csd-input-helper
+-rwxr-xr-x root/root 18424 
/usr/lib/x86_64-linux-gnu/cinnamon-settings-daemon/csd-input-helper
@@ -43,0 +45 @@
+-rwxr-xr-x root/root 63560 
/usr/lib/x86_64-linux-gnu/cinnamon-settings-daemon/csd-list-wacom
@@ -53,0 +56,3 @@
+-rwxr-xr-x root/root117400 
/usr/lib/x86_64-linux-gnu/cinnamon-settings-daemon/csd-wacom
+-rwxr-xr-x root/root 14416 
/usr/lib/x86_64-linux-gnu/cinnamon-settings-daemon/csd-wacom-led-helper
+-rwxr-xr-x root/root 92376 
/usr/lib/x86_64-linux-gnu/cinnamon-settings-daemon/csd-wacom-osd
@@ -216,0 +222 @@
+-rw-r--r-- root/root   935 
/usr/share/polkit-1/actions/org.cinnamon.settings-daemon.plugins.wacom.policy

(this is cinnamon-settings-daemon_3.8.4-2_amd64.deb specifically)

As a result of this, since csd-wacom is not in the package, the Wacom
tablet settings simply have no effect.

I have made no modifications at all to the source package, I simply
fetched it (apt source cinnamon-settings-daemon), installed the build
deps (mk-build-deps -i) and built it (dpkg-buildpackage -j6 -b -uc -us)
and the wacom bits were built correctly.  Something must've gone wrong
on the build servers.  Not sure how to get a rebuild?  +b1 I guess?

Would be nice to get this fixed :)

Thanks,

-David

P.S.: I have checked arm64 and i386 packages, they are missing the wacom
bits too.  Would guess all architectures were mis-built somehow.